Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43852

SecurityRealm captcha should use no-store as well as no cache in cache-control

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      looking at the code I think that the no-store option should be used in addition to the no-cache.

      as navigating back or resubmitting the data will likely lead to an out of date captcha.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Wadeck Follonier
            Path:
            core/src/main/java/hudson/security/SecurityRealm.java
            test/src/test/java/hudson/security/SecurityRealmTest.java
            http://jenkins-ci.org/commit/jenkins/80d17f5a68739eafc27d5a3fd003b7eee4cfe8f3
            Log:
            JENKINS-43852 add caching options for captcha (#3126)

            • - remove whitespace
            • - correct unit tests
            • - copy/paste is bad
            • - second edit...
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wadeck Follonier Path: core/src/main/java/hudson/security/SecurityRealm.java test/src/test/java/hudson/security/SecurityRealmTest.java http://jenkins-ci.org/commit/jenkins/80d17f5a68739eafc27d5a3fd003b7eee4cfe8f3 Log: JENKINS-43852 add caching options for captcha (#3126) JENKINS-42852 add caching options for captcha - remove whitespace - correct unit tests - copy/paste is bad - second edit...
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The fix has been integrated towards 2.90

            Show
            oleg_nenashev Oleg Nenashev added a comment - The fix has been integrated towards 2.90
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Wadeck Follonier
            Path:
            core/src/main/java/hudson/security/SecurityRealm.java
            test/src/test/java/hudson/security/SecurityRealmTest.java
            http://jenkins-ci.org/commit/jenkins/179ac8df0803375e4e600b7c44547419636d44fe
            Log:
            JENKINS-43852 add caching options for captcha (#3126)

            • - remove whitespace
            • - correct unit tests
            • - copy/paste is bad
            • - second edit...

            (cherry picked from commit 80d17f5a68739eafc27d5a3fd003b7eee4cfe8f3)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wadeck Follonier Path: core/src/main/java/hudson/security/SecurityRealm.java test/src/test/java/hudson/security/SecurityRealmTest.java http://jenkins-ci.org/commit/jenkins/179ac8df0803375e4e600b7c44547419636d44fe Log: JENKINS-43852 add caching options for captcha (#3126) JENKINS-42852 add caching options for captcha - remove whitespace - correct unit tests - copy/paste is bad - second edit... (cherry picked from commit 80d17f5a68739eafc27d5a3fd003b7eee4cfe8f3)

              People

              • Assignee:
                wfollonier Wadeck Follonier
                Reporter:
                teilo James Nord
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: