Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43926

REGRESSION: Loading worm turns white too early when loading dashboard

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      Blue Ocean 1.1-beta4, Blue Ocean 1.1, Blue Ocean 1.1

      Description

      When cold loading (ie no cache) things can go "all white" and look broken for a few seconds. 

      This is due to the loading worm turning white prematurely .. 

        Attachments

          Issue Links

            Activity

            michaelneale Michael Neale created issue -
            michaelneale Michael Neale made changes -
            Field Original Value New Value
            Epic Link JENKINS-35749 [ 171790 ]
            michaelneale Michael Neale made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            michaelneale Michael Neale made changes -
            Summary Loading worm turns white too early when loading dashboard REGRESSION: Loading worm turns white too early when loading dashboard
            michaelneale Michael Neale made changes -
            Link This issue is duplicated by JENKINS-44131 [ JENKINS-44131 ]
            michaelneale Michael Neale made changes -
            Labels cloudbees-internal-steel
            michaelneale Michael Neale made changes -
            Sprint Blue Ocean 1.1-beta3 [ 316 ]
            Hide
            michaelneale Michael Neale added a comment -

            Keith Zantow Cliff Meyers is there any detail you could put on this and what a fix may be, perhaps may be a good one for nicu to take a look at to see how things load? 

            Show
            michaelneale Michael Neale added a comment - Keith Zantow Cliff Meyers is there any detail you could put on this and what a fix may be, perhaps may be a good one for nicu to take a look at to see how things load? 
            michaelneale Michael Neale made changes -
            Assignee Nicolae Pascu [ nicu ]
            michaelneale Michael Neale made changes -
            Rank Ranked lower
            michaelneale Michael Neale made changes -
            Priority Major [ 3 ] Minor [ 4 ]
            Hide
            cliffmeyers Cliff Meyers added a comment - - edited

            Probably two potential causes to this issue: the background color is changed too early, or it's actually being hidden inappropriately. Note that the loading indicator is automatically shown and hidden as XHR calls are made.

            Files of interest:

            • blueocean-web/src/main/resources/io/jenkins/blueocean/BlueOceanUi/index.jelly - that is where the id="loadbar" element is defined. Inline style block classes are used to set it up in its "white" state and increment itself while the page is loading.
            • blueocean-core-js/.../LoadingIndicator - this is a simple JS object to show/hide the indicator and change the bg color. You may want to add some logging here to show/hide methods just to ensure you know when these methods are being called.
            • blueocean-web/.../main.jsx. Once the extensions are fetched, the loadingIndicator color is switched. Assuming the reason the worm gets hidden is because the bgcolor changes too early, we could instead move the bgcolor change to a callback function that is passed to ReactDOM.render, so it happens after initial render is complete. If it disappears because it's actually being hidden, we need to look into why that is. Could be that something is making an XHR call much earlier in the lifecycle than before.
            Show
            cliffmeyers Cliff Meyers added a comment - - edited Probably two potential causes to this issue: the background color is changed too early, or it's actually being hidden inappropriately. Note that the loading indicator is automatically shown and hidden as XHR calls are made. Files of interest: blueocean-web/src/main/resources/io/jenkins/blueocean/BlueOceanUi/index.jelly - that is where the id="loadbar" element is defined. Inline style block classes are used to set it up in its "white" state and increment itself while the page is loading. blueocean-core-js/.../LoadingIndicator - this is a simple JS object to show/hide the indicator and change the bg color. You may want to add some logging here to show/hide methods just to ensure you know when these methods are being called. blueocean-web/.../main.jsx. Once the extensions are fetched, the loadingIndicator color is switched. Assuming the reason the worm gets hidden is because the bgcolor changes too early, we could instead move the bgcolor change to a callback function that is passed to ReactDOM.render, so it happens after initial render is complete. If it disappears because it's actually being hidden, we need to look into why that is. Could be that something is making an XHR call much earlier in the lifecycle than before.
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.1-beta4 [ 316 ] Blue Ocean 1.1-beta4, Blue Ocean 1.1-beta5 [ 316, 321 ]
            michaelneale Michael Neale made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            michaelneale Michael Neale made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.1-beta4, Blue Ocean 1.1 [ 316, 321 ] Blue Ocean 1.1-beta4, Blue Ocean 1.1, Blue Ocean 1.1 [ 316, 321, 331 ]
            nicu Nicolae Pascu made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            nicu Nicolae Pascu made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            jamesdumay James Dumay made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            jbriden Jenn Briden made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                nicu Nicolae Pascu
                Reporter:
                michaelneale Michael Neale
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: