Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44236

NFS stats related /proc files should also be gathered

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Right now, though there are already a decent amount of things retrieved, but this does not get NFS stats if they're available, which can be valuable for diagnosing potential perf related issues.

      Essentially, the missing files are the ones presented also through the nfsstats and mountstats commands:

      • /proc/net/rpc/nfsd
      • /proc/net/rpc/nfs
      • /proc/self/mountstats

      Now:

      cpuinfo.txt
      meminfo.txt
      mounts.txt
      self/
        cmdline
        environ
        limits.txt
        status.txt
      swaps.txt
      system-uptime.txt
      

      NOTE: main issue to watch out/test, probably, is that the current list seems to be unconditionally retrieved. So as those new files may or may not present, we need to make sure the support-bundle generation still works on system where NFS is absent.
      UPDATE: so actually, the standard support-core plugins's FileContent class already handles this: if a file cannot be found, it will carry on and just put a notice that it cannot be found in that file in the zip. Which makes sense in the end indeed: the goal of that plugin being to gather as much things as it can in a prod env. It this fails fast at the first issue, it'd probably be useless.

        Attachments

          Issue Links

            Activity

            Hide
            batmat Baptiste Mathus added a comment -

            After looking at the code, I think this improvement deserves/requires some factorization of JVMProcessSystemMetricsContents and SystemConfiguration. Those classes are apparently copy one from the other, with very few changes.

            Show
            batmat Baptiste Mathus added a comment - After looking at the code, I think this improvement deserves/requires some factorization of JVMProcessSystemMetricsContents and SystemConfiguration . Those classes are apparently copy one from the other, with very few changes.
            Show
            batmat Baptiste Mathus added a comment - PR in review https://github.com/jenkinsci/support-core-plugin/pull/112
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Baptiste Mathus
            Path:
            src/main/java/com/cloudbees/jenkins/support/impl/JVMProcessSystemMetricsContents.java
            src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java
            src/test/java/com/cloudbees/jenkins/support/SupportActionTest.java
            http://jenkins-ci.org/commit/support-core-plugin/1021568723083b7cc3c4eb4154a4845d5861ebe6
            Log:
            JENKINS-44236 NFS stats related /proc files should also be gathered

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/java/com/cloudbees/jenkins/support/impl/JVMProcessSystemMetricsContents.java src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java src/test/java/com/cloudbees/jenkins/support/SupportActionTest.java http://jenkins-ci.org/commit/support-core-plugin/1021568723083b7cc3c4eb4154a4845d5861ebe6 Log: JENKINS-44236 NFS stats related /proc files should also be gathered
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Baptiste Mathus
            Path:
            src/main/java/com/cloudbees/jenkins/support/impl/JVMProcessSystemMetricsContents.java
            src/main/java/com/cloudbees/jenkins/support/impl/ProcFilesRetriever.java
            src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java
            src/test/java/com/cloudbees/jenkins/support/SupportActionTest.java
            http://jenkins-ci.org/commit/support-core-plugin/5eebe47fd4497081c0e30d5bb416af320b6363c4
            Log:
            Merge pull request #112 from batmat/JENKINS-44236

            JENKINS-44236 NFS stats related /proc files should also be gathered

            Compare: https://github.com/jenkinsci/support-core-plugin/compare/06293e967b8b...5eebe47fd449

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/java/com/cloudbees/jenkins/support/impl/JVMProcessSystemMetricsContents.java src/main/java/com/cloudbees/jenkins/support/impl/ProcFilesRetriever.java src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java src/test/java/com/cloudbees/jenkins/support/SupportActionTest.java http://jenkins-ci.org/commit/support-core-plugin/5eebe47fd4497081c0e30d5bb416af320b6363c4 Log: Merge pull request #112 from batmat/ JENKINS-44236 JENKINS-44236 NFS stats related /proc files should also be gathered Compare: https://github.com/jenkinsci/support-core-plugin/compare/06293e967b8b...5eebe47fd449
            Hide
            batmat Baptiste Mathus added a comment -

            Released in 2.41

            Show
            batmat Baptiste Mathus added a comment - Released in 2.41

              People

              • Assignee:
                batmat Baptiste Mathus
                Reporter:
                batmat Baptiste Mathus
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: