Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4426

Added browsers for codeDOTgoogleDOTcom and bitbucketDOTorg.

    XMLWordPrintable

    Details

    • Type: Patch
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: mercurial-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      Added browsers for codeDOTgoogleDOTcom and bitbucketDOTorg.
      Outstanding is better support for validation of URLs in the UI.
      This version should retain backward compability with older versions
      of the plugin. This changeset is against revision r20468 of
      https://hudson.dev.java.net/svn/hudson/trunk/hudson/plugins/mercurial.

        Attachments

          Activity

          mfriedenhagen Mirko Friedenhagen created issue -
          Hide
          mfriedenhagen Mirko Friedenhagen added a comment -

          Created an attachment (id=898)
          Patch for multibrowser support in mercurial plugin

          Show
          mfriedenhagen Mirko Friedenhagen added a comment - Created an attachment (id=898) Patch for multibrowser support in mercurial plugin
          Hide
          mfriedenhagen Mirko Friedenhagen added a comment -

          The patch applies cleanly against r20468 if invoked like this:
          patch -p1 < alternate-browsers-for-mercurial.patch

          Show
          mfriedenhagen Mirko Friedenhagen added a comment - The patch applies cleanly against r20468 if invoked like this: patch -p1 < alternate-browsers-for-mercurial.patch
          Hide
          mfriedenhagen Mirko Friedenhagen added a comment -

          I have tested my version on Windows, Linux and MacOSX against 1.318 and 1.322 respectively.
          Worked against 'old' as well as new projects. Bitbucket output may be seen at
          http://zeibig.net:20080/job/jmemcache-daemon/changes, hgweb at
          http://zeibig.net:20080/job/HgKit/changes.

          I forgot to mention that this patch produces links to single file diffs and links to file revisions as well in
          src/main/resources/hudson/plugins/mercurial/MercurialChangeSetList/index.jelly

          Show
          mfriedenhagen Mirko Friedenhagen added a comment - I have tested my version on Windows, Linux and MacOSX against 1.318 and 1.322 respectively. Worked against 'old' as well as new projects. Bitbucket output may be seen at http://zeibig.net:20080/job/jmemcache-daemon/changes , hgweb at http://zeibig.net:20080/job/HgKit/changes . I forgot to mention that this patch produces links to single file diffs and links to file revisions as well in src/main/resources/hudson/plugins/mercurial/MercurialChangeSetList/index.jelly
          Hide
          mfriedenhagen Mirko Friedenhagen added a comment -

          Changed bitbucket-URL

          Show
          mfriedenhagen Mirko Friedenhagen added a comment - Changed bitbucket-URL
          Hide
          mfriedenhagen Mirko Friedenhagen added a comment -

          Created an attachment (id=903)
          Changed patch with cleaned up unit tests

          Show
          mfriedenhagen Mirko Friedenhagen added a comment - Created an attachment (id=903) Changed patch with cleaned up unit tests
          Hide
          jglick Jesse Glick added a comment -

          If I'm not mistaken this was already applied as 21668. If you have further
          refinements, please open separate issues.

          Show
          jglick Jesse Glick added a comment - If I'm not mistaken this was already applied as 21668. If you have further refinements, please open separate issues.
          jglick Jesse Glick made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          mfriedenhagen Mirko Friedenhagen added a comment -

          Done and working.

          Show
          mfriedenhagen Mirko Friedenhagen added a comment - Done and working.
          mfriedenhagen Mirko Friedenhagen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 134499 ] JNJira + In-Review [ 202885 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cyrille Le Clerc
          Path:
          jenkins-plugin/pom.xml
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher.java
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/help-ignoreAttachments.html
          http://jenkins-ci.org/commit/pipeline-maven-plugin/f3a423791cfd022a55912791332a4b10ca80b132
          Log:
          JENKINS-4426 add support for the jenkins junit-attachments plugin

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/pom.xml jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher.java jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/help-ignoreAttachments.html http://jenkins-ci.org/commit/pipeline-maven-plugin/f3a423791cfd022a55912791332a4b10ca80b132 Log: JENKINS-4426 add support for the jenkins junit-attachments plugin
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cyrille Le Clerc
          Path:
          jenkins-plugin/pom.xml
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher.java
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/help-ignoreAttachments.html
          http://jenkins-ci.org/commit/pipeline-maven-plugin/f222eacac91805b2816b98b7f49f50f45dd195ca
          Log:
          JENKINS-4426 add support for the jenkins junit-attachments plugin

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/pom.xml jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher.java jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/help-ignoreAttachments.html http://jenkins-ci.org/commit/pipeline-maven-plugin/f222eacac91805b2816b98b7f49f50f45dd195ca Log: JENKINS-4426 add support for the jenkins junit-attachments plugin
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cyrille Le Clerc
          Path:
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher.java
          http://jenkins-ci.org/commit/pipeline-maven-plugin/0149822b3ab2d6f454dfcf996bacdb8b54ced790
          Log:
          JENKINS-4426 Fix typo

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher.java http://jenkins-ci.org/commit/pipeline-maven-plugin/0149822b3ab2d6f454dfcf996bacdb8b54ced790 Log: JENKINS-4426 Fix typo

            People

            • Assignee:
              kohsuke Kohsuke Kawaguchi
              Reporter:
              mfriedenhagen Mirko Friedenhagen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: