Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44319

Need to adapt MSI and OSX packaging scripts for new CLI

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: packaging
    • Labels:
      None
    • Similar Issues:

      Description

      When generating MSI and OSX packages we are inspecting the environment variable JENKINS_SSH_KEY and if present it's used for authentication of CLI commands that invoke the distfork plugin (see here).

      The CLI command is then composed with a "-i /path/to/key" option. AFAIK now in the CLI this option does only make sense if used together with "-ssh" or "-remoting", being the latter not recommended.

      So basically if the normal thing will be to use "-ssh", which requires specifying a user, we need to enable a way of doing this.

      I propose using a new environment variable called JENKINS_SSH_USER in a similar way the JENKINS_SSH_KEY one is used. If it has some content, the -ssh -user xx@yy.zz part will be added to the command.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Franco
          Path:
          msi/build-on-jenkins.sh
          osx/build-on-jenkins.sh
          http://jenkins-ci.org/commit/packaging/3a27584def28645e9dfba796e5e06a3575d4247a
          Log:
          JENKINS-44319 SSH user variable

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Franco Path: msi/build-on-jenkins.sh osx/build-on-jenkins.sh http://jenkins-ci.org/commit/packaging/3a27584def28645e9dfba796e5e06a3575d4247a Log: JENKINS-44319 SSH user variable
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          msi/build-on-jenkins.sh
          osx/build-on-jenkins.sh
          http://jenkins-ci.org/commit/packaging/ddd86a854b2d9cd2de60bedacfee66e43d50e3b5
          Log:
          Merge pull request #98 from mafraba/ssh-user-variable

          JENKINS-44319 SSH user variable

          Compare: https://github.com/jenkinsci/packaging/compare/724f231cb496...ddd86a854b2d

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: msi/build-on-jenkins.sh osx/build-on-jenkins.sh http://jenkins-ci.org/commit/packaging/ddd86a854b2d9cd2de60bedacfee66e43d50e3b5 Log: Merge pull request #98 from mafraba/ssh-user-variable JENKINS-44319 SSH user variable Compare: https://github.com/jenkinsci/packaging/compare/724f231cb496...ddd86a854b2d

            People

            • Assignee:
              mfranco Manuel Franco
              Reporter:
              mfranco Manuel Franco
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: