Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44321

REGRESSION: Cannot load changes tab

    XMLWordPrintable

    Details

    • Sprint:
      Blue Ocean 1.1
    • Similar Issues:

      Description

      Visit
      https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/bug%2Fjs-lint-or-test-failures-dont-fail-build/9/changes/

      You should see this error in the console

      There has been an error while trying to get the data. TypeError: changeSet.map is not a function
          at RunDetailsChanges.render (jenkins-js-extension.js:47020)
          at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (blueocean.js:84968)
          at ReactCompositeComponentWrapper._renderValidatedComponent (blueocean.js:84991)
          at ReactCompositeComponentWrapper.performInitialMount (blueocean.js:84533)
          at ReactCompositeComponentWrapper.mountComponent (blueocean.js:84429)
          at Object.mountComponent (blueocean.js:91442)
          at ReactDOMComponent.mountChildren (blueocean.js:90320)
          at ReactDOMComponent._createInitialChildren (blueocean.js:85896)
          at ReactDOMComponent.mountComponent (blueocean.js:85721)
          at Object.mountComponent (blueocean.js:91442)
      

        Attachments

          Issue Links

            Activity

            Hide
            cliffmeyers Cliff Meyers added a comment -

            James Dumay this was occurring because a Run object was being returned that did not include a "changeSet" property. Since ImmutableJS is used in a parent view, the "changeSet" property was being defaulted (inappropriately) to a ChangeSetRecord rather than an empty array. This bypassed some of the null / empty array checking that was in place.

            I couldn't actually reproduce the problem locally: "changeSet" was always present with an empty array. I'm not sure if that might be because my local Jenkins or plugins could be out of date?

            I have updated the ImmutableJS definition so if this happens again for some reason, it should ensure that missing "changeSet" is populated as empty array.

            Show
            cliffmeyers Cliff Meyers added a comment - James Dumay this was occurring because a Run object was being returned that did not include a "changeSet" property. Since ImmutableJS is used in a parent view, the "changeSet" property was being defaulted (inappropriately) to a ChangeSetRecord rather than an empty array. This bypassed some of the null / empty array checking that was in place. I couldn't actually reproduce the problem locally: "changeSet" was always present with an empty array. I'm not sure if that might be because my local Jenkins or plugins could be out of date? I have updated the ImmutableJS definition so if this happens again for some reason, it should ensure that missing "changeSet" is populated as empty array.

              People

              • Assignee:
                cliffmeyers Cliff Meyers
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: