Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44322

email-ext sends wrong build status when called from declarative script

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: token-macro-plugin
    • Labels:
      None
    • Environment:
      Jenkins 2.61
      email-ext plugin 2.57.2
    • Similar Issues:

      Description

      I have a simple declarative script:

      pipeline {
          agent { label "mypc1" }
          stages {
              stage('build') {
                  steps {
                      sh '''
                          python --version
                      '''
                  }
              }
          }
          post {
      
              // We want to send notification emails to daldrich and the culprits.
              // The subject and body use the default content set in 'Jenkins > Configure System'
      
              success {
                  script{ emailext (body: '${DEFAULT_CONTENT}',
                                    recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                                    subject: '${DEFAULT_SUBJECT}',
                                    to: 'daldrich')
                  }
              }
              failure {
                  script{ emailext (body: '${DEFAULT_CONTENT}',
                                    recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                                    subject: '${DEFAULT_SUBJECT}',
                                    to: 'daldrich')
                  }
              }
              unstable {
                  script{ emailext (body: '${DEFAULT_CONTENT}',
                                    recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                                    subject: '${DEFAULT_SUBJECT}',
                                    to: 'daldrich')
                  }
              }
              changed {
                  script{ emailext (body: '${DEFAULT_CONTENT}',
                                    recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                                    subject: '${DEFAULT_SUBJECT}',
                                    to: 'daldrich')
                  }
              }
          }
      }
      

      Problem 1

      The email subject uses : '${DEFAULT_SUBJECT}', which ends with ‘$BUILD_STATUS!’. In the received email for a successful build the build status is ‘Building!’:

      Experimental_LedaAP_gcc_build » trunk - Build # 43 - Building!

      This is in ‘post’ so I expect the status to be ‘Success!’.

      abayer wrote on IRC:

      The build hasn't actually finished yet at that point. email-ext probably needs to be changed to be aware of that.

      So I think there is a bug in the plugin.

      Problem 2

      I'm expecting the email to be sent to daldrich and the culprits. There are culprits since there were svn commits by another user since the job last ran successfully.

      On Failure, the recipients are daldrich and the culprits, which is correct.

      When the failure is Fixed, the recipients are only daldrich - the culprits are not included, which is incorrect. (In a traditional Jenkins job, recipients and culprits are notified of Fixed, if they are specified in the job configuration).

      I think this is also a bug in the plugin.

        Attachments

          Issue Links

            Activity

            Hide
            bkihm Benjamin Kihm added a comment -

            We have the problem again with Token Macro Version 2.7 and Email Extension 2.65 on Jenkins 2.164.1. Similar to David Aldrich we use a shell script call which fails and an email block after the build stage:

              post {
                unstable {
                  emailext to: '*****@*****.com, *****@*****.com',
                  recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                  subject: '${DEFAULT_SUBJECT}',
                  body: '${DEFAULT_CONTENT}'
                }    failure {
                  emailext to: '*****@*****.com, *****@*****.com',
                  recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                  subject: '${DEFAULT_SUBJECT}',
                  body: '${DEFAULT_CONTENT}'
                }    fixed {
                  emailext to: '*****@*****.com, *****@*****.com',
                  recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                  subject: '${DEFAULT_SUBJECT}',
                  body: '${DEFAULT_CONTENT}'
                }
              }
            

            In the Email subject we got

            ***-service » branchName - Build # 4 - SUCCESS
            
            

            instead of 

            ***-service » branchName - Build # 4 - Failure
            

            Our setting for the default email subject is

            $PROJECT_NAME - Build # $BUILD_NUMBER - $BUILD_STATUS!
            
            Show
            bkihm Benjamin Kihm added a comment - We have the problem again with Token Macro Version 2.7 and Email Extension 2.65 on Jenkins 2.164.1. Similar to David Aldrich we use a shell script call which fails and an email block after the build stage: post { unstable { emailext to: '*****@*****.com, *****@*****.com' , recipientProviders: [[$class: 'CulpritsRecipientProvider' ]], subject: '${DEFAULT_SUBJECT}' , body: '${DEFAULT_CONTENT}' } failure { emailext to: '*****@*****.com, *****@*****.com' , recipientProviders: [[$class: 'CulpritsRecipientProvider' ]], subject: '${DEFAULT_SUBJECT}' , body: '${DEFAULT_CONTENT}' } fixed { emailext to: '*****@*****.com, *****@*****.com' , recipientProviders: [[$class: 'CulpritsRecipientProvider' ]], subject: '${DEFAULT_SUBJECT}' , body: '${DEFAULT_CONTENT}' } } In the Email subject we got ***-service » branchName - Build # 4 - SUCCESS instead of  ***-service » branchName - Build # 4 - Failure Our setting for the default email subject is $PROJECT_NAME - Build # $BUILD_NUMBER - $BUILD_STATUS!
            Hide
            benbrummer Benjamin Brummer added a comment - - edited

            Benjamin Kihm, here we have the same error since with Jenkins 2.164.1 and email ext 2.65 (2.64)

            /* Set email content */
            def subjectContent = '$PROJECT_NAME - Build # $BUILD_NUMBER - $BUILD_STATUS!'
            def bodyContent = '${SCRIPT, template="groovy-html.template"}'
            .....
            
            stage('Test') {
             steps {
              bat 'exit 1'
             }
            }
            
            ...
            
            fixed {
              emailext(
               body: bodyContent,
               recipientProviders: [
               developers(),
               requestor()
               ],
               subject: subjectContent
              )
            }
            

            Build on Jenkins fails and is red. Email says "Test - Build # 52 - SUCCESS!

            Show
            benbrummer Benjamin Brummer added a comment - - edited Benjamin Kihm , here we have the same error since with Jenkins 2.164.1 and email ext 2.65 (2.64) /* Set email content */ def subjectContent = '$PROJECT_NAME - Build # $BUILD_NUMBER - $BUILD_STATUS!' def bodyContent = '${SCRIPT, template= "groovy-html.template" }' ..... stage( 'Test' ) { steps { bat 'exit 1' } } ... fixed { emailext( body: bodyContent, recipientProviders: [ developers(), requestor() ], subject: subjectContent ) } Build on Jenkins fails and is red. Email says "Test - Build # 52 - SUCCESS!
            Hide
            dnusbaum Devin Nusbaum added a comment -

            Benjamin Kihm Benjamin Brummer I suspect that you are running into JENKINS-56402, which is a recent problem in Pipeline: Declarative Plugin version 1.3.5 and 1.3.6 that should be fixed in the upcoming 1.3.7 release, see that issue for details if you are running those versions currently.

            Show
            dnusbaum Devin Nusbaum added a comment - Benjamin Kihm Benjamin Brummer I suspect that you are running into JENKINS-56402 , which is a recent problem in Pipeline: Declarative Plugin version 1.3.5 and 1.3.6 that should be fixed in the upcoming 1.3.7 release, see that issue for details if you are running those versions currently.
            Hide
            bkihm Benjamin Kihm added a comment -

            Devin Nusbaum: Thank you for the hint. This would explain why a rollback to previous versions (Token Macro 2.6 and Email Extension 2.63) do not helped out.

            Show
            bkihm Benjamin Kihm added a comment - Devin Nusbaum : Thank you for the hint. This would explain why a rollback to previous versions (Token Macro 2.6 and Email Extension 2.63) do not helped out.
            Hide
            bkihm Benjamin Kihm added a comment - - edited

            A rollback of Declarative plugin to v1.3.4.1. helped out.

            I have closed this ticket again

            Show
            bkihm Benjamin Kihm added a comment - - edited A rollback of Declarative plugin to v1.3.4.1. helped out. I have closed this ticket again

              People

              • Assignee:
                slide_o_mix Alex Earl
                Reporter:
                davida2009 David Aldrich
              • Votes:
                2 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: