Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44335

"Build now" should override build throttle

    Details

    • Similar Issues:

      Description

      We're using the branch API build throttle, limiting builds to 12/day. A newly triggered build happily sits in the queue. The only way for me to force the build to happen now, rather than in (at most) 2 hours, is to change the job configuration. Clicking on "Build Now" on the job in the build queue changes nothing.

       

      Expected:

      Clicking "Build Now" on the job waiting in the build queue should trigger the build immediately, regardless of build job throttle settings.

        Attachments

          Activity

          Hide
          jglick Jesse Glick added a comment -

          More broadly I suppose the throttle should only apply to the branch indexing cause.

          Show
          jglick Jesse Glick added a comment - More broadly I suppose the throttle should only apply to the branch indexing cause.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/branch/RateLimitBranchProperty.java
          src/main/resources/jenkins/branch/RateLimitBranchProperty/JobPropertyImpl/config.jelly
          src/main/resources/jenkins/branch/RateLimitBranchProperty/JobPropertyImpl/help-userBoost.html
          src/main/resources/jenkins/branch/RateLimitBranchProperty/config.jelly
          src/main/resources/jenkins/branch/RateLimitBranchProperty/help-userBoost.html
          src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java
          http://jenkins-ci.org/commit/branch-api-plugin/7eb8aebd9ecfc776682739ad4419df0dfe79b970
          Log:
          [FIXED JENKINS-44335] Add user boosting capability to rate limit property

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/RateLimitBranchProperty.java src/main/resources/jenkins/branch/RateLimitBranchProperty/JobPropertyImpl/config.jelly src/main/resources/jenkins/branch/RateLimitBranchProperty/JobPropertyImpl/help-userBoost.html src/main/resources/jenkins/branch/RateLimitBranchProperty/config.jelly src/main/resources/jenkins/branch/RateLimitBranchProperty/help-userBoost.html src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java http://jenkins-ci.org/commit/branch-api-plugin/7eb8aebd9ecfc776682739ad4419df0dfe79b970 Log: [FIXED JENKINS-44335] Add user boosting capability to rate limit property
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java
          http://jenkins-ci.org/commit/branch-api-plugin/463ecf7047d7155d9d7dab8464164e80319c4f41
          Log:
          JENKINS-44335 Tweat test timeouts

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java http://jenkins-ci.org/commit/branch-api-plugin/463ecf7047d7155d9d7dab8464164e80319c4f41 Log: JENKINS-44335 Tweat test timeouts
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java
          http://jenkins-ci.org/commit/branch-api-plugin/ed6169cc12b562f5c61f647283e3b665b0292891
          Log:
          JENKINS-44335 Aha the test was on the finish not the start condition

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java http://jenkins-ci.org/commit/branch-api-plugin/ed6169cc12b562f5c61f647283e3b665b0292891 Log: JENKINS-44335 Aha the test was on the finish not the start condition
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/branch/RateLimitBranchProperty.java
          src/main/resources/jenkins/branch/RateLimitBranchProperty/JobPropertyImpl/config.jelly
          src/main/resources/jenkins/branch/RateLimitBranchProperty/JobPropertyImpl/help-userBoost.html
          src/main/resources/jenkins/branch/RateLimitBranchProperty/config.jelly
          src/main/resources/jenkins/branch/RateLimitBranchProperty/help-userBoost.html
          src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java
          http://jenkins-ci.org/commit/branch-api-plugin/4200a1d441a4366ed791a70c7e1cc3bae6148adb
          Log:
          Merge pull request #115 from stephenc/jenkins-44335

          [FIXED JENKINS-44335] Add user boosting capability to rate limit property

          Compare: https://github.com/jenkinsci/branch-api-plugin/compare/5f1a1af2d503...4200a1d441a4

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/RateLimitBranchProperty.java src/main/resources/jenkins/branch/RateLimitBranchProperty/JobPropertyImpl/config.jelly src/main/resources/jenkins/branch/RateLimitBranchProperty/JobPropertyImpl/help-userBoost.html src/main/resources/jenkins/branch/RateLimitBranchProperty/config.jelly src/main/resources/jenkins/branch/RateLimitBranchProperty/help-userBoost.html src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java http://jenkins-ci.org/commit/branch-api-plugin/4200a1d441a4366ed791a70c7e1cc3bae6148adb Log: Merge pull request #115 from stephenc/jenkins-44335 [FIXED JENKINS-44335] Add user boosting capability to rate limit property Compare: https://github.com/jenkinsci/branch-api-plugin/compare/5f1a1af2d503...4200a1d441a4

            People

            • Assignee:
              stephenconnolly Stephen Connolly
              Reporter:
              mgerstel Markus Gerstel
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: