Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44402

"Cancel shutdown" queue widget link inserted via AJAX does not work

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Steps to reproduce:

      1. Select "Jenkins" (drop-down arrow) -> "Manage Jenkins" -> "Prepare for Shutdown" (see https://issues.jenkins-ci.org/browse/JENKINS-38175?focusedCommentId=273918&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-273918)
      2. Click "cancel" link (left pane)

      Result: I get "POST is required for jenkins.model.Jenkins.doCancelQuietDown" (/cancelQuietDown). Clicking "Try POSTing" gives the 403 error:

      Problem accessing /cancelQuietDown. Reason: No valid crumb was included in the request

       

        Attachments

          Issue Links

            Activity

            Hide
            dnusbaum Devin Nusbaum added a comment - - edited

            PR #3376 submitted with the above patch, which is a hack but does fix the issue. If anyone has some feedback or advice about fixing the root cause then I think that would be preferred.

            Show
            dnusbaum Devin Nusbaum added a comment - - edited PR #3376 submitted with the above patch, which is a hack but does fix the issue. If anyone has some feedback or advice about fixing the root cause then I think that would be preferred.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Devin Nusbaum
            Path:
            core/src/main/resources/lib/hudson/queue.jelly
            http://jenkins-ci.org/commit/jenkins/b2cdcf02186f83683169eae16423f8c9e6c579f7
            Log:
            JENKINS-44402 Workaround to make cancel shutdown work when loaded by AJAX

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Devin Nusbaum Path: core/src/main/resources/lib/hudson/queue.jelly http://jenkins-ci.org/commit/jenkins/b2cdcf02186f83683169eae16423f8c9e6c579f7 Log: JENKINS-44402 Workaround to make cancel shutdown work when loaded by AJAX
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/resources/lib/hudson/queue.jelly
            http://jenkins-ci.org/commit/jenkins/d534d5dc9dc09e1388dea80553e261015b072eb2
            Log:
            Merge pull request #3376 from dwnusbaum/JENKINS-44402

            JENKINS-44402 Make cancel shutdown link work when loaded via AJAX

            Compare: https://github.com/jenkinsci/jenkins/compare/be2dbec1cd14...d534d5dc9dc0

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/resources/lib/hudson/queue.jelly http://jenkins-ci.org/commit/jenkins/d534d5dc9dc09e1388dea80553e261015b072eb2 Log: Merge pull request #3376 from dwnusbaum/ JENKINS-44402 JENKINS-44402 Make cancel shutdown link work when loaded via AJAX Compare: https://github.com/jenkinsci/jenkins/compare/be2dbec1cd14...d534d5dc9dc0
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The fix has been integrated towards 2.114
            Thanks Devin Nusbaum!

            Show
            oleg_nenashev Oleg Nenashev added a comment - The fix has been integrated towards 2.114 Thanks Devin Nusbaum !
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Devin Nusbaum
            Path:
            core/src/main/resources/lib/hudson/queue.jelly
            http://jenkins-ci.org/commit/jenkins/6876eaa7f846279fbbc23cfd2ef353841a08d66f
            Log:
            JENKINS-44402 Workaround to make cancel shutdown work when loaded by AJAX

            (cherry picked from commit b2cdcf02186f83683169eae16423f8c9e6c579f7)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Devin Nusbaum Path: core/src/main/resources/lib/hudson/queue.jelly http://jenkins-ci.org/commit/jenkins/6876eaa7f846279fbbc23cfd2ef353841a08d66f Log: JENKINS-44402 Workaround to make cancel shutdown work when loaded by AJAX (cherry picked from commit b2cdcf02186f83683169eae16423f8c9e6c579f7)

              People

              • Assignee:
                dnusbaum Devin Nusbaum
                Reporter:
                owood Owen Wood
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: