Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44579

Poor performance removing a folder when Favorite plugin is installed

    XMLWordPrintable

    Details

    • Epic Link:
    • Sprint:
      Blue Ocean 1.1
    • Similar Issues:

      Description

      Removing a folder can take more than 5 minutes if the folder contains a lot of jobs or subfolder and you have a large number of Jenkins user in your instance.

      I did some test with a folder structure containing 100 items, going from 100 to 1000 users (using https://wiki.jenkins-ci.org/display/JENKINS/Mock+Security+Realm+Plugin) and the time needed to perform the deletion was duplicated

      The problem seems to be located here, where for each item to delete iterate over all users in the instance.

      The severity of the problem is greater or less depending on how users are provisioned (LDAP, Jenkins internal database,...)

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James Dumay
          Path:
          pom.xml
          src/main/java/hudson/plugins/favorite/user/Clock.java
          src/main/java/hudson/plugins/favorite/user/FavoriteJobListener.java
          src/main/java/hudson/plugins/favorite/user/FavoriteUserProperty.java
          src/test/java/hudson/plugins/favorite/user/FavoriteUserPropertyTest.java
          http://jenkins-ci.org/commit/favorite-plugin/3c1e5ac6aeaf31541c2682ce9e8ef67625a1f30d
          Log:
          JENKINS-44579 avoid performance issues on delete by lazily removing favorites that have been deleted

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Dumay Path: pom.xml src/main/java/hudson/plugins/favorite/user/Clock.java src/main/java/hudson/plugins/favorite/user/FavoriteJobListener.java src/main/java/hudson/plugins/favorite/user/FavoriteUserProperty.java src/test/java/hudson/plugins/favorite/user/FavoriteUserPropertyTest.java http://jenkins-ci.org/commit/favorite-plugin/3c1e5ac6aeaf31541c2682ce9e8ef67625a1f30d Log: JENKINS-44579 avoid performance issues on delete by lazily removing favorites that have been deleted
          Show
          jamesdumay James Dumay added a comment - PR https://github.com/jenkinsci/favorite-plugin/pull/13
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James Dumay
          Path:
          Jenkinsfile
          http://jenkins-ci.org/commit/favorite-plugin/99242aa343e0ddd07e0707e798e2e89ebcbf2612
          Log:
          Merge branch 'master' of github.com:jenkinsci/favorite-plugin into topic/JENKINS-44579

          Compare: https://github.com/jenkinsci/favorite-plugin/compare/c93afd50b3b2...99242aa343e0

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Dumay Path: Jenkinsfile http://jenkins-ci.org/commit/favorite-plugin/99242aa343e0ddd07e0707e798e2e89ebcbf2612 Log: Merge branch 'master' of github.com:jenkinsci/favorite-plugin into topic/ JENKINS-44579 Compare: https://github.com/jenkinsci/favorite-plugin/compare/c93afd50b3b2...99242aa343e0
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James William Dumay
          Path:
          src/main/java/hudson/plugins/favorite/user/FavoriteJobListener.java
          src/main/java/hudson/plugins/favorite/user/FavoriteUserProperty.java
          src/test/java/hudson/plugins/favorite/user/FavoriteUserPropertyTest.java
          http://jenkins-ci.org/commit/favorite-plugin/34d5deca05e6eda20aa6247b7dfb17441465f355
          Log:
          JENKINS-44579 avoid performance issues on delete by lazily removing f… (#13)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James William Dumay Path: src/main/java/hudson/plugins/favorite/user/FavoriteJobListener.java src/main/java/hudson/plugins/favorite/user/FavoriteUserProperty.java src/test/java/hudson/plugins/favorite/user/FavoriteUserPropertyTest.java http://jenkins-ci.org/commit/favorite-plugin/34d5deca05e6eda20aa6247b7dfb17441465f355 Log: JENKINS-44579 avoid performance issues on delete by lazily removing f… (#13)
          Hide
          jamesdumay James Dumay added a comment -

          Fixed in Favorite 2.1.0

          Show
          jamesdumay James Dumay added a comment - Fixed in Favorite 2.1.0

            People

            • Assignee:
              jamesdumay James Dumay
              Reporter:
              dariver Darío Villadiego
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: