Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44619

ReplayAction should check Job.isBuildable

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      ReplayAction.isEnabled ought to check Job.isBuildable so that we do not offer to replay a disabled job, a dead branch project, etc. (Probably doRun should also report an HTTP error if run returns null, as it would for an unbuildable job among other cases.)

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            More salient after JENKINS-27299.

            Show
            jglick Jesse Glick added a comment - More salient after  JENKINS-27299 .
            Show
            abayer Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/workflow-cps-plugin/pull/173
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayAction.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayActionTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/42f668240d5827e544768311b33b6da0fd4fb59e
            Log:
            [FIXED JENKINS-44619] Don't allow replays of nonbuildable jobs

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayAction.java src/test/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayActionTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/42f668240d5827e544768311b33b6da0fd4fb59e Log: [FIXED JENKINS-44619] Don't allow replays of nonbuildable jobs
            Hide
            abayer Andrew Bayer added a comment -

            Merged, will be in next release (presumably 2.42)

            Show
            abayer Andrew Bayer added a comment - Merged, will be in next release (presumably 2.42)

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: