Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44627

blueocean-display-url tests are failing if run in systems without git user.name

    XMLWordPrintable

    Details

    • Sprint:
      Blue Ocean 1.1
    • Similar Issues:

      Description

      Description

      The blueocean-display-url tests perform some commits as part of the setup, if the tests are executed in an environment without git user.name and user.email properties configured the tests are going to fail.

      Most developer machines already have a global user configured, but for example if the tests are executed in a docker container set up by a CI server (like Jenkins) is possible for them to fail

      The fix is very easy, just add the author to the commit steps of the tests

      To reproduce

      Run the tests in an environment without git user.name and user.email configured

        Attachments

          Issue Links

            Activity

            Hide
            vivek Vivek Pandey added a comment -

            Raul Arabaolaza Thanks for providing the fix, however right fix is to simply use git tests jar. I am going to close your PR https://github.com/jenkinsci/blueocean-display-url-plugin/pull/6 with https://github.com/jenkinsci/blueocean-display-url-plugin/pull/7.

            Show
            vivek Vivek Pandey added a comment - Raul Arabaolaza Thanks for providing the fix, however right fix is to simply use git tests jar. I am going to close your PR https://github.com/jenkinsci/blueocean-display-url-plugin/pull/6 with https://github.com/jenkinsci/blueocean-display-url-plugin/pull/7 .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Vivek Pandey
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/AbstractSampleDVCSRepoRule.java
            src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/AbstractSampleRepoRule.java
            src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImplTest.java
            src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/GitSampleRepoRule.java
            src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/GitUtil.java
            http://jenkins-ci.org/commit/blueocean-display-url-plugin/590c9d00a7cbad12e550af5eb42b39ecabbc8b8e
            Log:
            JENKINS-44627# Use git tests jar (#7)

            Fixes issue where if user.name and user.email not set causes tests
            to fail.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vivek Pandey Path: pom.xml src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/AbstractSampleDVCSRepoRule.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/AbstractSampleRepoRule.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImplTest.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/GitSampleRepoRule.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/GitUtil.java http://jenkins-ci.org/commit/blueocean-display-url-plugin/590c9d00a7cbad12e550af5eb42b39ecabbc8b8e Log: JENKINS-44627 # Use git tests jar (#7) Fixes issue where if user.name and user.email not set causes tests to fail.

              People

              • Assignee:
                vivek Vivek Pandey
                Reporter:
                rarabaolaza Raul Arabaolaza
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: