Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44743

Multi OU should not use serverUrls as unique identifier of configuration

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Raised during discussion on https://github.com/jenkinsci/ldap-plugin/pull/17

      We should instead use a compund key to identify the configuration, but only using the fields that are actually needed to find the user, so that a slight configuration change doesn't throw out logged in users.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/test/java/hudson/security/LDAPEmbeddedTest.java
            http://jenkins-ci.org/commit/ldap-plugin/9ff3f123515e6e5f47a1e0db6b5775c687b9dcfe
            Log:
            JENKINS-44743 Add test cases to prove that rootDN is prepended to userSearchBase

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/test/java/hudson/security/LDAPEmbeddedTest.java http://jenkins-ci.org/commit/ldap-plugin/9ff3f123515e6e5f47a1e0db6b5775c687b9dcfe Log: JENKINS-44743 Add test cases to prove that rootDN is prepended to userSearchBase
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: rsandell
            Path:
            src/main/java/hudson/security/LDAPSecurityRealm.java
            src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java
            src/main/resources/jenkins/security/plugins/ldap/Messages.properties
            src/test/java/hudson/security/LDAPSecurityRealmTest.java
            src/test/java/hudson/security/LdapMultiEmbedded2Test.java
            src/test/java/jenkins/security/plugins/ldap/LDAPConfigurationTest.java
            http://jenkins-ci.org/commit/ldap-plugin/9f180091415f364b85c8bcae6ba5f83c82bf9425
            Log:
            JENKINS-44743 Use a compound key to identify server configurations

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rsandell Path: src/main/java/hudson/security/LDAPSecurityRealm.java src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java src/main/resources/jenkins/security/plugins/ldap/Messages.properties src/test/java/hudson/security/LDAPSecurityRealmTest.java src/test/java/hudson/security/LdapMultiEmbedded2Test.java src/test/java/jenkins/security/plugins/ldap/LDAPConfigurationTest.java http://jenkins-ci.org/commit/ldap-plugin/9f180091415f364b85c8bcae6ba5f83c82bf9425 Log: JENKINS-44743 Use a compound key to identify server configurations
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: rsandell
            Path:
            src/main/java/hudson/security/LDAPSecurityRealm.java
            src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java
            http://jenkins-ci.org/commit/ldap-plugin/82b6bdb3fbb5ed605f5f2c80847eae15df07378b
            Log:
            JENKINS-44743 Fix findbugs warnings

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rsandell Path: src/main/java/hudson/security/LDAPSecurityRealm.java src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java http://jenkins-ci.org/commit/ldap-plugin/82b6bdb3fbb5ed605f5f2c80847eae15df07378b Log: JENKINS-44743 Fix findbugs warnings
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: rsandell
            Path:
            src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java
            src/test/java/jenkins/security/plugins/ldap/LDAPConfigurationTest.java
            http://jenkins-ci.org/commit/ldap-plugin/0002799e713e79e4399f9097be38cbc01f10605e
            Log:
            JENKINS-44743 Normalize userSearchBase as key instead of rootDB and userSearchBase

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rsandell Path: src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java src/test/java/jenkins/security/plugins/ldap/LDAPConfigurationTest.java http://jenkins-ci.org/commit/ldap-plugin/0002799e713e79e4399f9097be38cbc01f10605e Log: JENKINS-44743 Normalize userSearchBase as key instead of rootDB and userSearchBase
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: rsandell
            Path:
            src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java
            http://jenkins-ci.org/commit/ldap-plugin/905d1776588ad506e7e5f486c2728fb7bf42b238
            Log:
            JENKINS-44743 Use Base64 encoder from commons.codec

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rsandell Path: src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java http://jenkins-ci.org/commit/ldap-plugin/905d1776588ad506e7e5f486c2728fb7bf42b238 Log: JENKINS-44743 Use Base64 encoder from commons.codec
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: rsandell
            Path:
            src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java
            src/test/java/jenkins/security/plugins/ldap/LDAPConfigurationTest.java
            http://jenkins-ci.org/commit/ldap-plugin/3d4ae8307d778517bd4e9d0e93a2c686c1278bd2
            Log:
            JENKINS-44743 Dumb down userSearchBase normalization a bit

            Apparently the current rootDn suffixing is not as smart as I was

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rsandell Path: src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java src/test/java/jenkins/security/plugins/ldap/LDAPConfigurationTest.java http://jenkins-ci.org/commit/ldap-plugin/3d4ae8307d778517bd4e9d0e93a2c686c1278bd2 Log: JENKINS-44743 Dumb down userSearchBase normalization a bit Apparently the current rootDn suffixing is not as smart as I was
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Robert Sandell
            Path:
            src/main/java/hudson/security/LDAPSecurityRealm.java
            src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java
            src/main/resources/jenkins/security/plugins/ldap/Messages.properties
            src/test/java/hudson/security/LDAPSecurityRealmTest.java
            src/test/java/hudson/security/LdapMultiEmbedded2Test.java
            src/test/java/jenkins/security/plugins/ldap/LDAPConfigurationTest.java
            http://jenkins-ci.org/commit/ldap-plugin/2de2b5dd9ccb8d095956a6f43037abbecfa32319
            Log:
            Merge pull request #19 from rsandell/JENKINS-44743

            JENKINS-44743 Use a compound key to identify server configurations

            Compare: https://github.com/jenkinsci/ldap-plugin/compare/9ff3f123515e...2de2b5dd9ccb

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: src/main/java/hudson/security/LDAPSecurityRealm.java src/main/java/jenkins/security/plugins/ldap/LDAPConfiguration.java src/main/resources/jenkins/security/plugins/ldap/Messages.properties src/test/java/hudson/security/LDAPSecurityRealmTest.java src/test/java/hudson/security/LdapMultiEmbedded2Test.java src/test/java/jenkins/security/plugins/ldap/LDAPConfigurationTest.java http://jenkins-ci.org/commit/ldap-plugin/2de2b5dd9ccb8d095956a6f43037abbecfa32319 Log: Merge pull request #19 from rsandell/ JENKINS-44743 JENKINS-44743 Use a compound key to identify server configurations Compare: https://github.com/jenkinsci/ldap-plugin/compare/9ff3f123515e...2de2b5dd9ccb
            Hide
            rsandell rsandell added a comment -

            Released in 1.16

            Show
            rsandell rsandell added a comment - Released in 1.16

              People

              • Assignee:
                rsandell rsandell
                Reporter:
                rsandell rsandell
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: