Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44750

Unverified agents don't start after plugin update

    Details

    • Similar Issues:

      Description

      Today on ci.jenkins.io: R. Tyler Croy updated the plugin, and after a restart, the queue filled and no agents were provisioned.

      Jenkins log showed tons of messages like these:

      Jun 07, 2017 4:01:06 PM com.microsoft.azure.vmagent.AzureVMCloud canProvision
      INFO: AzureVMCloud: canProvision: template ubuntu-jenkinsinfra is awaiting verification or has failed verification
      Jun 07, 2017 4:01:06 PM com.microsoft.azure.vmagent.AzureVMCloudVerificationTask registerTemplateHelper
      INFO: AzureVMCloudVerificationTask: registerTemplateHelper: Registering template ubuntu-jenkinsinfra on AzureVMAgents-... for verification

      Clicking 'Verify Template' in Jenkins system configuration wasn't enough, one apparently just had to save the system config form without changing anything (???). Then the on disk template definitions (thanks to Job Config History plugin) switched from <templateVerified>false</templateVerified> to <templateVerified>true</templateVerified> (plus a few other changes, but this one seems relevant).

      Then, provisioning worked again.

      This seems like not great behavior.

        Attachments

          Activity

          Hide
          azure_devops Azure DevOps added a comment -

          Fixed in 0.4.5.1

          Show
          azure_devops Azure DevOps added a comment - Fixed in 0.4.5.1
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Chenyang Liu
          Path:
          src/main/java/com/microsoft/azure/vmagent/AzureVMAgentTemplate.java
          http://jenkins-ci.org/commit/azure-vm-agents-plugin/01288f94b7596c309bb5354b2e9435cd6d23c0d5
          Log:
          Merge pull request #52 from zackliu/hotfix

          hotfix for resolving issue of backward compatibility of storage type JENKINS-44750

          Compare: https://github.com/jenkinsci/azure-vm-agents-plugin/compare/04d7f53761cd...01288f94b759

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Chenyang Liu Path: src/main/java/com/microsoft/azure/vmagent/AzureVMAgentTemplate.java http://jenkins-ci.org/commit/azure-vm-agents-plugin/01288f94b7596c309bb5354b2e9435cd6d23c0d5 Log: Merge pull request #52 from zackliu/hotfix hotfix for resolving issue of backward compatibility of storage type JENKINS-44750 Compare: https://github.com/jenkinsci/azure-vm-agents-plugin/compare/04d7f53761cd...01288f94b759
          Hide
          erijiz Eric Jizba added a comment -

          I saw this issue as well after upgrading. I believe it's related to the 'premium storage' feature added in 0.4.5. My agents were failing to deploy with this error:

           

          AzureVMCloudVerificationTask: verify: quickstart-template could not be verified:
          The chosen storage type: null doesn't match existing account type: Standard_LRS

           

          Seems like the storage type should be defaulted to Standard_LRS when you upgrade, but it's being set to null. As Tyler mentioned, clicking save on system config fixed this (because then the storage was set to Standard_LRS).

          Show
          erijiz Eric Jizba added a comment - I saw this issue as well after upgrading. I believe it's related to the 'premium storage' feature added in 0.4.5. My agents were failing to deploy with this error:   AzureVMCloudVerificationTask: verify: quickstart-template could not be verified: The chosen storage type: null doesn't match existing account type: Standard_LRS   Seems like the storage type should be defaulted to Standard_LRS when you upgrade, but it's being set to null. As Tyler mentioned, clicking save on system config fixed this (because then the storage was set to Standard_LRS).
          Hide
          rtyler R. Tyler Croy added a comment -

          We updated to Azure VM Agents 0.4.5 and Azure Credentials 1.1 (from 1.0) yesterday.

          Show
          rtyler R. Tyler Croy added a comment - We updated to Azure VM Agents 0.4.5 and Azure Credentials 1.1 (from 1.0) yesterday.

            People

            • Assignee:
              chenkennt Ken Chen
              Reporter:
              danielbeck Daniel Beck
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: