Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44891

Migrate SCMSource's id field to a @DataBoundSetter

    Details

    • Similar Issues:

      Description

      Ease of use and form binding will do the right thing anyway with @DataBoundSetter

        Attachments

          Issue Links

            Activity

            stephenconnolly Stephen Connolly created issue -
            stephenconnolly Stephen Connolly made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            stephenconnolly Stephen Connolly made changes -
            Remote Link This issue links to "PR#41 (Web Link)" [ 17137 ]
            stephenconnolly Stephen Connolly made changes -
            Epic Link JENKINS-43426 [ 180671 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/scm/api/SCMSource.java
            src/main/java/jenkins/scm/impl/NullSCMSource.java
            src/main/java/jenkins/scm/impl/SingleSCMSource.java
            src/test/java/jenkins/scm/api/SCMRevisionActionTest.java
            src/test/java/jenkins/scm/impl/SingleSCMSourceTest.java
            src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java
            src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
            src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java
            src/test/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTraitTest.java
            src/test/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTraitTest.java
            http://jenkins-ci.org/commit/scm-api-plugin/fc5c1941cc673ebcc7c357005789d3a557b011b3
            Log:
            [FIXED JENKINS-44891] Migrate SCMSource's id field to a @DataBoundSetter

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMSource.java src/main/java/jenkins/scm/impl/NullSCMSource.java src/main/java/jenkins/scm/impl/SingleSCMSource.java src/test/java/jenkins/scm/api/SCMRevisionActionTest.java src/test/java/jenkins/scm/impl/SingleSCMSourceTest.java src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java src/test/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTraitTest.java src/test/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTraitTest.java http://jenkins-ci.org/commit/scm-api-plugin/fc5c1941cc673ebcc7c357005789d3a557b011b3 Log: [FIXED JENKINS-44891] Migrate SCMSource's id field to a @DataBoundSetter
            scm_issue_link SCM/JIRA link daemon made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java
            src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
            src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java
            http://jenkins-ci.org/commit/scm-api-plugin/9d15020884f2ab3f53525f3c7d72c864cfeb5dbc
            Log:
            JENKINS-44891 More tidy-up

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java http://jenkins-ci.org/commit/scm-api-plugin/9d15020884f2ab3f53525f3c7d72c864cfeb5dbc Log: JENKINS-44891 More tidy-up
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/scm/api/SCMSource.java
            src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
            src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java
            http://jenkins-ci.org/commit/scm-api-plugin/db4c72722f0af59f23463c3a74a399d7d720a2d3
            Log:
            JENKINS-44891 Address code review comments

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java http://jenkins-ci.org/commit/scm-api-plugin/db4c72722f0af59f23463c3a74a399d7d720a2d3 Log: JENKINS-44891 Address code review comments
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/scm/api/SCMSource.java
            src/main/java/jenkins/scm/impl/NullSCMSource.java
            src/main/java/jenkins/scm/impl/SingleSCMSource.java
            src/test/java/jenkins/scm/api/SCMRevisionActionTest.java
            src/test/java/jenkins/scm/impl/SingleSCMSourceTest.java
            src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java
            src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java
            src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
            src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java
            src/test/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTraitTest.java
            src/test/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTraitTest.java
            http://jenkins-ci.org/commit/scm-api-plugin/4cf51ff512349b25021677158bdb018c6757f487
            Log:
            Merge pull request #41 from stephenc/jenkins-44891

            [FIXED JENKINS-44891] Migrate SCMSource's id field to a @DataBoundSetter

            Compare: https://github.com/jenkinsci/scm-api-plugin/compare/d13c2f27d5f4...4cf51ff51234

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/SCMSource.java src/main/java/jenkins/scm/impl/NullSCMSource.java src/main/java/jenkins/scm/impl/SingleSCMSource.java src/test/java/jenkins/scm/api/SCMRevisionActionTest.java src/test/java/jenkins/scm/impl/SingleSCMSourceTest.java src/test/java/jenkins/scm/impl/SymbolAnnotationsTest.java src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java src/test/java/jenkins/scm/impl/mock/MockSCMSourceBuilder.java src/test/java/jenkins/scm/impl/trait/RegexSCMHeadFilterTraitTest.java src/test/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTraitTest.java http://jenkins-ci.org/commit/scm-api-plugin/4cf51ff512349b25021677158bdb018c6757f487 Log: Merge pull request #41 from stephenc/jenkins-44891 [FIXED JENKINS-44891] Migrate SCMSource's id field to a @DataBoundSetter Compare: https://github.com/jenkinsci/scm-api-plugin/compare/d13c2f27d5f4...4cf51ff51234
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/test/java/integration/BrandingTest.java
            src/test/java/integration/CategorizationTest.java
            src/test/java/integration/EnvironmentTest.java
            src/test/java/integration/EventsTest.java
            src/test/java/integration/ScmApiTest.java
            src/test/java/jenkins/branch/BranchNameContributorTest.java
            src/test/java/jenkins/branch/ParameterDefinitionBranchPropertyTest.java
            src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java
            http://jenkins-ci.org/commit/branch-api-plugin/bd430b60dbd52b7f6cf59d6e76f5faf31449aeed
            Log:
            JENKINS-43507 Pick up changes for JENKINS-44891

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/test/java/integration/BrandingTest.java src/test/java/integration/CategorizationTest.java src/test/java/integration/EnvironmentTest.java src/test/java/integration/EventsTest.java src/test/java/integration/ScmApiTest.java src/test/java/jenkins/branch/BranchNameContributorTest.java src/test/java/jenkins/branch/ParameterDefinitionBranchPropertyTest.java src/test/java/jenkins/branch/RateLimitBranchPropertyTest.java http://jenkins-ci.org/commit/branch-api-plugin/bd430b60dbd52b7f6cf59d6e76f5faf31449aeed Log: JENKINS-43507 Pick up changes for JENKINS-44891
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
            src/main/java/jenkins/plugins/git/GitSCMSource.java
            src/test/java/hudson/plugins/git/browser/GithubWebTest.java
            src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java
            src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTrivialTest.java
            http://jenkins-ci.org/commit/git-plugin/07ba4b5735c6c2a57b41b384b3a2e16569b89be3
            Log:
            JENKINS-43507 Pick up changes for JENKINS-44891

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/test/java/hudson/plugins/git/browser/GithubWebTest.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTrivialTest.java http://jenkins-ci.org/commit/git-plugin/07ba4b5735c6c2a57b41b384b3a2e16569b89be3 Log: JENKINS-43507 Pick up changes for JENKINS-44891
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
            http://jenkins-ci.org/commit/mercurial-plugin/b380c2f26987daaaf55d55353fec30e54590e12d
            Log:
            JENKINS-43507 Pick up changes for JENKINS-44891

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/b380c2f26987daaaf55d55353fec30e54590e12d Log: JENKINS-43507 Pick up changes for JENKINS-44891
            stephenconnolly Stephen Connolly made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: