Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45190

Xcode plugin 2.0.0 no longer zips dSYMs as in previous versions

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: xcode-plugin
    • Labels:
      None
    • Environment:
      Jenkins 2.32.1, master running on Linux, slave nodes are Mac Minis.
    • Similar Issues:

      Description

      As of version 2.0.0 the Xcode plug in not longer generates a ZIP file for the dSYMs. This can be attributed to a logic error introduced in commit db748380c0e90d962181ec3d4de50fec8e7336ff:

        

                      if (dSYMs != null && dSYMs.isEmpty()) { // should not test for dSYMs.isEmpty() here -- condition is never met
                          listener.getLogger().println("No dSYM file found in " + buildDirectory.absolutize().child(configuration + "-" + buildPlatform) + "!");
      
                          for (FilePath dSYM : dSYMs) {
                              returnCode = launcher.launch()
                                      .envs(envs)
                                      .stdout(listener)
                                      .pwd(buildDirectory)
                                      .cmds("ditto",
                                              "-c",
                                              "-k",
                                              "--keepParent",
                                              "-rsrc",
                                              dSYM.absolutize().getRemote(),
                                              ipaOutputPath.child(baseName + "-dSYM.zip")
                                                      .absolutize()
                                                      .getRemote())
                                      .join();
      
                              if (returnCode > 0) {
                                  listener.getLogger().println(Messages.XCodeBuilder_zipFailed(baseName));
                                  return false;
                              }
                          }
                      }
      

       

      Someone has already issued a pull request for the fix: https://github.com/jenkinsci/xcode-plugin/pull/80. Ideally this could be issued in a patch release ASAP.

        Attachments

          Activity

          Hide
          mmackowiak Marcin Maćkowiak added a comment -

          Can confirm issue is present. After update from 1.x, dSYM is no longer archived into ZIP. Temporary workaround (added as a last "Execute shell" build step):

          ditto -c -k --keepParent -rsrc App.dSYM App-dSYM.zip
          
          Show
          mmackowiak Marcin Maćkowiak added a comment - Can confirm issue is present. After update from 1.x, dSYM is no longer archived into ZIP. Temporary workaround (added as a last "Execute shell" build step): ditto -c -k --keepParent -rsrc App.dSYM App-dSYM.zip
          Hide
          jordan_ff Jordan Hesse added a comment -

          Marcin, thank you for the workaround suggestion. We'll give that a try!

          Show
          jordan_ff Jordan Hesse added a comment - Marcin, thank you for the workaround suggestion. We'll give that a try!
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kazuhide Takahashi
          Path:
          src/main/java/au/com/rayh/AppFileFilter.java
          src/main/java/au/com/rayh/DSymFileFilter.java
          src/main/java/au/com/rayh/XCodeBuilder.java
          http://jenkins-ci.org/commit/xcode-plugin/7172a7c67279adc2120958209158fe55bb4b22ac
          Log:
          Merge pull request #85 from lampietti/dSYM

          fix dSYMs generation JENKINS-45190

          Compare: https://github.com/jenkinsci/xcode-plugin/compare/3937e54f3c0a...7172a7c67279

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kazuhide Takahashi Path: src/main/java/au/com/rayh/AppFileFilter.java src/main/java/au/com/rayh/DSymFileFilter.java src/main/java/au/com/rayh/XCodeBuilder.java http://jenkins-ci.org/commit/xcode-plugin/7172a7c67279adc2120958209158fe55bb4b22ac Log: Merge pull request #85 from lampietti/dSYM fix dSYMs generation JENKINS-45190 Compare: https://github.com/jenkinsci/xcode-plugin/compare/3937e54f3c0a...7172a7c67279

            People

            • Assignee:
              Unassigned
              Reporter:
              jordan_ff Jordan Hesse
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: