Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45302

Git creation not reliably showing the activity page with discovered pipelines

    XMLWordPrintable

    Details

    • Epic Link:
    • Sprint:
      Blue Ocean 1.2-beta4, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean - Candidates
    • Similar Issues:

      Description

      To reproduce: 

       

      Use the git creation flow, let it take you to the activity page - note that it reports "no Jenkinsfiles" generic message (which is usually not correct in the first place) but then usually fails to refresh as pipelines are discovered. 

       

      Not always reproducible - but in ATH environment it is. 

       

      As discussed with Ivan Meredith

        Attachments

          Issue Links

            Activity

            Hide
            kzantow Keith Zantow added a comment -

            Michael Neale James Dumay and I discussed this a bit. I think the correct way to fix this issue is to modify creation slightly such that once it's determined that the repository connection information is correct and a job has been created, send the user to the activity page immediately (e.g. don't wait 10 seconds or for it to complete). Next, modify the activity page to be aware of and show some indication of indexing activity, with the special case that there are no jenkinsfiles discovered - maybe put a spinner in the 'no pipelines' dialog and have it say 'searching for pipelines' or something instead and take away the buttons (there should be a little bit of design work on this). Finally, when indexing completes, refresh the activity page's data and if there aren't any pipelines, send the user to the pipeline editor as it does from creation now. This should solve a handful of usability issues around creation that have to do with indexing taking a while and/or activity page not refreshing.

            Show
            kzantow Keith Zantow added a comment - Michael Neale James Dumay and I discussed this a bit. I think the correct way to fix this issue is to modify creation slightly such that once it's determined that the repository connection information is correct and a job has been created, send the user to the activity page immediately (e.g. don't wait 10 seconds or for it to complete). Next, modify the activity page to be aware of and show some indication of indexing activity, with the special case that there are no jenkinsfiles discovered - maybe put a spinner in the 'no pipelines' dialog and have it say 'searching for pipelines' or something instead and take away the buttons (there should be a little bit of design work on this). Finally, when indexing completes, refresh the activity page's data and if there aren't any pipelines, send the user to the pipeline editor as it does from creation now. This should solve a handful of usability issues around creation that have to do with indexing taking a while and/or activity page not refreshing.
            Hide
            michaelneale Michael Neale added a comment -

            Keith Zantow that sounds great to me. Vivek and I came to the same conclusion. 

             

            I think your fix that went into mater actually fixed the specific CI problem which was the trigger for this... so this may be less urgent now but that does sound like a good general solution. 

            Show
            michaelneale Michael Neale added a comment - Keith Zantow that sounds great to me. Vivek and I came to the same conclusion.    I think your fix that went into mater actually fixed the specific CI problem which was the trigger for this... so this may be less urgent now but that does sound like a good general solution. 
            Hide
            kshultz Karl Shultz added a comment -

            Testing notes:
            Keith Zantow's comment essentially writes the testing notes itself. Assuming this gets implemented as he's described:

            • In the "live" creation tests, add a verification to make sure that the 10 second delay between connection and the activity page has been removed
            • Add testing for the proposed "indication of indexing activity"
            • For tests which connect to repos with no Jenkinsfiles already in place, verify that the user is correctly sent to the editor. I don't think that'll require any actual changes to the test, because that's how that part of the flow is intended to behave today.
            Show
            kshultz Karl Shultz added a comment - Testing notes : Keith Zantow 's comment essentially writes the testing notes itself. Assuming this gets implemented as he's described: In the "live" creation tests, add a verification to make sure that the 10 second delay between connection and the activity page has been removed Add testing for the proposed "indication of indexing activity" For tests which connect to repos with no Jenkinsfiles already in place, verify that the user is correctly sent to the editor. I don't think that'll require any actual changes to the test, because that's how that part of the flow is intended to behave today.

              People

              • Assignee:
                Unassigned
                Reporter:
                michaelneale Michael Neale
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: