Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45322

Orphaned MultiBranchProject not properly disabled

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When a branch project is orphaned, setBranch(Branch.Dead) is called, which causes it to appear in strikethrough text in its view (ItemColumn/column.jelly); be deletable (BranchJobProperty.decorateACL); andĀ suppress new builds (BranchJobProperty.isBuildable).

      None of this seems to work in the case that the whole repository folder is orphaned. Based on my readings of the above implementations, it would suffice for ProjectNameProperty to include a new orphaned field (or perhaps this deserves to be a new AbstractFolderProperty<MultiBranchProject<?, ?>>); OrganizationFolder to override orphanedItems to set this field, then set Branch.Dead on all existing branch projects; all other code which might add branch projects (reindexing or event support) to also set Branch.Dead when this flag is set; and make MultiBranchProject.getACL not suppress Item.DELETE when orphaned.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/branch/OrganizationFolder.java
            http://jenkins-ci.org/commit/branch-api-plugin/7f970b83c1dc3464c3bd25dadddc4748f1a70272
            Log:
            JENKINS-45322 Avoid getFullName() computation unless required

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/OrganizationFolder.java http://jenkins-ci.org/commit/branch-api-plugin/7f970b83c1dc3464c3bd25dadddc4748f1a70272 Log: JENKINS-45322 Avoid getFullName() computation unless required
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            pom.xml
            src/main/java/jenkins/branch/MetadataActionFolderIcon.java
            src/main/java/jenkins/branch/MultiBranchProject.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            http://jenkins-ci.org/commit/branch-api-plugin/40370fdd50e9aa8601317a5549ce941d3c2912ee
            Log:
            Merge pull request #106 from stephenc/jenkins-45322

            JENKINS-45322 Prevent event processing when disabled

            Compare: https://github.com/jenkinsci/branch-api-plugin/compare/0608c0690406...40370fdd50e9

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/branch/MetadataActionFolderIcon.java src/main/java/jenkins/branch/MultiBranchProject.java src/main/java/jenkins/branch/OrganizationFolder.java http://jenkins-ci.org/commit/branch-api-plugin/40370fdd50e9aa8601317a5549ce941d3c2912ee Log: Merge pull request #106 from stephenc/jenkins-45322 JENKINS-45322 Prevent event processing when disabled Compare: https://github.com/jenkinsci/branch-api-plugin/compare/0608c0690406...40370fdd50e9
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Will be released as cloudbees-folders 6.1.0 and branch-api 2.1.0 on Monday

            Show
            stephenconnolly Stephen Connolly added a comment - Will be released as cloudbees-folders 6.1.0 and branch-api 2.1.0 on Monday
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/branch/MultiBranchProject.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            http://jenkins-ci.org/commit/branch-api-plugin/1f39f17d687274d44e63d54fc003ad9338844501
            Log:
            JENKINS-45322 Follow-up to @jglick comments

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/MultiBranchProject.java src/main/java/jenkins/branch/OrganizationFolder.java http://jenkins-ci.org/commit/branch-api-plugin/1f39f17d687274d44e63d54fc003ad9338844501 Log: JENKINS-45322 Follow-up to @jglick comments
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/branch/MultiBranchProject.java
            src/main/java/jenkins/branch/OrganizationFolder.java
            http://jenkins-ci.org/commit/branch-api-plugin/c0a695746af764b5a917891860dd4ae391fbdbc5
            Log:
            Merge pull request #107 from stephenc/jenkins-45322-follow-up

            JENKINS-45322 Follow-up to @jglick comments

            Compare: https://github.com/jenkinsci/branch-api-plugin/compare/e59651def71c...c0a695746af7

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/MultiBranchProject.java src/main/java/jenkins/branch/OrganizationFolder.java http://jenkins-ci.org/commit/branch-api-plugin/c0a695746af764b5a917891860dd4ae391fbdbc5 Log: Merge pull request #107 from stephenc/jenkins-45322-follow-up JENKINS-45322 Follow-up to @jglick comments Compare: https://github.com/jenkinsci/branch-api-plugin/compare/e59651def71c...c0a695746af7

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: