Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4543

Manually uploaded plugins are incorrectly unpacked

    Details

    • Similar Issues:

      Description

      If you upload foo-1.0.hpi, then later upload foo-1.1.hpi, work/plugins contains

      foo-1.0
      foo-1.0.hpi
      foo-1.1
      foo-1.1.hpi

      and Hudson thinks both foo 1.0 and foo 1.1 are installed at the same time,
      causing mayhem.

      Plugins should be unpacked into a directory based on their extension-name or
      short-name or something like this, so that manually uploading a new version of
      the plugin will remove the previous version.

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            Hide
            jglick Jesse Glick added a comment -

            Still broken. Makes it impossible (so far as I can tell) to upload an update of a plugin you built from sources to a running server without waiting for it to be published on the update site.

            Show
            jglick Jesse Glick added a comment - Still broken. Makes it impossible (so far as I can tell) to upload an update of a plugin you built from sources to a running server without waiting for it to be published on the update site.
            evernat evernat made changes -
            Field Original Value New Value
            Priority Major [ 3 ] Critical [ 2 ]
            Hide
            evernat evernat added a comment - - edited

            Changed the priority from Major to Critical because this prevents making hpi files available as downloads when including a version number.
            For example, suggesting the manual install of some beta or RC hpi file will certainly cause problems with multiple versions of the plugin installed.

            Show
            evernat evernat added a comment - - edited Changed the priority from Major to Critical because this prevents making hpi files available as downloads when including a version number. For example, suggesting the manual install of some beta or RC hpi file will certainly cause problems with multiple versions of the plugin installed.
            evernat evernat made changes -
            Link This issue is related to JENKINS-16306 [ JENKINS-16306 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/java/hudson/PluginManager.java
            http://jenkins-ci.org/commit/jenkins/f1669601e4bd607ffa8a809e109f1ad0c79244b1
            Log:
            [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest.

            Compare: https://github.com/jenkinsci/jenkins/compare/06e459fffebf...f1669601e4bd

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/PluginManager.java http://jenkins-ci.org/commit/jenkins/f1669601e4bd607ffa8a809e109f1ad0c79244b1 Log: [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest. Compare: https://github.com/jenkinsci/jenkins/compare/06e459fffebf...f1669601e4bd
            scm_issue_link SCM/JIRA link daemon made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2489
            [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest. (Revision f1669601e4bd607ffa8a809e109f1ad0c79244b1)

            Result = SUCCESS
            kohsuke : f1669601e4bd607ffa8a809e109f1ad0c79244b1
            Files :

            • core/src/main/java/hudson/PluginManager.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2489 [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest. (Revision f1669601e4bd607ffa8a809e109f1ad0c79244b1) Result = SUCCESS kohsuke : f1669601e4bd607ffa8a809e109f1ad0c79244b1 Files : core/src/main/java/hudson/PluginManager.java
            jglick Jesse Glick made changes -
            Labels lts-candidate
            Hide
            jglick Jesse Glick added a comment -

            Workaround is to always ensure when using the Upload button that you are selecting a file named pluginShortName.hpi.

            Show
            jglick Jesse Glick added a comment - Workaround is to always ensure when using the Upload button that you are selecting a file named pluginShortName.hpi .
            Hide
            danielbeck Daniel Beck added a comment -

            Shouldn't this be fixed before loading plugins as well, to prevent manual edits of the plugins directory from causing similar issues?

            Show
            danielbeck Daniel Beck added a comment - Shouldn't this be fixed before loading plugins as well, to prevent manual edits of the plugins directory from causing similar issues?
            Hide
            jglick Jesse Glick added a comment -

            @danielbeck: that would be a reasonable RFE, though much lower priority I think since if you are manually rearranging the plugins directory it is assumed you know what you are doing.

            Show
            jglick Jesse Glick added a comment - @danielbeck: that would be a reasonable RFE, though much lower priority I think since if you are manually rearranging the plugins directory it is assumed you know what you are doing.
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate lts-1.509.3-fixed
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-16652 [ JENKINS-16652 ]
            olivergondza Oliver Gondža made changes -
            Labels lts-1.509.3-fixed 1.509.3-fixed
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/51765382e861355037600d9fc63d4aadedf5d7b1
            Log:
            JENKINS-4543 Noting retroactively.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html http://jenkins-ci.org/commit/jenkins/51765382e861355037600d9fc63d4aadedf5d7b1 Log: JENKINS-4543 Noting retroactively.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3104
            JENKINS-4543 Noting retroactively. (Revision 51765382e861355037600d9fc63d4aadedf5d7b1)

            Result = UNSTABLE
            Jesse Glick : 51765382e861355037600d9fc63d4aadedf5d7b1
            Files :

            • changelog.html
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3104 JENKINS-4543 Noting retroactively. (Revision 51765382e861355037600d9fc63d4aadedf5d7b1) Result = UNSTABLE Jesse Glick : 51765382e861355037600d9fc63d4aadedf5d7b1 Files : changelog.html
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 134616 ] JNJira + In-Review [ 186841 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                jglick Jesse Glick
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: