Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46162

Support pipeline linting

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      At the moment it does support AbstractProjects rather than Jobs:

      Let's support pipeline job types

        Attachments

          Activity

          v2v Victor Martinez created issue -
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Victor Martinez
          Path:
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxChecker.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java
          http://jenkins-ci.org/commit/jenkinslint-plugin/d078eea270e307f693d247a6a53b2cad05768a40
          Log:
          JENKINS-46162 Support Pipeline project to be linted

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/d078eea270e307f693d247a6a53b2cad05768a40 Log: JENKINS-46162 Support Pipeline project to be linted
          v2v Victor Martinez made changes -
          Field Original Value New Value
          Labels 0.12.0
          v2v Victor Martinez made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          v2v Victor Martinez added a comment -

          It will be releases in the upcoming release 0.12.0, including the GroovySandbox checker

          Show
          v2v Victor Martinez added a comment - It will be releases in the upcoming release 0.12.0, including the GroovySandbox checker
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Victor Martinez
          Path:
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxChecker.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java
          http://jenkins-ci.org/commit/jenkinslint-plugin/afb3f0086de83417bf912fe43f5e076dd94ae480
          Log:
          JENKINS-46162 Support Pipeline project to be linted

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/afb3f0086de83417bf912fe43f5e076dd94ae480 Log: JENKINS-46162 Support Pipeline project to be linted
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Victor Martinez
          Path:
          pom.xml
          src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/JobLintAction.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/LintActionFactory.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintActionFactory.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxChecker.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerChecker.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionChecker.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutChecker.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java
          src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractAction.java
          src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration/config.jelly
          src/main/resources/org/jenkins/ci/plugins/jenkinslint/check/Messages.properties
          src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java
          src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java
          http://jenkins-ci.org/commit/jenkinslint-plugin/2b5910a98e8c5c3790eccf6b0b1638b9dd0e3ee2
          Log:
          JENKINS-46162 Support workflow/pipeline linting (#30)

          • Supporting pipeline jobs, fixed some bugs, bumped minimal version to allow the usage of the pipelines
          • Supporting GroovySandbox checker only in Jenkinsfiles, aka WorkflowJobs
          • Added TestCases for the Pipeline jobs
          • Enable System Groovy detection
          • Missing testcases
          • Enabling JenkinsLint action for pipelines/workflows

          Change-Id: Ideaa90900b836d2a2f115fc7eefa7c2ab5533197

          • Support pipeline timer trigger check

          Change-Id: I857d85210a0f95c22226798320508132cecaf9fa

          • Fixed TimeoutChecker for pipeline (some false positives)

          Change-Id: I2f9cdd04a73702ffa16cb7050123dc6a63fb759b

          • Support pipeline PollingSCMtrigger check

          Change-Id: I7ef1a3228096c2e43713495629e044bbb141d898

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Victor Martinez Path: pom.xml src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration.java src/main/java/org/jenkins/ci/plugins/jenkinslint/JobLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/LintActionFactory.java src/main/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction.java src/main/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintActionFactory.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractAction.java src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration/config.jelly src/main/resources/org/jenkins/ci/plugins/jenkinslint/check/Messages.properties src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySandboxCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java http://jenkins-ci.org/commit/jenkinslint-plugin/2b5910a98e8c5c3790eccf6b0b1638b9dd0e3ee2 Log: JENKINS-46162 Support workflow/pipeline linting (#30) Supporting pipeline jobs, fixed some bugs, bumped minimal version to allow the usage of the pipelines Supporting GroovySandbox checker only in Jenkinsfiles, aka WorkflowJobs JENKINS-46162 Support Pipeline project to be linted Added TestCases for the Pipeline jobs Enable System Groovy detection Missing testcases Enabling JenkinsLint action for pipelines/workflows Change-Id: Ideaa90900b836d2a2f115fc7eefa7c2ab5533197 Support pipeline timer trigger check Change-Id: I857d85210a0f95c22226798320508132cecaf9fa Fixed TimeoutChecker for pipeline (some false positives) Change-Id: I2f9cdd04a73702ffa16cb7050123dc6a63fb759b Support pipeline PollingSCMtrigger check Change-Id: I7ef1a3228096c2e43713495629e044bbb141d898
          v2v Victor Martinez made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          v2v Victor Martinez made changes -
          Status In Review [ 10005 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          v2v Victor Martinez made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              v2v Victor Martinez
              Reporter:
              v2v Victor Martinez
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: