Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4640

hudson.scm.SCM getModuleRoot should take build as a second param

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      As described in this thread:
      http://www.nabble.com/Suggestion-for-SCM.getModuleRoot-(via-clearcase-problem)-td25849692.html

      The result of getModuleRoot can be build dependent - we should pass the build of
      interest to the SCM object for this method.

      The current implementation results in a bug that manifests in interaction
      between the clearcase SCM and the m2-extra-steps plugin.

        Attachments

          Issue Links

            Activity

            Hide
            nparry Nathan Parry added a comment -

            Created an attachment (id=953)
            Patch to implement the enhancement as described.

            Show
            nparry Nathan Parry added a comment - Created an attachment (id=953) Patch to implement the enhancement as described.
            Hide
            nparry Nathan Parry added a comment -

            The attached patch adds the new methods - they call the existing methods to maintain backwards
            compatibility with existing SCMs until they are updated. It also updates the various places in core where
            the old methods were used to instead use the new ones.

            Show
            nparry Nathan Parry added a comment - The attached patch adds the new methods - they call the existing methods to maintain backwards compatibility with existing SCMs until they are updated. It also updates the various places in core where the old methods were used to instead use the new ones.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in hudson
            User: : kohsuke
            Path:
            trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java
            trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java
            trunk/hudson/main/core/src/main/java/hudson/scm/SCM.java
            http://jenkins-ci.org/commit/36010
            Log:
            [FIXED JENKINS-4640] applied the patch with some improvements in the backward compatibility handling.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java trunk/hudson/main/core/src/main/java/hudson/scm/SCM.java http://jenkins-ci.org/commit/36010 Log: [FIXED JENKINS-4640] applied the patch with some improvements in the backward compatibility handling.
            Hide
            dogfood dogfood added a comment -

            Integrated in hudson_main_trunk #338
            [FIXED JENKINS-4640] applied the patch with some improvements in the backward compatibility handling.

            kohsuke :
            Files :

            • /trunk/hudson/main/core/src/main/java/hudson/scm/SCM.java
            • /trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java
            • /trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java
            Show
            dogfood dogfood added a comment - Integrated in hudson_main_trunk #338 [FIXED JENKINS-4640] applied the patch with some improvements in the backward compatibility handling. kohsuke : Files : /trunk/hudson/main/core/src/main/java/hudson/scm/SCM.java /trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java /trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java

              People

              • Assignee:
                Unassigned
                Reporter:
                nparry Nathan Parry
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: