Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46657

blue ocean currentBuild.displayName should show in RUN column in place of number

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      Blue Ocean 1.3

      Description

      tldr: Blue ocean should use the displayName if one is there, instead of build number (like the classic screen shot). The URIs are unchanged, just what is displayed in the column. 

       

      ------ original: ------

       

      -JENKINS-39850- claims that currentBuild.displayName is honored in blue ocean as of now, but it is not consistent.  The following script:

       

      node {
        stage('start') {
          currentBuild.displayName = "foo.$BUILD_NUMBER"
          currentBuild.description = "foo.$BUILD_NUMBER - desc"
          echo 'Hello World'
        }
      }
      

      Produces the attached screenshots on our system.

       

      Expected Behavior:

      The activity screen should show displayName in the RUN column.  JENKINS-39850 shows screenshots that show that to be the case.

        Attachments

          Issue Links

            Activity

            Hide
            michaelneale Michael Neale added a comment -

            Adam Krapfl can you clarify what you expect - ie I think it is using the description over displayName when there is one. Is this not expected when there are both? Need some clarity of expected behavior if possible. 

            Show
            michaelneale Michael Neale added a comment - Adam Krapfl can you clarify what you expect - ie I think it is using the description over displayName when there is one. Is this not expected when there are both? Need some clarity of expected behavior if possible. 
            Hide
            akrapfl Adam Krapfl added a comment -

            Expected behavior is that the activity screen should show displayName in the RUN column.  JENKINS-39850 shows screenshots that show that to be the case.

            I will update the issue description as well.

            Show
            akrapfl Adam Krapfl added a comment - Expected behavior is that the  activity screen should show  displayName in the  RUN column.   JENKINS-39850 shows screenshots that show that to be the case. I will update the issue description as well.
            Hide
            michaelneale Michael Neale added a comment - - edited

            Adam Krapfl and the description (longer form) should be used in the "detail screen" if I understand correctly (and thanks for updating). 

             

            edit: right - it uses the message column for that... ok starting to make sense 

            Show
            michaelneale Michael Neale added a comment - - edited Adam Krapfl and the description (longer form) should be used in the "detail screen" if I understand correctly (and thanks for updating).    edit: right - it uses the message column for that... ok starting to make sense 
            Hide
            michaelneale Michael Neale added a comment -

            Nicolae Pascu this might be a nice one to put on the backlog. I think the data should already be there, just should be picking the right thing to show instead of the run number in activity screen/listings of runs. May need to sync up with cliff/keith if it isn't quite clear if the data is there (in which case, just make it unassigned, someone can pick it up). This would make it nice and consistent with classic. The message field is already correctly using the description. 

             

            Show
            michaelneale Michael Neale added a comment - Nicolae Pascu this might be a nice one to put on the backlog. I think the data should already be there, just should be picking the right thing to show instead of the run number in activity screen/listings of runs. May need to sync up with cliff/keith if it isn't quite clear if the data is there (in which case, just make it unassigned, someone can pick it up). This would make it nice and consistent with classic. The message field is already correctly using the description.   
            Show
            michaelneale Michael Neale added a comment - fix: https://github.com/jenkinsci/blueocean-plugin/pull/1438  
            Hide
            jamesdumay James Dumay added a comment -

            Included in Blue Ocean 1.3

            Show
            jamesdumay James Dumay added a comment - Included in Blue Ocean 1.3
            Hide
            reinholdfuereder Reinhold Füreder added a comment -

            Sorry, but after just updating to Blue Ocean 1.3 I claim it still shows the build number in the pipeline activity view!? Is the fix really included?

            Show
            reinholdfuereder Reinhold Füreder added a comment - Sorry, but after just updating to Blue Ocean 1.3 I claim it still shows the build number in the pipeline activity view!? Is the fix really included?
            Hide
            michaelneale Michael Neale added a comment -

            Reinhold Füreder this one missed the 1.3 branch window by one day: https://github.com/jenkinsci/blueocean-plugin/pull/1438

            (it is on master) - it wasn't in release notes. 

            I think we could cherry pick that commit to 1.3 branch and do a 1.3.1 as its a pretty small change, sorry about that

            Show
            michaelneale Michael Neale added a comment - Reinhold Füreder this one missed the 1.3 branch window by one day: https://github.com/jenkinsci/blueocean-plugin/pull/1438 (it is on master) - it wasn't in release notes.  I think we could cherry pick that commit to 1.3 branch and do a 1.3.1 as its a pretty small change, sorry about that
            Hide
            michaelneale Michael Neale added a comment -

            Reinhold Füreder https://github.com/jenkinsci/blueocean-plugin/pull/1485 - will see how that goes. Maybe we will do a 1.3.1 tomorrow, sorry again. 

            This was a small change. 

            Show
            michaelneale Michael Neale added a comment - Reinhold Füreder https://github.com/jenkinsci/blueocean-plugin/pull/1485  - will see how that goes. Maybe we will do a 1.3.1 tomorrow, sorry again.  This was a small change. 
            Hide
            reinholdfuereder Reinhold Füreder added a comment -

            Thanks for the fast clarification and sorry for my confusion: when I had looked release notes were not there, so I looked at JIRA and presumably misinterpreted versioning/releasing, what is included in which release or sprint or version, etc; and frankly I have this problem/confusion for other Jenkins plugins too (that do not list release notes on the plugin page)...

            Show
            reinholdfuereder Reinhold Füreder added a comment - Thanks for the fast clarification and sorry for my confusion: when I had looked release notes were not there, so I looked at JIRA and presumably misinterpreted versioning/releasing, what is included in which release or sprint or version, etc; and frankly I have this problem/confusion for other Jenkins plugins too (that do not list release notes on the plugin page)...
            Hide
            michaelneale Michael Neale added a comment -

            Reinhold Füreder no worries at all - I was confused as well as I assumed it made it in. 

            The way JIRA is used for this project is that it shares it with many other components, so it is hard to set a "release" field so it is clear when available. I always go off the github commit history for the release/X branch as the source of truth. 

            If you nag me in a few days we can make sure we cut a release

            Show
            michaelneale Michael Neale added a comment - Reinhold Füreder no worries at all - I was confused as well as I assumed it made it in.  The way JIRA is used for this project is that it shares it with many other components, so it is hard to set a "release" field so it is clear when available. I always go off the github commit history for the release/X branch as the source of truth.  If you nag me in a few days we can make sure we cut a release
            Hide
            akrapfl Adam Krapfl added a comment -

            Michael Neale Is it still possible to do a 1.3.1 release, or is one getting close?  You asked me to nag.   . I don't see a 1.3.1 available, unless I'm missing something.

            Show
            akrapfl Adam Krapfl added a comment - Michael Neale Is it still possible to do a 1.3.1 release, or is one getting close?  You asked me to nag.   . I don't see a 1.3.1 available, unless I'm missing something.
            Hide
            michaelneale Michael Neale added a comment -

            Adam Krapfl ok - may be one today https://github.com/jenkinsci/blueocean-plugin/pull/1519 will hopefully also go in. 

            TBH I am slightly concerned as to what people will do with currentBuild.displayName - so if you do see a 1.3.1 - please do give it a good flogging and open a ticket/ @ mention me if anything smells funny. 

            Show
            michaelneale Michael Neale added a comment - Adam Krapfl ok - may be one today https://github.com/jenkinsci/blueocean-plugin/pull/1519  will hopefully also go in.  TBH I am slightly concerned as to what people will do with currentBuild.displayName - so if you do see a 1.3.1 - please do give it a good flogging and open a ticket/ @ mention me if anything smells funny. 
            Hide
            akrapfl Adam Krapfl added a comment -

            Fair enough.  I am sure it will be abused at some point.  Personally, I intend to put semver compliant version numbers in there.  Something like `2.0.${BUILD_NUM}`.  Possible variations would have `2.0.${BUILD_NUM}-beta`.  The last segment is where i'm concerned it could be lengthy at times.

            Thank you for getting it out there for us!

            Show
            akrapfl Adam Krapfl added a comment - Fair enough.  I am sure it will be abused at some point.  Personally, I intend to put semver compliant version numbers in there.  Something like `2.0.${BUILD_NUM}`.  Possible variations would have `2.0.${BUILD_NUM}-beta`.  The last segment is where i'm concerned it could be lengthy at times. Thank you for getting it out there for us!
            Hide
            ironchamp Alan Champion added a comment -

            In our system the MESSAGE column "alternative" is not a description, but simply shows something like "Started by <user>/upstream job" or "Replayed #?".

            So, the expectation is that RUN column shows the full currentBuild.displayName buildName, whatever width it needs to be.

            Show
            ironchamp Alan Champion added a comment - In our system the MESSAGE column "alternative" is not a description, but simply shows something like "Started by <user>/upstream job" or "Replayed #?". So, the expectation is that RUN column shows the full currentBuild.displayName buildName, whatever width it needs to be.

              People

              • Assignee:
                nicu Nicolae Pascu
                Reporter:
                akrapfl Adam Krapfl
              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: