Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47073

Multibranch jobs with a different display name do not work

    XMLWordPrintable

    Details

    • Sprint:
      Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 2
    • Similar Issues:

      Description

      We use a different workflow branch factory than the default for GitHub multibranch pipeline jobs, and the branch factory sets a display name that is sometimes different than the actual branch name. When using this plugin and using getRunUrl, it uses the display name of the job instead of the actual job name, which results in non-rendering pages, etc in the UI.

      I'm not sure of the proper fix here, as this may be valid for non-GH multibranch pipeline jobs. Looking at how the classic URL provider plugin handles this (following it down the chain from the plugin itself), it appears that this uses item group names, etc to get this right.

      It's also possible that using getName instead of getDisplayName will just work in all cases, not sure.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ivan Meredith
            Path:
            src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java
            src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImplTest.java
            http://jenkins-ci.org/commit/blueocean-display-url-plugin/66008c26273161e9d85f3fe1f2a018e7c591507c
            Log:
            JENKINS-47073: Use getName instead of getDisplayName to build urls

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Meredith Path: src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImplTest.java http://jenkins-ci.org/commit/blueocean-display-url-plugin/66008c26273161e9d85f3fe1f2a018e7c591507c Log: JENKINS-47073 : Use getName instead of getDisplayName to build urls
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ivan Meredith
            Path:
            Jenkinsfile
            src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java
            src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImplTest.java
            http://jenkins-ci.org/commit/blueocean-display-url-plugin/dcb76e26147a0caf01f0288be94d6ea5c2a0d2b2
            Log:
            Jenkins 47073 dont use displayname (#11)

            • JENKINS-47073: Use getName instead of getDisplayName to build urls
            • Add test back
            • Rebuild
            • Updated jenkinsfile
            • build on linux
            • jenkinsfile from Blueocean
            • fix net
            • Git stuff
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Meredith Path: Jenkinsfile src/main/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImpl.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImplTest.java http://jenkins-ci.org/commit/blueocean-display-url-plugin/dcb76e26147a0caf01f0288be94d6ea5c2a0d2b2 Log: Jenkins 47073 dont use displayname (#11) JENKINS-47073 : Use getName instead of getDisplayName to build urls Add test back Rebuild Updated jenkinsfile build on linux jenkinsfile from Blueocean fix net Git stuff
            Hide
            kshultz Karl Shultz added a comment -
            Show
            kshultz Karl Shultz added a comment - Testing Notes: An automated test for this is part of the PR .
            Hide
            jamesdumay James Dumay added a comment -

            Ivan Meredith did this make it into master?

            Show
            jamesdumay James Dumay added a comment - Ivan Meredith did this make it into master?
            Hide
            bksaville Brian Saville added a comment - - edited

            It looks like this is close. We're waiting pretty anxiously on this issue as it basically makes the UI unusable for many due to the heavy usage of display names. Any idea when this will be released
            James Dumay? Thanks for all you do!

            Show
            bksaville Brian Saville added a comment - - edited It looks like this is close. We're waiting pretty anxiously on this issue as it basically makes the UI unusable for many due to the heavy usage of display names. Any idea when this will be released James Dumay ? Thanks for all you do!
            Hide
            jamesdumay James Dumay added a comment -

            This was released in Blue Ocean display URL 2.1.1

            Show
            jamesdumay James Dumay added a comment - This was released in Blue Ocean display URL 2.1.1
            Hide
            bksaville Brian Saville added a comment -

            James Dumay, thanks!

            Show
            bksaville Brian Saville added a comment - James Dumay , thanks!

              People

              • Assignee:
                imeredith Ivan Meredith
                Reporter:
                bksaville Brian Saville
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: