-
Type:
Bug
-
Status: Resolved (View Workflow)
-
Priority:
Blocker
-
Resolution: Fixed
-
Component/s: pipeline-model-definition-plugin
-
Labels:None
-
Environment:pipeline-model-definition-plugin v1.2
-
Similar Issues:
Version 1.2 of pipeline-model-definition-plugin changes the behavior of docker images. `docker pull` is now performed for docker images specified in `agent`. Previously this was not performed.
This change affects use cases where the docker image only exists locally. It will obviously fail if `docker pull` is called.
The change was introduced in https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/182
The simple workaround is to patch the plugin to revert this change, but it would be nice to avoid that.
Hopefully this could be reverted to old behavior or/and an option added for configuration.
- links to
Well, that was dumb on my part. Will get a fix up today or tomorrow. Sorry!
Hi Andrew Bayer,
Any news on this regression?
Code changed in jenkins
User: Segev Finer
Path:
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineScript.groovy
http://jenkins-ci.org/commit/pipeline-model-definition-plugin/5c4946495236afe8c778b9662ffd754923a728e5
Log:
[FIXED JENKINS-47106] Support alwaysPull in the top level agent section
Code changed in jenkins
User: Andrew Bayer
Path:
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/agent/impl/DockerPipelineScript.groovy
http://jenkins-ci.org/commit/pipeline-model-definition-plugin/fa8ed8bb0861220ff36b730656dc12701ba86ffd
Log:
Merge pull request #254 from segevfiner/jenkins-47106-top-level-agent-local-image
[FIXED JENKINS-47106] Support alwaysPull in the top level agent section
Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/f5deef1255d0...fa8ed8bb0861
I met same issue as Ryan Fitzsimon.
When I set 'alwaysPull false' within stage block, it works fine as expect to use local image. However, if the same config is set within the top 'pipeline/agent' block, it still always do 'docker pull' and the local image does not work.