Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47416

Views deleted by upgrade from cloudbees-folders 6.1.2 to 6.2.0

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Labels:
    • Environment:
      Docker image running Jenkins 2.73.2
      cloudbees-folder-plugin 6.2.0
      upgrading folders from prior cloudbees-folder-plugin
    • Similar Issues:

      Description

      When I installed cloudbees-folder-plugin 6.2.0, the views defined in several of my folders were deleted.

      An administrative monitor appeared warning about unreadable data. The message was:

      ConversionException: Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
      no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] :
      Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
      no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
      ---- Debugging information ----
      message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
      cause-exception : com.thoughtworks.xstream.converters.reflection.ObjectAccessException
      cause-message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
      class : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder required-type : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder
      converter-type : hudson.util.RobustReflectionConverter path
      : /com.cloudbees.hudson.plugins.folder.Folder/folderViews line number : 157 -------------------------------
      

      To duplicate the problem:

      1. Clone, build, and run the docker instance
          $ git lfs clone https://github.com/MarkEWaite/docker-lfs JENKINS-47416
          $ cd JENKINS-47416
          $ git lfs fetch origin JENKINS-47416
          $ git checkout -b lts-with-plugins JENKINS-47416
          $ docker build -t jenkins:JENKINS-47416 .
          $ docker run -i --rm --publish 8080:8080 jenkins:JENKINS-47416
        
      2. Click "Manage Jenkins"
      3. Clck the "Manage" button to the right of "You have data stored in an older format and/or unreadable data" (opens http://localhost:8080/administrativeMonitor/OldData/manage )

      One of the folder config.xml files is available in the docker image

      Conversion exception is thrown even if I update the folder definition to 6.1.2 format before upgrading the cloudbees-folders plugin.

        Attachments

          Issue Links

            Activity

            markewaite Mark Waite created issue -
            markewaite Mark Waite made changes -
            Field Original Value New Value
            Description When I installed cloudbees-folder-plugin 6.2.0, the views defined in several of my folders were deleted.

            An administrative monitor appeared warning about unreadable data. The message was:

            {noformat}
            ConversionException: Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] :
            Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            ---- Debugging information ----
            message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            cause-exception : com.thoughtworks.xstream.converters.reflection.ObjectAccessException
            cause-message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            class : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder required-type : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder
            converter-type : hudson.util.RobustReflectionConverter path
            : /com.cloudbees.hudson.plugins.folder.Folder/folderViews line number : 157 -------------------------------
            {noformat}

            To duplicate the problem:

            # Clone, build, and run the docker instance
            {code}
              $ git lfs clone https://github.com/MarkEWaite/docker-lfs JENKINS-xxx
              $ cd JENKINS-xxx
              $ git lfs fetch origin public/JENKINS-xxx
              $ git checkout -b lts-with-plugins JENKINS-xxx
              $ docker build -t jenkins:JENKINS-xxx .
              $ docker run -i --rm --publish 8080:8080 jenkins:JENKINS-xxx
            {code}
            # Click "Manage Jenkins"
            # Clck the "Manage" button to the left of "You have data stored in an older format and/or unreadable data"
            When I installed cloudbees-folder-plugin 6.2.0, the views defined in several of my folders were deleted.

            An administrative monitor appeared warning about unreadable data. The message was:

            {noformat}
            ConversionException: Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] :
            Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            ---- Debugging information ----
            message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            cause-exception : com.thoughtworks.xstream.converters.reflection.ObjectAccessException
            cause-message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            class : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder required-type : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder
            converter-type : hudson.util.RobustReflectionConverter path
            : /com.cloudbees.hudson.plugins.folder.Folder/folderViews line number : 157 -------------------------------
            {noformat}

            To duplicate the problem:

            # Clone, build, and run the docker instance
            {code}
              $ git lfs clone https://github.com/MarkEWaite/docker-lfs JENKINS-47416
              $ cd JENKINS-47416
              $ git lfs fetch origin JENKINS-47416
              $ git checkout -b lts-with-plugins JENKINS-47416
              $ docker build -t jenkins:JENKINS-47416 .
              $ docker run -i --rm --publish 8080:8080 jenkins:JENKINS-47416
            {code}
            # Click "Manage Jenkins"
            # Clck the "Manage" button to the left of "You have data stored in an older format and/or unreadable data" (opens http://localhost:8080/administrativeMonitor/OldData/manage )

            One of the folder config.xml files is available in the [docker image|https://github.com/MarkEWaite/docker-lfs/blob/JENKINS-47416/ref/jobs/Git-Client-Folder/config.xml])
            markewaite Mark Waite made changes -
            Description When I installed cloudbees-folder-plugin 6.2.0, the views defined in several of my folders were deleted.

            An administrative monitor appeared warning about unreadable data. The message was:

            {noformat}
            ConversionException: Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] :
            Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            ---- Debugging information ----
            message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            cause-exception : com.thoughtworks.xstream.converters.reflection.ObjectAccessException
            cause-message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            class : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder required-type : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder
            converter-type : hudson.util.RobustReflectionConverter path
            : /com.cloudbees.hudson.plugins.folder.Folder/folderViews line number : 157 -------------------------------
            {noformat}

            To duplicate the problem:

            # Clone, build, and run the docker instance
            {code}
              $ git lfs clone https://github.com/MarkEWaite/docker-lfs JENKINS-47416
              $ cd JENKINS-47416
              $ git lfs fetch origin JENKINS-47416
              $ git checkout -b lts-with-plugins JENKINS-47416
              $ docker build -t jenkins:JENKINS-47416 .
              $ docker run -i --rm --publish 8080:8080 jenkins:JENKINS-47416
            {code}
            # Click "Manage Jenkins"
            # Clck the "Manage" button to the left of "You have data stored in an older format and/or unreadable data" (opens http://localhost:8080/administrativeMonitor/OldData/manage )

            One of the folder config.xml files is available in the [docker image|https://github.com/MarkEWaite/docker-lfs/blob/JENKINS-47416/ref/jobs/Git-Client-Folder/config.xml])
            When I installed cloudbees-folder-plugin 6.2.0, the views defined in several of my folders were deleted.

            An administrative monitor appeared warning about unreadable data. The message was:

            {noformat}
            ConversionException: Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] :
            Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            ---- Debugging information ----
            message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            cause-exception : com.thoughtworks.xstream.converters.reflection.ObjectAccessException
            cause-message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            class : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder required-type : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder
            converter-type : hudson.util.RobustReflectionConverter path
            : /com.cloudbees.hudson.plugins.folder.Folder/folderViews line number : 157 -------------------------------
            {noformat}

            To duplicate the problem:

            # Clone, build, and run the docker instance
            {code}
              $ git lfs clone https://github.com/MarkEWaite/docker-lfs JENKINS-47416
              $ cd JENKINS-47416
              $ git lfs fetch origin JENKINS-47416
              $ git checkout -b lts-with-plugins JENKINS-47416
              $ docker build -t jenkins:JENKINS-47416 .
              $ docker run -i --rm --publish 8080:8080 jenkins:JENKINS-47416
            {code}
            # Click "Manage Jenkins"
            # Clck the "Manage" button to the left of "You have data stored in an older format and/or unreadable data" (opens http://localhost:8080/administrativeMonitor/OldData/manage )

            One of the folder config.xml files is available in the [docker image|https://github.com/MarkEWaite/docker-lfs/blob/JENKINS-47416/ref/jobs/Git-Client-Folder/config.xml]
            markewaite Mark Waite made changes -
            Description When I installed cloudbees-folder-plugin 6.2.0, the views defined in several of my folders were deleted.

            An administrative monitor appeared warning about unreadable data. The message was:

            {noformat}
            ConversionException: Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] :
            Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            ---- Debugging information ----
            message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            cause-exception : com.thoughtworks.xstream.converters.reflection.ObjectAccessException
            cause-message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            class : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder required-type : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder
            converter-type : hudson.util.RobustReflectionConverter path
            : /com.cloudbees.hudson.plugins.folder.Folder/folderViews line number : 157 -------------------------------
            {noformat}

            To duplicate the problem:

            # Clone, build, and run the docker instance
            {code}
              $ git lfs clone https://github.com/MarkEWaite/docker-lfs JENKINS-47416
              $ cd JENKINS-47416
              $ git lfs fetch origin JENKINS-47416
              $ git checkout -b lts-with-plugins JENKINS-47416
              $ docker build -t jenkins:JENKINS-47416 .
              $ docker run -i --rm --publish 8080:8080 jenkins:JENKINS-47416
            {code}
            # Click "Manage Jenkins"
            # Clck the "Manage" button to the left of "You have data stored in an older format and/or unreadable data" (opens http://localhost:8080/administrativeMonitor/OldData/manage )

            One of the folder config.xml files is available in the [docker image|https://github.com/MarkEWaite/docker-lfs/blob/JENKINS-47416/ref/jobs/Git-Client-Folder/config.xml]
            When I installed cloudbees-folder-plugin 6.2.0, the views defined in several of my folders were deleted.

            An administrative monitor appeared warning about unreadable data. The message was:

            {noformat}
            ConversionException: Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] :
            Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            ---- Debugging information ----
            message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            cause-exception : com.thoughtworks.xstream.converters.reflection.ObjectAccessException
            cause-message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            class : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder required-type : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder
            converter-type : hudson.util.RobustReflectionConverter path
            : /com.cloudbees.hudson.plugins.folder.Folder/folderViews line number : 157 -------------------------------
            {noformat}

            To duplicate the problem:

            # Clone, build, and run the docker instance
            {code}
              $ git lfs clone https://github.com/MarkEWaite/docker-lfs JENKINS-47416
              $ cd JENKINS-47416
              $ git lfs fetch origin JENKINS-47416
              $ git checkout -b lts-with-plugins JENKINS-47416
              $ docker build -t jenkins:JENKINS-47416 .
              $ docker run -i --rm --publish 8080:8080 jenkins:JENKINS-47416
            {code}
            # Click "Manage Jenkins"
            # Clck the "Manage" button to the right of "You have data stored in an older format and/or unreadable data" (opens http://localhost:8080/administrativeMonitor/OldData/manage )

            One of the folder config.xml files is available in the [docker image|https://github.com/MarkEWaite/docker-lfs/blob/JENKINS-47416/ref/jobs/Git-Client-Folder/config.xml]
            markewaite Mark Waite made changes -
            Description When I installed cloudbees-folder-plugin 6.2.0, the views defined in several of my folders were deleted.

            An administrative monitor appeared warning about unreadable data. The message was:

            {noformat}
            ConversionException: Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] :
            Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            ---- Debugging information ----
            message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            cause-exception : com.thoughtworks.xstream.converters.reflection.ObjectAccessException
            cause-message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            class : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder required-type : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder
            converter-type : hudson.util.RobustReflectionConverter path
            : /com.cloudbees.hudson.plugins.folder.Folder/folderViews line number : 157 -------------------------------
            {noformat}

            To duplicate the problem:

            # Clone, build, and run the docker instance
            {code}
              $ git lfs clone https://github.com/MarkEWaite/docker-lfs JENKINS-47416
              $ cd JENKINS-47416
              $ git lfs fetch origin JENKINS-47416
              $ git checkout -b lts-with-plugins JENKINS-47416
              $ docker build -t jenkins:JENKINS-47416 .
              $ docker run -i --rm --publish 8080:8080 jenkins:JENKINS-47416
            {code}
            # Click "Manage Jenkins"
            # Clck the "Manage" button to the right of "You have data stored in an older format and/or unreadable data" (opens http://localhost:8080/administrativeMonitor/OldData/manage )

            One of the folder config.xml files is available in the [docker image|https://github.com/MarkEWaite/docker-lfs/blob/JENKINS-47416/ref/jobs/Git-Client-Folder/config.xml]
            When I installed cloudbees-folder-plugin 6.2.0, the views defined in several of my folders were deleted.

            An administrative monitor appeared warning about unreadable data. The message was:

            {noformat}
            ConversionException: Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] :
            Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() :
            no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            ---- Debugging information ----
            message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            cause-exception : com.thoughtworks.xstream.converters.reflection.ObjectAccessException
            cause-message : Could not call com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve() : no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            class : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder required-type : com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder
            converter-type : hudson.util.RobustReflectionConverter path
            : /com.cloudbees.hudson.plugins.folder.Folder/folderViews line number : 157 -------------------------------
            {noformat}

            To duplicate the problem:

            # Clone, build, and run the docker instance
            {code}
              $ git lfs clone https://github.com/MarkEWaite/docker-lfs JENKINS-47416
              $ cd JENKINS-47416
              $ git lfs fetch origin JENKINS-47416
              $ git checkout -b lts-with-plugins JENKINS-47416
              $ docker build -t jenkins:JENKINS-47416 .
              $ docker run -i --rm --publish 8080:8080 jenkins:JENKINS-47416
            {code}
            # Click "Manage Jenkins"
            # Clck the "Manage" button to the right of "You have data stored in an older format and/or unreadable data" (opens http://localhost:8080/administrativeMonitor/OldData/manage )

            One of the folder config.xml files is available in the [docker image|https://github.com/MarkEWaite/docker-lfs/blob/JENKINS-47416/ref/jobs/Git-Client-Folder/config.xml]

            Conversion exception is thrown even if I update the folder definition to 6.1.2 format before upgrading the cloudbees-folders plugin.
            markewaite Mark Waite made changes -
            Summary Views deleted in folders by upgrade from 6.1.2 to 6.2.0 Views deleted by upgrade from cloudbees-folders 6.1.2 to 6.2.0
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Labels regression
            Hide
            jglick Jesse Glick added a comment -

            Will try to reproduce. My guesses offhand:

            • Stephen Connolly did not have test coverage for the original readResolve
            • and the original catch of InvocationTargetException masked an original bug

            To the second point, the principle I always take is that when calling a method reflectively which might not yet exist, catch NoSuchMethodException and ignore, but log anything else as a warning.

            Show
            jglick Jesse Glick added a comment - Will try to reproduce. My guesses offhand: Stephen Connolly did not have test coverage for the original readResolve and the original catch of InvocationTargetException masked an original bug To the second point, the principle I always take is that when calling a method reflectively which might not yet exist, catch NoSuchMethodException and ignore, but log anything else as a warning.
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-38606 [ JENKINS-38606 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            jglick Jesse Glick added a comment -
            java.lang.IllegalStateException: no parent set on com.cloudbees.hudson.plugins.folder.Folder[null]
            	at hudson.model.AbstractItem.getParent(AbstractItem.java:206)
            	at hudson.model.AbstractItem.getShortUrl(AbstractItem.java:473)
            	at hudson.model.AbstractItem.getUrl(AbstractItem.java:435)
            	at hudson.model.AllView.migrateLegacyPrimaryAllViewLocalizedName(AllView.java:167)
            	at com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve(DefaultFolderViewHolder.java:134)
            

            Guessed right on both counts. The call to migrateLegacyPrimaryAllViewLocalizedName never worked, due to a misplaced attempt to call getUrl in a log message; but this was never noticed because there was no test coverage for the call; and the error was being thrown on every startup for a long time, but then ignored.

            Show
            jglick Jesse Glick added a comment - java.lang.IllegalStateException: no parent set on com.cloudbees.hudson.plugins.folder.Folder[null] at hudson.model.AbstractItem.getParent(AbstractItem.java:206) at hudson.model.AbstractItem.getShortUrl(AbstractItem.java:473) at hudson.model.AbstractItem.getUrl(AbstractItem.java:435) at hudson.model.AllView.migrateLegacyPrimaryAllViewLocalizedName(AllView.java:167) at com.cloudbees.hudson.plugins.folder.views.DefaultFolderViewHolder.readResolve(DefaultFolderViewHolder.java:134) Guessed right on both counts. The call to migrateLegacyPrimaryAllViewLocalizedName never worked, due to a misplaced attempt to call getUrl in a log message; but this was never noticed because there was no test coverage for the call; and the error was being thrown on every startup for a long time, but then ignored.
            jglick Jesse Glick made changes -
            Remote Link This issue links to "core PR 3088 (Web Link)" [ 17885 ]
            jglick Jesse Glick made changes -
            Component/s core [ 15593 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 114 (Web Link)" [ 17886 ]
            jglick Jesse Glick made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            jglick Jesse Glick added a comment -

            Thanks Mark Waite for discovering so promptly and providing exact steps to reproduce!

            Show
            jglick Jesse Glick added a comment - Thanks Mark Waite for discovering so promptly and providing exact steps to reproduce!
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java
            src/test/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolderTest.java
            src/test/resources/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolderTest/oldData/jobs/d/config.xml
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/dd19bff08faba7f49c8da9deea7680f731520dea
            Log:
            JENKINS-47416 Use a patched copy of the core API for now.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java src/test/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolderTest.java src/test/resources/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolderTest/oldData/jobs/d/config.xml http://jenkins-ci.org/commit/cloudbees-folder-plugin/dd19bff08faba7f49c8da9deea7680f731520dea Log: JENKINS-47416 Use a patched copy of the core API for now.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java
            src/test/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolderTest.java
            src/test/resources/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolderTest/oldData/jobs/d/config.xml
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/e491ee80db9a0a8738b2b59a4ffee2623a56c283
            Log:
            Merge pull request #114 from jglick/JENKINS-47416

            JENKINS-47416 Use a patched copy of the core API for now

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/9b3018f71994...e491ee80db9a

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java src/test/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolderTest.java src/test/resources/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolderTest/oldData/jobs/d/config.xml http://jenkins-ci.org/commit/cloudbees-folder-plugin/e491ee80db9a0a8738b2b59a4ffee2623a56c283 Log: Merge pull request #114 from jglick/ JENKINS-47416 JENKINS-47416 Use a patched copy of the core API for now Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/9b3018f71994...e491ee80db9a
            jglick Jesse Glick made changes -
            Remote Link This issue links to "Page (Jenkins Wiki)" [ 17888 ]
            Hide
            jglick Jesse Glick added a comment -

            Core fix merged towards 2.86; plugin workaround released as 6.2.1.

            Show
            jglick Jesse Glick added a comment - Core fix merged towards 2.86; plugin workaround released as 6.2.1.
            jglick Jesse Glick made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/AllView.java
            http://jenkins-ci.org/commit/jenkins/6a2e907e7d4c00ae673a054cc3c65feb24f559de
            Log:
            JENKINS-47416 ViewGroup.getUrl could throw NPE during deserialization, so do not call it from migrateLegacyPrimaryAllViewLocalizedName.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AllView.java http://jenkins-ci.org/commit/jenkins/6a2e907e7d4c00ae673a054cc3c65feb24f559de Log: JENKINS-47416 ViewGroup.getUrl could throw NPE during deserialization, so do not call it from migrateLegacyPrimaryAllViewLocalizedName.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/AllView.java
            http://jenkins-ci.org/commit/jenkins/8ac33fdecea0dfe92450594dadac799e4b3b1f2d
            Log:
            Merge pull request #3088 from jglick/JENKINS-47416

            JENKINS-47416 Do not call ViewGroup.getUrl from migrateLegacyPrimaryAllViewLocalizedName

            Compare: https://github.com/jenkinsci/jenkins/compare/3be716b8373d...8ac33fdecea0

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AllView.java http://jenkins-ci.org/commit/jenkins/8ac33fdecea0dfe92450594dadac799e4b3b1f2d Log: Merge pull request #3088 from jglick/ JENKINS-47416 JENKINS-47416 Do not call ViewGroup.getUrl from migrateLegacyPrimaryAllViewLocalizedName Compare: https://github.com/jenkinsci/jenkins/compare/3be716b8373d...8ac33fdecea0
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/cbde5251843625f389f4be956d0e9d4d3055516c
            Log:
            Noting merge of JENKINS-47416.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/com/cloudbees/hudson/plugins/folder/views/DefaultFolderViewHolder.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/cbde5251843625f389f4be956d0e9d4d3055516c Log: Noting merge of JENKINS-47416 .
            Hide
            markewaite Mark Waite added a comment -

            Verified fixed in folders 6.2.1

            Show
            markewaite Mark Waite added a comment - Verified fixed in folders 6.2.1
            markewaite Mark Waite made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            danielbeck Daniel Beck made changes -
            Labels regression lts-candidate regression
            Hide
            jglick Jesse Glick added a comment -

            Regarding lts-candidate status: the fix should be harmless (it is hard to see how it could cause any regression); OTOH it is not very important, as it only affects users of cloudbees-folder 6.2.0. Having the fix backported to 2.73.3 would make it possible to remove the plugin workaround a little earlier, that is all.

            Show
            jglick Jesse Glick added a comment - Regarding lts-candidate status: the fix should be harmless (it is hard to see how it could cause any regression); OTOH it is not very important, as it only affects users of cloudbees-folder 6.2.0. Having the fix backported to 2.73.3 would make it possible to remove the plugin workaround a little earlier, that is all.
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate regression regression

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                markewaite Mark Waite
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: