Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47723

description should only be required for the first call (and even though?)

    Details

    • Similar Issues:

      Description

      Right now, it's not possible to do

      githubNotify context: 'something', description: 'Blah blah blah', status: 'PENDING'
      ...
      githubNotify context: 'windows', status: 'SUCCESS' // fails when it should not IMO
      

      But in the second call, context should be enough for the plugin to find out which status I want to update. Having to duplicate the description is a bit cumbersome (though I understand it's useful sometimes if one wants to change it afterwards).

      Thanks!

        Attachments

          Activity

          Hide
          rarabaolaza Raul Arabaolaza added a comment -

          Baptiste Mathus I have mixed feelings against this proposal... I understand it can be cumbersome, but I am concerned about parallel steps or code like:

          githubNotify context: 'Doing A', description: 'Blah blah blah', status: 'PENDING'
          githubNotify context: 'Doing B', description: 'Blah blah blah', status: 'PENDING'
          // Actual code goes here
          githubNotify context: 'Doing A', description: 'Blah blah blah', status: 'SUCCESS'
          githubNotify context: 'DOING B', description: 'Blah blah blah', status: 'SUCCESS'

          More in the context of declarative pipeline where you typically would you may resolve the status in the global post section.

          So, I am not sure if complicating the step for this is worth it, my gut feeling is not to try it too smart unless there is a real pain. Any thoughts? You are far more experienced than me... 

          Show
          rarabaolaza Raul Arabaolaza added a comment - Baptiste Mathus I have mixed feelings against this proposal... I understand it can be cumbersome, but I am concerned about parallel steps or code like: githubNotify context: 'Doing A', description: 'Blah blah blah', status: 'PENDING' githubNotify context: 'Doing B', description: 'Blah blah blah', status: 'PENDING' // Actual code goes here githubNotify context: 'Doing A', description: 'Blah blah blah', status: 'SUCCESS' githubNotify context: 'DOING B', description: 'Blah blah blah', status: 'SUCCESS' More in the context of declarative pipeline where you typically would you may resolve the status in the global post section. So, I am not sure if complicating the step for this is worth it, my gut feeling is not to try it too smart unless there is a real pain. Any thoughts? You are far more experienced than me... 

            People

            • Assignee:
              rarabaolaza Raul Arabaolaza
              Reporter:
              batmat Baptiste Mathus
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: