Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47958

Closed branches clone again and try build

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      In latest version of plugin. jenkins clone all branches from repository, but it closed already. But version 2.2.4 work fine. How i can fix it. Web-hook set automatically with Jenkins Pipeline.

        Attachments

          Issue Links

            Activity

            Hide
            b_dean Ben Dean added a comment - - edited

            It is really disheartening that Christian Ewald's jenkinsci/bitbucket-branch-source-plugin#106 was closed without being merged. I get it that Antonio Muñiz's concerns about being able to turn this on or off are worthwhile, but why then don't the people that use Bitbucket and git complain about not having all their closed branches?

            I mean, if Jenkins itself was maintained in Bitbucket as a Mercurial repo, can you imagine having every old build for every PR branch anyone made forever? That cannot possibly be the desired default behavior. In fact, the build for Christian's branch itself is marked as an item to be deleted in the github folder on the main jenkins ci server: https://ci.jenkins.io/job/Plugins/job/bitbucket-branch-source-plugin/view/change-requests/ PR-106 may be gone from there soon because it's closed. That seems like the desired behavior!

            Show
            b_dean Ben Dean added a comment - - edited It is really disheartening that Christian Ewald 's jenkinsci/bitbucket-branch-source-plugin#106  was closed without being merged. I get it that Antonio Muñiz 's concerns about being able to turn this on or off are worthwhile, but why then don't the people that use Bitbucket and git complain about not having all their closed branches? I mean, if Jenkins itself was maintained in Bitbucket as a Mercurial repo, can you imagine having every old build for every PR branch anyone made forever? That cannot possibly be the desired default behavior. In fact, the build for Christian's branch itself is marked as an item to be deleted in the github folder on the main jenkins ci server: https://ci.jenkins.io/job/Plugins/job/bitbucket-branch-source-plugin/view/change-requests/  PR-106 may be gone from there soon because it's closed.  That seems like the desired behavior!
            Hide
            michaelneale Michael Neale added a comment -

            ah thanks Christian Ewald - I think it makes sense now, so, excuse my ignorance of hg, but could I clarify: 

             

            • 2.0 api is shifted to with newer releases, which DOES list closed branches, 1.0 did not
            • in hg a closed branch is idiomatically like a delete in say github
            • in Bitbucket you can delete git branches - but in hg they are closed? 
            • A future RFE could be to build closed branches, but this is about as odd as building deleted github branches (sort of, as they still live in github for a little while)

             

            Reasonable summary? 

            Show
            michaelneale Michael Neale added a comment - ah thanks Christian Ewald - I think it makes sense now, so, excuse my ignorance of hg, but could I clarify:    2.0 api is shifted to with newer releases, which DOES list closed branches, 1.0 did not in hg a closed branch is idiomatically like a delete in say github in Bitbucket you can delete git branches - but in hg they are closed?  A future RFE could be to build closed branches, but this is about as odd as building deleted github branches (sort of, as they still live in github for a little while)   Reasonable summary? 
            Hide
            hubble1942 Christian Ewald added a comment -

            Michael Neale: Absolutely reasonable. Thx

            Show
            hubble1942 Christian Ewald added a comment - Michael Neale : Absolutely reasonable. Thx
            Hide
            casz Joseph Petersen added a comment -

            Fixed in Bitbucket Branch Source Plugin 2.2.10

            Show
            casz Joseph Petersen added a comment - Fixed in Bitbucket Branch Source Plugin 2.2.10
            Hide
            michaelneale Michael Neale added a comment -

            thanks Christian Ewald for fix, thanks all for trying it out and thanks Vivek Pandey Antonio Muñiz rsandell for review/release, mercurial users should be in a better state now with closed branches. 

            Show
            michaelneale Michael Neale added a comment - thanks Christian Ewald for fix, thanks all for trying it out and thanks Vivek Pandey Antonio Muñiz rsandell for review/release, mercurial users should be in a better state now with closed branches. 

              People

              • Assignee:
                Unassigned
                Reporter:
                rmuhamedgaliev Rinat Muhamedgaliev
              • Votes:
                4 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: