Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48055

FindBugs: Channel#current() may return null, not all routines in the core handle that

    Details

    • Similar Issues:

      Description

      Remoting versions since 3.11 have explicit annotations for Channel#getCurrent(), and there are lots of FindBugs issues reported due to that. All usages are safe, so there is no need in backporting.

      My proposal is to...

      1) Add a convenience default method to Remoting's Callable, which throws IOException
      2) Use the new convenience method in all Callable implementations in the core

        Attachments

          Activity

          oleg_nenashev Oleg Nenashev created issue -
          oleg_nenashev Oleg Nenashev made changes -
          Field Original Value New Value
          Epic Link JENKINS-36716 [ 172750 ]
          oleg_nenashev Oleg Nenashev made changes -
          Description Remoting versions since 3.11 have explicit annotations for Channel#getCurrent(), and there are lots of FindBugs issues reported due to that. All usages are safe, so there is no need in backporting.

          My proposal is to...

          1) Add a convenience default method to Remoting's Callable, which throws IOException
          2) Use the new convenience method in all Callable implementations in the core

          oleg_nenashev Oleg Nenashev made changes -
          Assignee Oleg Nenashev [ oleg_nenashev ]
          oleg_nenashev Oleg Nenashev made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          oleg_nenashev Oleg Nenashev made changes -
          Component/s remoting [ 15489 ]
          oleg_nenashev Oleg Nenashev made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: