Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48155

gerrit-trigger-plugin does not repsect dynamicTriggerConfiguration flag

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I had previously configured a trigger in a Jenkins job to use the dynamic trigger configuration.  I then unchecked the checkbox, but I still see this job triggering on gerrit repos that are in the referenced dynamic trigger file.  It appears that even though in the XML I see the following:

      <dynamicTriggerConfiguration>false</dynamicTriggerConfiguration>

      It is still referencing the triggers that are configured in the file in the URL.

      If I recheck the dynamic trigger box, I can clear out the URL, then uncheck the box again. But then I see the following error on the main job page:

      Problem with Gerrit dynamic trigger configuration:MalformedURLException when fetching dynamic trigger url: The gerritTriggerConfigUrl is empty

       

      This is very easy to reproduce.

       

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexander Akbashev
          Path:
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/756a09e85723c4c2cb8ba635aabebd347b91dae3
          Log:
          JENKINS-48155: gerrit-trigger-plugin does not repsect dynamicTriggerConfiguration flag

          If user does not want to use dynamic configuration anymore, let's assign
          the list of projects to empty list to avoid possible race conditions.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexander Akbashev Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/756a09e85723c4c2cb8ba635aabebd347b91dae3 Log: JENKINS-48155 : gerrit-trigger-plugin does not repsect dynamicTriggerConfiguration flag If user does not want to use dynamic configuration anymore, let's assign the list of projects to empty list to avoid possible race conditions.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Robert Sandell
          Path:
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/afab9e9c99f49c457776ae64f15a36fa54017113
          Log:
          Merge pull request #336 from Jimilian/JENKINS_48155

          JENKINS-48155: gerrit-trigger-plugin does not repsect dynamicTriggerConfiguration flag

          Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/fde68b35f54f...afab9e9c99f4

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/afab9e9c99f49c457776ae64f15a36fa54017113 Log: Merge pull request #336 from Jimilian/JENKINS_48155 JENKINS-48155 : gerrit-trigger-plugin does not repsect dynamicTriggerConfiguration flag Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/fde68b35f54f...afab9e9c99f4

            People

            • Assignee:
              jimilian Alexander A
              Reporter:
              caiken_qc Craig Aiken
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: