Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48226

MultiBranch doesn't distinguish Branches and PRs

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      jenkins.branch.Branch#getName uses head.getName
      That ends that branch name equals PR name makes branch api crazy.
      As example your github-branchsource-plugin https://ci.jenkins.io/job/Plugins/job/github-plugin/job/PR-182/ after branch appeared in Branches it disappeared in PullRequests and mixined build history.

      And guess revision https://ci.jenkins.io/job/Plugins/job/github-plugin/job/PR-182/5/

      Normally SCMCategories must be part of branch names or at all subfolders. And the easiest: enforce implementations to deal themselves with prefixes (that ideally are categories).

        Attachments

          Activity

          Hide
          stephenconnolly Stephen Connolly added a comment -

          Functions as designed

          Show
          stephenconnolly Stephen Connolly added a comment - Functions as designed
          Hide
          integer Kanstantsin Shautsou added a comment - - edited

          Seriously? lol. FS and job naming should not be tied to what is displayed in UI vs stored on fs. That is fundamental bug for standard use cases when people name branches as pr-X, branch for fixing certain PR. Multibranch treats everything as branches and stores EVERYTHING in one folder, so different categories may have the same naming, so on FS they should be internally prefixed to get separation while displayed in UI according to category to exclude duplicating words like "PR" in PR tab.

          Show
          integer Kanstantsin Shautsou added a comment - - edited Seriously? lol. FS and job naming should not be tied to what is displayed in UI vs stored on fs. That is fundamental bug for standard use cases when people name branches as pr-X, branch for fixing certain PR. Multibranch treats everything as branches and stores EVERYTHING in one folder, so different categories may have the same naming, so on FS they should be internally prefixed to get separation while displayed in UI according to category to exclude duplicating words like "PR" in PR tab.
          Hide
          integer Kanstantsin Shautsou added a comment -

          Reopened, issue is obvious for a number of devs

          Show
          integer Kanstantsin Shautsou added a comment - Reopened, issue is obvious for a number of devs
          Hide
          stephenconnolly Stephen Connolly added a comment -

          Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

          Show
          stephenconnolly Stephen Connolly added a comment - Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

            People

            • Assignee:
              Unassigned
              Reporter:
              integer Kanstantsin Shautsou
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: