Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48578

Create BOM for components included into the Core

    Details

    • Similar Issues:

      Description

      The idea of this BOM is to simplify the dependency management in plugins and modules.

      Proposed changes:

      1. New BOM module in the jenkinsci/jenkins repository. We could have an external BOM, but it complicates the release management
      2. Move library definitions from Parent POM and Jenkins WAR to the BOM file
      3. Update WAR and Core components to use BOM
      4. Update plugin POM to optionally include BOM if possible (depending on jenkins.version)

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            There is no way it gets backported to LTS, so I removed the label

            Show
            oleg_nenashev Oleg Nenashev added a comment - There is no way it gets backported to LTS, so I removed the label
            Hide
            teilo James Nord added a comment - - edited

            >There is no way it gets backported to LTS, so I removed the label

            yes there is, I can adapt it and it can be included.  the label is to start a discussion.  I do not think the libraries have changed here so it can also be a simple cherry-pick.

            Granted you could call this a feature that is not eligible, but you could call it a bug that the correct libraries are not used in a plugin build based on the Jenkins version.

            There have also been some special cases historically.

            Show
            teilo James Nord added a comment - - edited >There is no way it gets backported to LTS, so I removed the label yes there is, I can adapt it and it can be included.  the label is to start a discussion.  I do not think the libraries have changed here so it can also be a simple cherry-pick. Granted you could call this a feature that is not eligible, but you could call it a bug that the correct libraries are not used in a plugin build based on the Jenkins version. There have also been some special cases historically.
            Hide
            teilo James Nord added a comment -

            specifically we are talking about the BOM in core for backport not the plugin-pom.
            https://github.com/jenkinsci/jenkins/pull/4150

            Show
            teilo James Nord added a comment - specifically we are talking about the BOM in core for backport not the plugin-pom. https://github.com/jenkinsci/jenkins/pull/4150
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Note that the 2.190.1 RC has testing has already started. Even if there is a consensus to backport it, it is likely to be 2.190.2 only

             

            My suggestion would be to actually consider doing this:

            > Would selectivly need to publish a few BOMs for older lines so that the plugin-pom would still work (which would get funky as far as permissions in repository are perhaps concerned...)

            It is funky indeed, but it is technically doable. My suggestion would be to deploy BOMs for 2.138.3 and above so that we can start consuming it in plugins quickly. Deploying it for last baseline releases (2.138.3, 2.150.3, 2.164.3, 2.176.3/4) would be enough imho

             

            Show
            oleg_nenashev Oleg Nenashev added a comment - Note that the 2.190.1 RC has testing has already started. Even if there is a consensus to backport it, it is likely to be 2.190.2 only   My suggestion would be to actually consider doing this: > Would selectivly need to publish a few BOMs for older lines so that the plugin-pom would still work (which would get funky as far as permissions in repository are perhaps concerned...) It is funky indeed, but it is technically doable. My suggestion would be to deploy BOMs for 2.138.3 and above so that we can start consuming it in plugins quickly. Deploying it for last baseline releases (2.138.3, 2.150.3, 2.164.3, 2.176.3/4) would be enough imho  
            Hide
            teilo James Nord added a comment -

            >  Even if there is a consensus to backport it, it is likely to be 2.190.2 only

            If it prevents the "oh shit I forgot to push a release of the bom after a release was made" that's a win in my eyes.  We're aware the .1 boat has sailed and we where a little late to merge the original bom and hence make the backport request.

            Show
            teilo James Nord added a comment - >  Even if there is a consensus to backport it, it is likely to be 2.190.2 only If it prevents the "oh shit I forgot to push a release of the bom after a release was made" that's a win in my eyes.  We're aware the .1 boat has sailed and we where a little late to merge the original bom and hence make the backport request.

              People

              • Assignee:
                markwm Mark Wynn-Mackenzie
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                2 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated: