Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48826

Branches within a MBP run under a previously-overridden mode after the override has been removed

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Labels:
    • Environment:
    • Similar Issues:

      Description

      Summary
      Given a Global speed/durability setting of None: use pipeline default (MAX_SURVIVABILITY), it's possible to override a particular MBP project with a different run mode, such as PERFORMANCE_OPTIMIZED. If you remove this override, it disappears from the MBP's Configuration page as expected. Despite this, the branches will still run in PERFORMANCE_OPTIMIZED mode, I expected them to flip back to the Global default.

      Prerequisites:

      • Jenkins with the latest experiemtal update center versions of the Pipeline storage betas
      • A MBP project with several branches, which include a Jenkinsfile that can be built successfully

      Steps to recreate:
      Probably the easiest way to describe this is using a table. I hope this makes sense to others in the same way it does to me.

      Step Global Setting MBP Setting Expected Actual
      1 Set to None: use pipeline default (MAX_SURVIVABILITY)   No override Pass: No override shown
      2   Verify DURABLE setting MBP Config Page and individual branch View Config pages both show DURABLE Pass
      3   Add Override and set to PERF . .
      4   Verify PERF setting MBP Config Page and individual branch View Config pages both show PERF Pass
      5   Run one build of DeclarativeParallels Build runs in PERF Pass
      6 Change to MIDDLE Verify PERF setting still present Global Setting in MIDDLE, MBP setting still in PERF. Pass
      7   Remove override, save Override should be gone Pass: Override is gone
      8   Check setting on individual branches Override should be gone Fail: Override is still present
      9   Run an individual branch in the MBP project Branch should run with Global default of MIDDLE Fail: Job runs in PERF

        Attachments

          Activity

          Hide
          svanoort Sam Van Oort added a comment -

          Resolved with commit https://github.com/jenkinsci/workflow-multibranch-plugin/pull/68/commits/2694ac5441dfe24a20dac677e398ec9b6f00536e in the current main branch (skipping in-review status because it's covered by the blanket review). 

          Show
          svanoort Sam Van Oort added a comment - Resolved with commit https://github.com/jenkinsci/workflow-multibranch-plugin/pull/68/commits/2694ac5441dfe24a20dac677e398ec9b6f00536e  in the current main branch (skipping in-review status because it's covered by the blanket review). 
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          src/main/java/org/jenkinsci/plugins/workflow/multibranch/DurabilityHintBranchProperty.java
          src/test/java/org/jenkinsci/plugins/workflow/multibranch/DurabilityHintBranchPropertyWorkflowTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/2694ac5441dfe24a20dac677e398ec9b6f00536e
          Log:
          Fix JENKINS-48826 by using DurabilityHint provider with the BranchProperty dynamically

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/multibranch/DurabilityHintBranchProperty.java src/test/java/org/jenkinsci/plugins/workflow/multibranch/DurabilityHintBranchPropertyWorkflowTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/2694ac5441dfe24a20dac677e398ec9b6f00536e Log: Fix JENKINS-48826 by using DurabilityHint provider with the BranchProperty dynamically

            People

            • Assignee:
              svanoort Sam Van Oort
              Reporter:
              kshultz Karl Shultz
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: