Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48925

TAP plugin is not compatible with JEP-200 in Jenkins 2.102

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Discovered it while doing PCT for Jenkins 2.102 SNAPSHOT.

      Several classes in Tap use classes from a 3rd-party library, and the serialization to the disk fails. Full log is attached

      java.lang.UnsupportedOperationException: Refusing to marshal org.tap4j.model.TestSet for security reasons; see https://jenkins.io/redirect/class-filter/
      	at hudson.util.XStream2$BlacklistedTypesConverter.marshal(XStream2.java:530)
      	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
      	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
      	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      Caused: java.lang.RuntimeException: Failed to serialize org.tap4j.plugin.model.TestSetMap#testSet for class org.tap4j.plugin.model.TestSetMap
      	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
      

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I will give a bite since it hits one of my instances

            Show
            oleg_nenashev Oleg Nenashev added a comment - I will give a bite since it hits one of my instances
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            This guy may be a problem: https://github.com/tupilabs/tap4j/blob/master/tap4j/src/main/java/org/tap4j/model/TapElement.java#L50

                /**
                 * Iterable object returned by SnakeYAML.
                 */
                private Map<String, Object> diagnostic = new LinkedHashMap<String, Object>();
            

            Does not seem whitelistable to me

            Show
            oleg_nenashev Oleg Nenashev added a comment - This guy may be a problem: https://github.com/tupilabs/tap4j/blob/master/tap4j/src/main/java/org/tap4j/model/TapElement.java#L50 /** * Iterable object returned by SnakeYAML. */ private Map< String , Object > diagnostic = new LinkedHashMap< String , Object >(); Does not seem whitelistable to me
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Should be fixed in 2.2

            Show
            oleg_nenashev Oleg Nenashev added a comment - Should be fixed in 2.2
            Hide
            oleg_nenashev Oleg Nenashev added a comment -
            Show
            oleg_nenashev Oleg Nenashev added a comment - The fix was not complete: https://github.com/jenkinsci/tap-plugin/pull/21
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Vladislav Ponomarev
            Path:
            src/main/resources/META-INF/hudson.remoting.ClassFilter
            http://jenkins-ci.org/commit/tap-plugin/81252f94a313bff6cceb109308fe1c6292ed929f
            Log:
            JENKINS-48925 continuation - whitelisted `org.tap4j.model.Text`.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vladislav Ponomarev Path: src/main/resources/META-INF/hudson.remoting.ClassFilter http://jenkins-ci.org/commit/tap-plugin/81252f94a313bff6cceb109308fe1c6292ed929f Log: JENKINS-48925 continuation - whitelisted `org.tap4j.model.Text`.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Bruno P. Kinoshita
            Path:
            src/main/resources/META-INF/hudson.remoting.ClassFilter
            http://jenkins-ci.org/commit/tap-plugin/c9f1ae5636e0b5e357e08b65dd7f82c87e499cc9
            Log:
            Merge pull request #21 from anenviousguest/master

            JENKINS-48925 continuation - whitelisted `org.tap4j.model.Text`.

            Compare: https://github.com/jenkinsci/tap-plugin/compare/64d6fffc891e...c9f1ae5636e0

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/resources/META-INF/hudson.remoting.ClassFilter http://jenkins-ci.org/commit/tap-plugin/c9f1ae5636e0b5e357e08b65dd7f82c87e499cc9 Log: Merge pull request #21 from anenviousguest/master JENKINS-48925 continuation - whitelisted `org.tap4j.model.Text`. Compare: https://github.com/jenkinsci/tap-plugin/compare/64d6fffc891e...c9f1ae5636e0
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The second fix has been released in 2.2.1

            Show
            oleg_nenashev Oleg Nenashev added a comment - The second fix has been released in 2.2.1

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: