Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48950

JEP-200: GHPRB Plugin Fails Whitelist

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The GitHub PR Builder plugin gets flagged after updating to 2.102 breaking automated PR jobs:

       

      WARNING: org.kohsuke.github.GHPullRequestCommitDetail$Authorship in file:/var/lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/
      Jan 15, 2018 1:55:20 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1
      WARNING: org.kohsuke.github.GHUser in file:/var/lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/

       

      The mitigation technique worked by adding the class names to the Hudson classfilter:

      -Dhudson.remoting.ClassFilter=org.kohsuke.github.*

      ^ This doesn't actually work, would need to force all of the dependent classes individually here. In my case, the WARNING messages just didn't show up in the log until later than I expected and still resulted in the build.xml throwing the stack traces below when a job using the GHPRB was run.

       

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Yes, we likely need to whitelist the entire GitHub API

            Show
            oleg_nenashev Oleg Nenashev added a comment - Yes, we likely need to whitelist the entire GitHub API
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Jeremy Stewart would it be possible to get a full stacktrace of this issue?

            Show
            oleg_nenashev Oleg Nenashev added a comment - Jeremy Stewart would it be possible to get a full stacktrace of this issue?
            Hide
            jglick Jesse Glick added a comment -

            I suspect this code is the problem. These classes were not meant to be stored in build.xml. Since getShortDescription uses only safe fields, and the others seem to be used only during the build, probably everything else could simply be made transient and the problem solved (as well as fixing who knows what other issues).

            Show
            jglick Jesse Glick added a comment - I suspect this code  is the problem. These classes were not meant to be stored in build.xml . Since getShortDescription uses only safe fields, and the others seem to be used only during the build, probably everything else could simply be made transient and the problem solved (as well as fixing who knows what other issues).
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Yes, I returned back to this ticket && doing the plugin-side change now

            Show
            oleg_nenashev Oleg Nenashev added a comment - Yes, I returned back to this ticket && doing the plugin-side change now
            Hide
            sasquatch85 Jeremy Stewart added a comment -

            Oleg, this is all I could get from the logs. I won't be able to enable debug mode as this is a production system with limited downtime, but I hope it helps. Looks like Jesse Glick is already on to it and highlighted what looks like the issue. If I forced these two classes through, another few farther down the dependency chain would come up the next time I restarted jenkins so I wound up using org.kohsuke.github.* to cover it all and move along so we could get it running.

             

            INFO: Jenkins is fully up and running
            Jan 15, 2018 1:55:20 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1
            WARNING: org.kohsuke.github.GHPullRequestCommitDetail$Authorship in file:/var/lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/
            Jan 15, 2018 1:55:20 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1
            WARNING: org.kohsuke.github.GHUser in file:/var/lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/
            Jan 15, 2018 1:55:20 PM hudson.util.RobustReflectionConverter doUnmarshal
            WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser
            Jan 15, 2018 1:55:20 PM hudson.util.RobustReflectionConverter doUnmarshal
            WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser
            Jan 15, 2018 1:55:20 PM hudson.util.RobustReflectionConverter doUnmarshal
            WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser
            

             

             

            Show
            sasquatch85 Jeremy Stewart added a comment - Oleg, this is all I could get from the logs. I won't be able to enable debug mode as this is a production system with limited downtime, but I hope it helps. Looks like Jesse Glick is already on to it and highlighted what looks like the issue. If I forced these two classes through, another few farther down the dependency chain would come up the next time I restarted jenkins so I wound up using org.kohsuke.github.* to cover it all and move along so we could get it running.   INFO: Jenkins is fully up and running Jan 15, 2018 1:55:20 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1 WARNING: org.kohsuke.github.GHPullRequestCommitDetail$Authorship in file:/ var /lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https: //jenkins.io/redirect/ class- filter/ Jan 15, 2018 1:55:20 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1 WARNING: org.kohsuke.github.GHUser in file:/ var /lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https: //jenkins.io/redirect/ class- filter/ Jan 15, 2018 1:55:20 PM hudson.util.RobustReflectionConverter doUnmarshal WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser Jan 15, 2018 1:55:20 PM hudson.util.RobustReflectionConverter doUnmarshal WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser Jan 15, 2018 1:55:20 PM hudson.util.RobustReflectionConverter doUnmarshal WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser    
            Hide
            jglick Jesse Glick added a comment -

            Wildcards are not supported in this system property. You need to enumerate particular class names.

            Show
            jglick Jesse Glick added a comment - Wildcards are not supported in this system property. You need to enumerate particular class names.
            Hide
            sasquatch85 Jeremy Stewart added a comment - - edited

            You're correct, had a bunch of issues crop up from this but strangely after a completely successful build just prior. Will try to go back and enumerate things for now.

             

            Stacktrace for reference:

            Can't update build descriptionjava.io.IOException: java.lang.RuntimeException: Failed to serialize hudson.model.Actionable#actions for class hudson.model.FreeStyleBuild
            	at hudson.XmlFile.write(XmlFile.java:201)
            	at hudson.model.Run.save(Run.java:1923)
            	at hudson.model.Run.setDescription(Run.java:2228)
            	at org.jenkinsci.plugins.ghprb.GhprbBuilds.onStarted(GhprbBuilds.java:145)
            	at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onStarted(GhprbBuildListener.java:18)
            	at hudson.model.listeners.RunListener.fireStarted(RunListener.java:240)
            	at hudson.model.Run.execute(Run.java:1723)
            	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
            	at hudson.model.ResourceController.execute(ResourceController.java:97)
            	at hudson.model.Executor.run(Executor.java:429)
            Caused by: java.lang.RuntimeException: Failed to serialize hudson.model.Actionable#actions for class hudson.model.FreeStyleBuild
            	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
            	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
            	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
            	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
            	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
            	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
            	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
            	at com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82)
            	at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37)
            	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026)
            	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015)
            	at com.thoughtworks.xstream.XStream.toXML(XStream.java:988)
            	at hudson.XmlFile.write(XmlFile.java:194)
            	... 9 more
            Caused by: java.lang.RuntimeException: Failed to serialize hudson.model.CauseAction#causeBag for class hudson.model.CauseAction
            	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
            	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
            	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
            	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
            	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
            	at hudson.util.XStream2$PassthruConverter.marshal(XStream2.java:478)
            	at hudson.util.XStream2$AssociatedConverterImpl.marshal(XStream2.java:448)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
            	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
            	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
            	at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64)
            	at com.thoughtworks.xstream.converters.collections.CollectionConverter.marshal(CollectionConverter.java:74)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
            	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
            	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
            	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
            	... 22 more
            Caused by: java.lang.RuntimeException: Failed to serialize org.jenkinsci.plugins.ghprb.GhprbCause#commitAuthor for class org.jenkinsci.plugins.ghprb.GhprbCause
            	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
            	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
            	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
            	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
            	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
            	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
            	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
            	at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64)
            	at com.thoughtworks.xstream.converters.collections.MapConverter.marshal(MapConverter.java:78)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
            	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
            	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
            	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
            	... 39 more
            Caused by: java.lang.UnsupportedOperationException: Refusing to marshal org.kohsuke.github.GHPullRequestCommitDetail$Authorship for security reasons; see https://jenkins.io/redirect/class-filter/
            	at hudson.util.XStream2$BlacklistedTypesConverter.marshal(XStream2.java:530)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
            	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
            	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
            	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
            	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
            	... 54 more
            
            Show
            sasquatch85 Jeremy Stewart added a comment - - edited You're correct, had a bunch of issues crop up from this but strangely after a completely successful build just prior. Will try to go back and enumerate things for now.   Stacktrace for reference: Can't update build descriptionjava.io.IOException: java.lang.RuntimeException: Failed to serialize hudson.model.Actionable#actions for class hudson.model.FreeStyleBuild at hudson.XmlFile.write(XmlFile.java:201) at hudson.model.Run.save(Run.java:1923) at hudson.model.Run.setDescription(Run.java:2228) at org.jenkinsci.plugins.ghprb.GhprbBuilds.onStarted(GhprbBuilds.java:145) at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onStarted(GhprbBuildListener.java:18) at hudson.model.listeners.RunListener.fireStarted(RunListener.java:240) at hudson.model.Run.execute(Run.java:1723) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: java.lang.RuntimeException: Failed to serialize hudson.model.Actionable#actions for class hudson.model.FreeStyleBuild at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256) at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224) at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138) at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43) at com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82) at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37) at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026) at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015) at com.thoughtworks.xstream.XStream.toXML(XStream.java:988) at hudson.XmlFile.write(XmlFile.java:194) ... 9 more Caused by: java.lang.RuntimeException: Failed to serialize hudson.model.CauseAction#causeBag for class hudson.model.CauseAction at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256) at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224) at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138) at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150) at hudson.util.XStream2$PassthruConverter.marshal(XStream2.java:478) at hudson.util.XStream2$AssociatedConverterImpl.marshal(XStream2.java:448) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88) at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64) at com.thoughtworks.xstream.converters.collections.CollectionConverter.marshal(CollectionConverter.java:74) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84) at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265) at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252) ... 22 more Caused by: java.lang.RuntimeException: Failed to serialize org.jenkinsci.plugins.ghprb.GhprbCause#commitAuthor for class org.jenkinsci.plugins.ghprb.GhprbCause at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256) at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224) at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138) at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209) at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88) at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64) at com.thoughtworks.xstream.converters.collections.MapConverter.marshal(MapConverter.java:78) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84) at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265) at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252) ... 39 more Caused by: java.lang.UnsupportedOperationException: Refusing to marshal org.kohsuke.github.GHPullRequestCommitDetail$Authorship for security reasons; see https: //jenkins.io/redirect/ class- filter/ at hudson.util.XStream2$BlacklistedTypesConverter.marshal(XStream2.java:530) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69) at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58) at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84) at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265) at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252) ... 54 more
            Hide
            jglick Jesse Glick added a comment -

            I think I know what to fix here; just need to get a working test setup of the plugin to confirm the fix.

            Show
            jglick Jesse Glick added a comment - I think I know what to fix here; just need to get a working test setup of the plugin to confirm the fix.
            Hide
            jglick Jesse Glick added a comment -

            Anyone landing here, if you are interested in trying an experimental fix, you could try the snapshot build from the PR until maintainers respond. Use Plugin Manager » Advanced.

            Show
            jglick Jesse Glick added a comment - Anyone landing here, if you are interested in trying an experimental fix, you could try  the snapshot build from the PR until maintainers respond. Use Plugin Manager » Advanced .
            Hide
            sasquatch85 Jeremy Stewart added a comment -

            Jesse,

            Thanks for taking charge of this! I tried out your snapshot build but am still receiving the errors below. Do I still need to add these classes to the ClassFilter? The plugin reports as version "1.39.1-SNAPSHOT (private-e3afffc5-win2012-22b740$)" which I think is correct.

             

            INFO: Jenkins is fully up and running
            Jan 16, 2018 4:15:06 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1
            WARNING: org.kohsuke.github.GHPullRequestCommitDetail$Authorship in file:/var/lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/
            Jan 16, 2018 4:15:06 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1
            WARNING: org.kohsuke.github.GHUser in file:/var/lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/
            Jan 16, 2018 4:15:06 PM hudson.util.RobustReflectionConverter doUnmarshal
            WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser
            Jan 16, 2018 4:15:06 PM hudson.util.RobustReflectionConverter doUnmarshal
            WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser
            Show
            sasquatch85 Jeremy Stewart added a comment - Jesse, Thanks for taking charge of this! I tried out your snapshot build but am still receiving the errors below. Do I still need to add these classes to the ClassFilter? The plugin reports as version "1.39.1-SNAPSHOT (private-e3afffc5-win2012-22b740$)" which I think is correct.   INFO: Jenkins is fully up and running Jan 16, 2018 4:15:06 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1 WARNING: org.kohsuke.github.GHPullRequestCommitDetail$Authorship in file:/ var /lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https: //jenkins.io/redirect/ class- filter/ Jan 16, 2018 4:15:06 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1 WARNING: org.kohsuke.github.GHUser in file:/ var /lib/jenkins/plugins/github-api/WEB-INF/lib/github-api-1.90.jar might be dangerous, so rejecting; see https: //jenkins.io/redirect/ class- filter/ Jan 16, 2018 4:15:06 PM hudson.util.RobustReflectionConverter doUnmarshal WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser Jan 16, 2018 4:15:06 PM hudson.util.RobustReflectionConverter doUnmarshal WARNING: Cannot convert type org.jenkinsci.plugins.ghprb.GhprbCause to type org.kohsuke.github.GHUser
            Hide
            d4n13lbc Daniel Barragan added a comment - - edited

            I was having this error: "failed to serialize hudson.model.Actionable#actions" and the update worked for me

            Show
            d4n13lbc Daniel Barragan added a comment - - edited I was having this error: "failed to serialize hudson.model.Actionable#actions" and the update worked for me
            Hide
            sasquatch85 Jeremy Stewart added a comment -

            I have to confess we don't have many jobs running with this plugin, but Daniel is right. Just kicked off a build via PR and the errors in the build.xml are gone despite the warnings in the jenkins.log.

            Show
            sasquatch85 Jeremy Stewart added a comment - I have to confess we don't have many jobs running with this plugin, but Daniel is right. Just kicked off a build via PR and the errors in the build.xml are gone despite the warnings in the jenkins.log.
            Hide
            jglick Jesse Glick added a comment -

            Jeremy Stewart I suspect those warnings are from loading historical builds, which is not something I attempted to solve. Check whether the Jenkins /manage screen offers a Manage Old Data link. At least that would explain the first two warnings; the second two look strange to me.

            Show
            jglick Jesse Glick added a comment - Jeremy Stewart I suspect those warnings are from loading historical builds, which is not something I attempted to solve. Check whether the Jenkins /manage screen offers a Manage Old Data link. At least that would explain the first two warnings; the second two look strange to me.
            Hide
            sasquatch85 Jeremy Stewart added a comment -

            Jesse,

            Right on the money! Thanks a ton, I never would have guessed that. We did lose some build history for the builds between updating to 2.102 and when I installed your patched plugin but that's not a huge loss.

            Show
            sasquatch85 Jeremy Stewart added a comment - Jesse, Right on the money! Thanks a ton, I never would have guessed that. We did lose some build history for the builds between updating to 2.102 and when I installed your patched plugin but that's not a huge loss.
            Hide
            jglick Jesse Glick added a comment -

            I probably know how to fix that (just rename the newly transient variables), but unless a plugin maintainer appears and seems ready to do a release, I am not about to spend time on retesting.

            Show
            jglick Jesse Glick added a comment - I probably know how to fix that (just rename the newly transient variables), but unless a plugin maintainer appears and seems ready to do a release, I am not about to spend time on retesting.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/ghprb/GhprbCause.java
            http://jenkins-ci.org/commit/ghprb-plugin/e3afffc529941bc2674bc98f5cda3fd6944abfe8
            Log:
            JENKINS-48950 [JEP-200] Stop trying to serialize github-api types.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/ghprb/GhprbCause.java http://jenkins-ci.org/commit/ghprb-plugin/e3afffc529941bc2674bc98f5cda3fd6944abfe8 Log: JENKINS-48950 [JEP-200] Stop trying to serialize github-api types.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Gleske
            Path:
            src/main/java/org/jenkinsci/plugins/ghprb/GhprbCause.java
            http://jenkins-ci.org/commit/ghprb-plugin/e381590a278599f689d3394651f009faf86610cf
            Log:
            Merge pull request #616 from jglick/JENKINS-48950

            JENKINS-48950 [JEP-200] Stop trying to serialize github-api types

            Compare: https://github.com/jenkinsci/ghprb-plugin/compare/66084576abfc...e381590a2785

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Gleske Path: src/main/java/org/jenkinsci/plugins/ghprb/GhprbCause.java http://jenkins-ci.org/commit/ghprb-plugin/e381590a278599f689d3394651f009faf86610cf Log: Merge pull request #616 from jglick/ JENKINS-48950 JENKINS-48950 [JEP-200] Stop trying to serialize github-api types Compare: https://github.com/jenkinsci/ghprb-plugin/compare/66084576abfc...e381590a2785
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Fixed in GHPRB 1.40.0

            Show
            oleg_nenashev Oleg Nenashev added a comment - Fixed in GHPRB 1.40.0

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                sasquatch85 Jeremy Stewart
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: