Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48997

The new submodule pattern matching breaks submodules with spaces in name

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Blocker
    • Resolution: Duplicate
    • Component/s: git-client-plugin
    • Labels:
      None
    • Environment:
      git-client-pluging 2.7.0
      jenkins 2.102
    • Similar Issues:

      Description

      The new submodule pattern matching introduced in 52f681e6153eb088495edd497a82d6dc919dcae3 commit in git-client-plugin 2.7.0 for JENKINS-46054 issue breaks submodules with spaces in name.

      The previous pattern was this one:

      git config -f .gitmodules --get-regexp "^submodule\.(.*)\.url"
      

      But now it's this one: 

      git config -f .gitmodules --get-regexp "^submodule\.([^ ]+)\.url"

      So submodule with space in name are not matched anymore: 

      submodule.Submodules/Foo iOS Library.url ssh://git@stash.mobile.bar.com:7999/foo/ios-library.git 
      

       It would be better to use a pattern like this one:

      git config -f .gitmodules --get-regexp '^submodule\.(.+)\.url$'
      

       

       

        Attachments

          Issue Links

            Activity

            There are no comments yet on this issue.

              People

              • Assignee:
                markewaite Mark Waite
                Reporter:
                flabrie Francis Labrie
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: