Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49051

Add event field to BranchEventCause

    Details

    • Similar Issues:

      Description

      Adding the event object that triggered the build will expose more information. E.g in case of BitbucketServerPullRequestEvent it will allow to know within the pipeline what are the source and target branch without querying Bitbucket 

        Attachments

          Activity

          yurigo79 Yuri Goikhman created issue -
          Hide
          yurigo79 Yuri Goikhman added a comment - - edited
          Show
          yurigo79 Yuri Goikhman added a comment - - edited Stephen Connolly I've created a PR https://github.com/jenkinsci/branch-api-plugin/pull/124   please take a look 
          Hide
          stephenconnolly Stephen Connolly added a comment -

          Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

          Show
          stephenconnolly Stephen Connolly added a comment - Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA
          stephenconnolly Stephen Connolly made changes -
          Field Original Value New Value
          Assignee Stephen Connolly [ stephenconnolly ]
          Hide
          bitwiseman Liam Newman added a comment -

          Yuri Goikhman
          This point of this would be to reduce network bandwidth right?
          Network connection would still be needed for some data sooner or later.

          This change will require additional changes to derived classes to make it useful.

          You mention the bitbucket plugin. Have you considered implementing the desired changes locally there to see how they go? I understand this change would have benefits for other scm plugins, but it might be worth it to workout the kinks within the context of a single plugin before changing the upstream classes/apis.

          Show
          bitwiseman Liam Newman added a comment - Yuri Goikhman This point of this would be to reduce network bandwidth right? Network connection would still be needed for some data sooner or later. This change will require additional changes to derived classes to make it useful. You mention the bitbucket plugin. Have you considered implementing the desired changes locally there to see how they go? I understand this change would have benefits for other scm plugins, but it might be worth it to workout the kinks within the context of a single plugin before changing the upstream classes/apis.

            People

            • Assignee:
              Unassigned
              Reporter:
              yurigo79 Yuri Goikhman
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: