Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49083

RabbitMQ Plugins broken by JEP-200

    Details

    • Similar Issues:

      Description

      After updating to 2.103

      Plugins involved:
      rabbitmq-build-trigger 2.5 true
      rabbitmq-consumer 2.7 true

      Message at the Manage Jenkins link:

      org.jenkinsci.plugins.rabbitmqconsumer.GlobalRabbitmqConfiguration

      RabbitMQ consumer

      ConversionException: Refusing to unmarshal urlValidator for security reasons; see https://jenkins.io/redirect/class-filter/ ---- Debugging information ---- class : org.apache.commons.validator.routines.UrlValidator required-type : org.apache.commons.validator.routines.UrlValidator converter-type : hudson.util.XStream2$BlacklistedTypesConverter path : /org.jenkinsci.plugins.rabbitmqconsumer.GlobalRabbitmqConfiguration/urlValidator line number : 3 -------------------------------

        Attachments

          Issue Links

            Activity

            dabev1 Pat Bevak created issue -
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Please provide a full stacktrace

            Show
            oleg_nenashev Oleg Nenashev added a comment - Please provide a full stacktrace
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Assignee Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            oleg_nenashev Oleg Nenashev made changes -
            Summary RabbitMQ Plugin broken by JEP-200 RabbitMQ Plugins broken by JEP-200
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I tried to reproduce the issue in Plugin Compat Tester, no failures in existing tests

            Show
            oleg_nenashev Oleg Nenashev added a comment - I tried to reproduce the issue in Plugin Compat Tester, no failures in existing tests
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I see the issue though

            Show
            oleg_nenashev Oleg Nenashev added a comment - I see the issue though
            Show
            oleg_nenashev Oleg Nenashev added a comment - Created https://github.com/jenkinsci/rabbitmq-consumer-plugin/pull/4
            oleg_nenashev Oleg Nenashev made changes -
            Remote Link This issue links to "https://github.com/jenkinsci/rabbitmq-consumer-plugin/pull/4 (Web Link)" [ 19923 ]
            oleg_nenashev Oleg Nenashev made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I do not see obvious issues in RabbitMQ Trigger though I didn't dig deep

            Show
            oleg_nenashev Oleg Nenashev added a comment - I do not see obvious issues in RabbitMQ Trigger though I didn't dig deep
            dabev1 Pat Bevak made changes -
            Attachment rmq_jenkins.txt [ 41197 ]
            Hide
            dabev1 Pat Bevak added a comment -

            That could be. I see them as going together, I wasn't sure which one the issue was in.

            Show
            dabev1 Pat Bevak added a comment - That could be. I see them as going together, I wasn't sure which one the issue was in.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Pat Bevak would you be able to verify the proposed PR on your instance?

            Show
            oleg_nenashev Oleg Nenashev added a comment - Pat Bevak would you be able to verify the proposed PR on your instance?
            Hide
            dabev1 Pat Bevak added a comment -

            Yes, I cloned, pull in your source, built the plugin (skipping javadoc since it had errors), installed plugin and it works. The consumer now will disappear and reappear based on my global configuration toggle for the consumer. Thanks for the quick fix!

            Show
            dabev1 Pat Bevak added a comment - Yes, I cloned, pull in your source, built the plugin (skipping javadoc since it had errors), installed plugin and it works. The consumer now will disappear and reappear based on my global configuration toggle for the consumer. Thanks for the quick fix!
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/96e0b0900d90ab93e982364eebecaca18f55b97c
            Log:
            JENKINS-49083 - Make the plugin buildable in PCT

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/96e0b0900d90ab93e982364eebecaca18f55b97c Log: JENKINS-49083 - Make the plugin buildable in PCT
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/test/java/org/jenkinsci/plugins/rabbitmqconsumer/GlobalRabbitmqConfigurationTest.java
            http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/e8cb4055e80d24f04fdb8c073cb5465cc5a7622b
            Log:
            JENKINS-49083 - Add a config roundtrip test

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/test/java/org/jenkinsci/plugins/rabbitmqconsumer/GlobalRabbitmqConfigurationTest.java http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/e8cb4055e80d24f04fdb8c073cb5465cc5a7622b Log: JENKINS-49083 - Add a config roundtrip test
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            Jenkinsfile
            http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/dd40d9a37f4c9af8035e0e4ef98d7a6dbf37924a
            Log:
            JENKINS-49083 - Add Jenkinsfile

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: Jenkinsfile http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/dd40d9a37f4c9af8035e0e4ef98d7a6dbf37924a Log: JENKINS-49083 - Add Jenkinsfile
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jenkinsci/plugins/rabbitmqconsumer/GlobalRabbitmqConfiguration.java
            http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/ac82aab58f44e9f90f872249bdde2c9468dcfcfe
            Log:
            JENKINS-49083 - make URL Validator a static field.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/rabbitmqconsumer/GlobalRabbitmqConfiguration.java http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/ac82aab58f44e9f90f872249bdde2c9468dcfcfe Log: JENKINS-49083 - make URL Validator a static field.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: rin_ne
            Path:
            Jenkinsfile
            pom.xml
            src/main/java/org/jenkinsci/plugins/rabbitmqconsumer/GlobalRabbitmqConfiguration.java
            src/main/java/org/jenkinsci/plugins/rabbitmqconsumer/extensions/ServerOperator.java
            src/test/java/org/jenkinsci/plugins/rabbitmqconsumer/GlobalRabbitmqConfigurationTest.java
            http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/cf6a6abf0312c2564af3da55ecfc193bfc449835
            Log:
            Merge pull request #4 from oleg-nenashev/JENKINS-49083-jep-200

            JENKINS-49083 - Make the plugin compatible with Jenkins 2.102+

            Compare: https://github.com/jenkinsci/rabbitmq-consumer-plugin/compare/a4e6ff2e1fc7...cf6a6abf0312

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rin_ne Path: Jenkinsfile pom.xml src/main/java/org/jenkinsci/plugins/rabbitmqconsumer/GlobalRabbitmqConfiguration.java src/main/java/org/jenkinsci/plugins/rabbitmqconsumer/extensions/ServerOperator.java src/test/java/org/jenkinsci/plugins/rabbitmqconsumer/GlobalRabbitmqConfigurationTest.java http://jenkins-ci.org/commit/rabbitmq-consumer-plugin/cf6a6abf0312c2564af3da55ecfc193bfc449835 Log: Merge pull request #4 from oleg-nenashev/ JENKINS-49083 -jep-200 JENKINS-49083 - Make the plugin compatible with Jenkins 2.102+ Compare: https://github.com/jenkinsci/rabbitmq-consumer-plugin/compare/a4e6ff2e1fc7...cf6a6abf0312
            rin_ne rin_ne made changes -
            Remote Link This issue links to "Page (Jenkins Wiki)" [ 19933 ]
            oleg_nenashev Oleg Nenashev made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            It has been released in 2.8

            Show
            oleg_nenashev Oleg Nenashev added a comment - It has been released in 2.8

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                dabev1 Pat Bevak
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: