Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49206

Jenkins Timer threads could get a bogus classLoader

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The Timer threads are lazily created by its executorService, so if an invocation to the Timer threads is made in a Thread context with a different contextClassloader than the default, the Timer thread will receive this contextClassloader.

      Noted when fixing an analogous error in the Pipeline Timeout utility https://github.com/jenkinsci/workflow-support-plugin/pull/53 Jesse Glick – that error caused a Groovy memory leak. 

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            core/src/main/java/hudson/util/ClassLoaderSanityThreadFactory.java
            core/src/main/java/jenkins/util/Timer.java
            core/src/test/java/jenkins/util/TimerTest.java
            http://jenkins-ci.org/commit/jenkins/2a6fc653ee7b13adde18515b21f7e6dc1200fa8a
            Log:
            Fix JENKINS-49206 by ensuring Timer threads get standard classloader (#3272)

            • Fix JENKINS-49206 by ensuring Timer threads get standard classloader
            • Refactor to better fit in with existing ThreadFactor utils
            • Fix javadocs
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: core/src/main/java/hudson/util/ClassLoaderSanityThreadFactory.java core/src/main/java/jenkins/util/Timer.java core/src/test/java/jenkins/util/TimerTest.java http://jenkins-ci.org/commit/jenkins/2a6fc653ee7b13adde18515b21f7e6dc1200fa8a Log: Fix JENKINS-49206 by ensuring Timer threads get standard classloader (#3272) Fix JENKINS-49206 by ensuring Timer threads get standard classloader Refactor to better fit in with existing ThreadFactor utils Fix javadocs
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            It has been released in Jenkins 2.105, so that it will become available in 2.107.1 LTS

            Show
            oleg_nenashev Oleg Nenashev added a comment - It has been released in Jenkins 2.105, so that it will become available in 2.107.1 LTS

              People

              • Assignee:
                svanoort Sam Van Oort
                Reporter:
                svanoort Sam Van Oort
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: