Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4957

Jabber server name doubled in build cause

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Component/s: jabber-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All

      Description

      The
      !build <job>
      command for the bot sets the build cause to
      Started by <hudson-id>@<domain>@<domain> on request of '<my-id>'

      (<my-id> on the other hand is not qualified with domain at all)

        Activity

        Hide
        kutzi kutzi added a comment -

        How do your Hudson bot's Jabber credentials look like? Did you enter something as <hudson-id>@<domain> as the Jabber-ID?
        If so, could you try to enter only <hudson-id> as the Jabber-ID?

        Regarding the <my-id> being without the domain: Would you prefer to have it with full domain name, too?

        Show
        kutzi kutzi added a comment - How do your Hudson bot's Jabber credentials look like? Did you enter something as <hudson-id>@<domain> as the Jabber-ID? If so, could you try to enter only <hudson-id> as the Jabber-ID? Regarding the <my-id> being without the domain: Would you prefer to have it with full domain name, too?
        Hide
        mdp mdp added a comment -

        Yes, the Jabber ID was set to <hudson-id>@<domain> like the help message suggested.
        After setting it to only <hudson-id> and setting the Server in Advanced settings the domain in build cause message is no longer repeated.

        Show
        mdp mdp added a comment - Yes, the Jabber ID was set to <hudson-id>@<domain> like the help message suggested. After setting it to only <hudson-id> and setting the Server in Advanced settings the domain in build cause message is no longer repeated.
        Hide
        mdp mdp added a comment -

        The <my-id> issue: I think that a full Jabber identifier should be used there too. An identifier without domain does not really identify the entity requesting the build.

        Show
        mdp mdp added a comment - The <my-id> issue: I think that a full Jabber identifier should be used there too. An identifier without domain does not really identify the entity requesting the build.
        Hide
        mdp mdp added a comment -

        Re <my-id>: although maybe there is no need to repeat the domain if it is the same as in the id used by the bot. But I don't know if it would not be confusing.

        Show
        mdp mdp added a comment - Re <my-id>: although maybe there is no need to repeat the domain if it is the same as in the id used by the bot. But I don't know if it would not be confusing.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in hudson
        User: : kutzi
        Path:
        trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java
        http://fisheye4.cenqua.com/changelog/hudson/?cs=24253
        Log:
        JENKINS-4957 don't append Jabber server name twice to build cause

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kutzi Path: trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java http://fisheye4.cenqua.com/changelog/hudson/?cs=24253 Log: JENKINS-4957 don't append Jabber server name twice to build cause
        Hide
        kutzi kutzi added a comment -

        Using the full Jabber-ID of the user in the build cause would need some changes to the bot command API.
        Currently, I've only the chatroom nick name there which could be even different from the 'username'.
        I've tracked this as issue: JENKINS-4970

        Show
        kutzi kutzi added a comment - Using the full Jabber-ID of the user in the build cause would need some changes to the bot command API. Currently, I've only the chatroom nick name there which could be even different from the 'username'. I've tracked this as issue: JENKINS-4970

          People

          • Assignee:
            kutzi kutzi
            Reporter:
            mdp mdp
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: