Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49618

Display Remoting version in the agent log when starting up the agent

    Details

    • Similar Issues:

      Description

      Currently Remoting agents do not print their versions to logs on the startup. Although there are plugins showing that on the Jenkins side (Version Column plugin, Support Core plugin), it would be still useful to print the version when the agent starts.

      Acceptance criteria:

      • Agent version is printed when the agent is connected to the master from CLI
      • Agent version is printed when the connection is established over SSH (e.g. by SSH Slaves plugin)
      • Agent version is printed when the agent is launched over Java Web Start

      In order to address these requirement, it is generally required to add log messaging in a generic Remoting class like Engine.

        Attachments

          Activity

          oleg_nenashev Oleg Nenashev created issue -
          Hide
          marti_ Willy Aguirre added a comment -

          Hi Oleg Nenashev, Could you tell me more how to I can fix this? please

          Show
          marti_ Willy Aguirre added a comment - Hi Oleg Nenashev , Could you tell me more how to I can fix this? please
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Willy Aguirre which information are you missing here?
          i think the best place to fix it is https://github.com/jenkinsci/remoting/blob/master/src/main/java/hudson/remoting/Engine.java#L234 , so maybe it could be a good pointer

          Show
          oleg_nenashev Oleg Nenashev added a comment - Willy Aguirre which information are you missing here? i think the best place to fix it is https://github.com/jenkinsci/remoting/blob/master/src/main/java/hudson/remoting/Engine.java#L234 , so maybe it could be a good pointer
          pvtuan10 Pham Vu Tuan made changes -
          Field Original Value New Value
          Assignee Vu Tuan Pham [ pvtuan10 ]
          Hide
          pvtuan10 Pham Vu Tuan added a comment - - edited

          Hi, I can work on this issue.

          Show
          pvtuan10 Pham Vu Tuan added a comment - - edited Hi, I can work on this issue.
          Hide
          pvtuan10 Pham Vu Tuan added a comment -

          I submitted a PR for this issue hereĀ https://github.com/jenkinsci/remoting/pull/262

          Show
          pvtuan10 Pham Vu Tuan added a comment - I submitted a PR for this issue hereĀ  https://github.com/jenkinsci/remoting/pull/262
          oleg_nenashev Oleg Nenashev made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          oleg_nenashev Oleg Nenashev made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Rebecca Ysteboe
          Path:
          src/main/java/hudson/remoting/Engine.java
          http://jenkins-ci.org/commit/remoting/9dd1cb5282642d13a230e265a756401e80b94c2f
          Log:
          Merge pull request #262 from pvtuan10/JENKINS-49618/display-agent-version

          JENKINS-49618 - Display Remoting version in the agent log when starting up the agent

          Compare: https://github.com/jenkinsci/remoting/compare/a4d2a3cb16be...9dd1cb528264

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rebecca Ysteboe Path: src/main/java/hudson/remoting/Engine.java http://jenkins-ci.org/commit/remoting/9dd1cb5282642d13a230e265a756401e80b94c2f Log: Merge pull request #262 from pvtuan10/ JENKINS-49618 /display-agent-version JENKINS-49618 - Display Remoting version in the agent log when starting up the agent Compare: https://github.com/jenkinsci/remoting/compare/a4d2a3cb16be...9dd1cb528264
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          client/pom.xml
          http://jenkins-ci.org/commit/swarm-plugin/c5a100cf94f6016d396a8d525554d1b8db416d07
          Log:
          [JENKINS-50237, JENKINS-49618] - Update Swarm Client to Remoting to 3.19

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: client/pom.xml http://jenkins-ci.org/commit/swarm-plugin/c5a100cf94f6016d396a8d525554d1b8db416d07 Log: [JENKINS-50237, JENKINS-49618] - Update Swarm Client to Remoting to 3.19
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          client/pom.xml
          http://jenkins-ci.org/commit/swarm-plugin/87b3a2da214df0976a31562fc74fb7d66b7628ae
          Log:
          Merge pull request #70 from oleg-nenashev/remoting/3.19

          [JENKINS-50237, JENKINS-49618] - Update Swarm Client to Remoting to 3.19

          Compare: https://github.com/jenkinsci/swarm-plugin/compare/1689dcfd8ff0...87b3a2da214d

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: client/pom.xml http://jenkins-ci.org/commit/swarm-plugin/87b3a2da214df0976a31562fc74fb7d66b7628ae Log: Merge pull request #70 from oleg-nenashev/remoting/3.19 [JENKINS-50237, JENKINS-49618] - Update Swarm Client to Remoting to 3.19 Compare: https://github.com/jenkinsci/swarm-plugin/compare/1689dcfd8ff0...87b3a2da214d
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/jenkins/52abfad941f1d4a33548b9d84e765be7d869e7ae
          Log:
          [JENKINS-50237, JENKINS-49618] - Update Jenkins Remoting to 3.19

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/jenkins/52abfad941f1d4a33548b9d84e765be7d869e7ae Log: [JENKINS-50237, JENKINS-49618] - Update Jenkins Remoting to 3.19
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/FilePath.java
          core/src/main/resources/jenkins/security/whitelisted-classes.txt
          pom.xml
          test/src/test/java/hudson/FilePathTest.java
          test/src/test/java/jenkins/security/s2m/DefaultFilePathFilterTest.java
          http://jenkins-ci.org/commit/jenkins/9e667a2f4fcd1d8f4c941c45d2118e190d5e905b
          Log:
          Merge pull request #3359 from jglick/ProxyException-JENKINS-50237

          [JENKINS-50237/JENKINS-49618] Pick up Remoting 3.19 with automatic ProxyException; and avoid BuildException to begin with

          Compare: https://github.com/jenkinsci/jenkins/compare/3b5c715ae0d0...9e667a2f4fcd

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/FilePath.java core/src/main/resources/jenkins/security/whitelisted-classes.txt pom.xml test/src/test/java/hudson/FilePathTest.java test/src/test/java/jenkins/security/s2m/DefaultFilePathFilterTest.java http://jenkins-ci.org/commit/jenkins/9e667a2f4fcd1d8f4c941c45d2118e190d5e905b Log: Merge pull request #3359 from jglick/ProxyException- JENKINS-50237 [JENKINS-50237/JENKINS-49618] Pick up Remoting 3.19 with automatic ProxyException; and avoid BuildException to begin with Compare: https://github.com/jenkinsci/jenkins/compare/3b5c715ae0d0...9e667a2f4fcd
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          It has been released in Remoting 3.19 and Jenkins 2.113. Thanks Pham Vu Tuan!

          Show
          oleg_nenashev Oleg Nenashev added a comment - It has been released in Remoting 3.19 and Jenkins 2.113. Thanks Pham Vu Tuan !
          oleg_nenashev Oleg Nenashev made changes -
          Status In Review [ 10005 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              pvtuan10 Pham Vu Tuan
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: