Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49699

Doktor plugin affected by JEP-200

    Details

    • Similar Issues:

      Description

      Doktor plugin is affected by JEP-200 :

      I use the step doktor and in the log there is this message :
      java.util.concurrent.ExecutionException: java.lang.SecurityException: Rejected: kotlin.collections.EmptyList; see https://jenkins.io/redirect/class-filter/
      and in catalina.out :

      AVERTISSEMENT: org.jgrapht.DirectedGraph in file:/data/jenkins/plugins/build-flow-plugin/WEB-INF/lib/jgrapht-jdk1.5-0.7.3.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/
      févr. 22, 2018 5:44:17 PM jenkins.security.ClassFilterImpl lambda$isBlacklisted$1
      AVERTISSEMENT: kotlin.collections.EmptyList in file:/data/jenkins/plugins/doktor/WEB-INF/lib/kotlin-stdlib-1.1.51.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/

        Attachments

          Issue Links

            Activity

            Hide
            casz Joseph Petersen added a comment -

            Just released kotlin-v1-stdlib-jdk8 which has the "kotlin.collections.EmptyList" as the initial classFilter

            Going to suggest a PR at doktor

            Show
            casz Joseph Petersen added a comment - Just released kotlin-v1-stdlib-jdk8 which has the "kotlin.collections.EmptyList" as the initial classFilter Going to suggest a PR at doktor
            Hide
            madhead Siarhei Krukau added a comment -

            Oleg Nenashev I've tested this change: https://github.com/madhead/doktor/commit/d00e3f24d1b1be92391f3983405b58345b514135 and it seems to be working. I mean, listing those classes in META-INF/hudson.remoting.ClassFilter was enough. I have not seen any warnings about kotlin.collections.EmptyList.

            Joseph Petersen, Oleg Nenashev I decided not to depend on other plugins. This forces me to use pluginFirstClassLoader is this a bad practice or not? I've seen no issues with it.

            Show
            madhead Siarhei Krukau added a comment - Oleg Nenashev I've tested this change: https://github.com/madhead/doktor/commit/d00e3f24d1b1be92391f3983405b58345b514135 and it seems to be working. I mean, listing those classes in META-INF/hudson.remoting.ClassFilter was enough. I have not seen any warnings about kotlin.collections.EmptyList . Joseph Petersen , Oleg Nenashev I decided not to depend on other plugins. This forces me to use pluginFirstClassLoader is this a bad practice or not? I've seen no issues with it.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            usage of pluginFirstClassLoader is a really bad practice, because you may corrupt other plugins if they use higher dependency versions. I would advice to use the plugin or shade the libraries

            Show
            oleg_nenashev Oleg Nenashev added a comment - usage of pluginFirstClassLoader is a really bad practice, because you may corrupt other plugins if they use higher dependency versions. I would advice to use the plugin or shade the libraries
            Hide
            madhead Siarhei Krukau added a comment -

            I couldn't do that because of AsciidoctorJ library / JRuby runtime that fails, if I am not using this setting. Though, I didn't dig that a lot.

            Show
            madhead Siarhei Krukau added a comment - I couldn't do that because of AsciidoctorJ library / JRuby runtime that fails, if I am not using this setting. Though, I didn't dig that a lot.
            Hide
            christian Christian Kipping added a comment -

            So it is no longer possible to use this plugin?

            Show
            christian Christian Kipping added a comment - So it is no longer possible to use this plugin?

              People

              • Assignee:
                madhead Siarhei Krukau
                Reporter:
                laurent_dufour Laurent Dufour
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: