Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49713

gerrit-plugin exposes change-requests as normal branches instead of pull-requests

    Details

    • Similar Issues:
    • Released As:
      gerrit-code-review-0.2

      Description

      It seems that when using gerrit-plugin in combination with multibranch-pipelines, we get all discovered branches as normal branches instead of having them split between real-branches and temporary ones (pull-requests).

      I am attaching screenshots of a sample github repository and a gerrit sample repository, so it is clearly visible that multibranch-pipeline does treat CRs as branches instead of PRs (they are not displayed in their separated tab).

      This is also likely to affect the Blue Ocean gui too and it may be a real deal for users that do have lots of production branches and open pull requests. I know for sure that having 5-10 production branches and 5-50 open CRs is not uncommon.

      Another issue spotted here is that the patchset version is included in the branch name, which is a real issue because it means that a Jenkins will create a new temporary branch for each updated changeset, instead of using a single one with multiple builds. Having the build history in one place is key as it allows users (and reviewers) to see how execution changed in time.

        Attachments

          Activity

          Hide
          lucamilanesio Luca Domenico Milanesio added a comment -

          It was a bit tricky, but I've managed to introduce the new 'Changes' category:

          https://github.com/jenkinsci/gerrit-code-review-plugin/pull/18

          More work will follow to make the branch name more "readable"

          Show
          lucamilanesio Luca Domenico Milanesio added a comment - It was a bit tricky, but I've managed to introduce the new 'Changes' category: https://github.com/jenkinsci/gerrit-code-review-plugin/pull/18 More work will follow to make the branch name more "readable"

            People

            • Assignee:
              lucamilanesio Luca Domenico Milanesio
              Reporter:
              ssbarnea Sorin Sbarnea
            • Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: