Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49737

Extras Executable WAR should warn everybody that Java 9 is not supported

    Details

    • Similar Issues:

      Description

      Currently Jenkins does not support Java 9, but Extras Executable WAR does not warn about that: https://github.com/jenkinsci/extras-executable-war/blob/49322726d410fac8aa0b5cb7b00934e62f3b89e3/src/main/java/Main.java#L118-L138

      It would be great to add Java 9 check there and to at least print the warning. Maybe it's better to just fail fast.

        Attachments

          Issue Links

            Activity

            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Epic Link JENKINS-40689 [ 177392 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels newbie-friendly
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Actually it is a newbie-friendly ticket.
            Anybody is welcome to take and implement it.

            Show
            oleg_nenashev Oleg Nenashev added a comment - Actually it is a newbie-friendly ticket. Anybody is welcome to take and implement it.
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Component/s core [ 15593 ]
            Hide
            amit_magar Amit Magar added a comment - - edited

            Hi Oleg,

            I want to ask you if you want just print an error message stating "Jenkins does not support Java 9", Or want to throw error and print error message(capture this event in a log file). ?

            Thanks,
            Amit

            Show
            amit_magar Amit Magar added a comment - - edited Hi Oleg, I want to ask you if you want just print an error message stating "Jenkins does not support Java 9", Or want to throw error and print error message(capture this event in a log file). ? Thanks, Amit
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            For starters I would suggest to use the same logic as the service uses for Java 7 and older. If you are interested to improve logging, you are more than welcome to do that

            Show
            oleg_nenashev Oleg Nenashev added a comment - For starters I would suggest to use the same logic as the service uses for Java 7 and older. If you are interested to improve logging, you are more than welcome to do that
            amit_magar Amit Magar made changes -
            Assignee Amit Magar [ amit_magar ]
            Hide
            amit_magar Amit Magar added a comment -

            Hi Oleg,

            I have simply followed the same logic which was followed for Java 7 or older. Should I submit the pull request for this ?

            Thanks,
            Amit

            Show
            amit_magar Amit Magar added a comment - Hi Oleg, I have simply followed the same logic which was followed for Java 7 or older. Should I submit the pull request for this ? Thanks, Amit
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            yes, we handle all change proposals via pull requests

            Show
            oleg_nenashev Oleg Nenashev added a comment - yes, we handle all change proposals via pull requests
            Hide
            amit_magar Amit Magar added a comment -

            Hi Oleg,

            I have created the pull request, Could you review it?

            Thanks,
            Amit

            Show
            amit_magar Amit Magar added a comment - Hi Oleg, I have created the pull request, Could you review it? Thanks, Amit
            amit_magar Amit Magar made changes -
            Assignee Amit Magar [ amit_magar ] Oleg Nenashev [ oleg_nenashev ]
            amit_magar Amit Magar made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ] Amit Magar [ amit_magar ]
            oleg_nenashev Oleg Nenashev made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            oleg_nenashev Oleg Nenashev made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            oleg_nenashev Oleg Nenashev made changes -
            Remote Link This issue links to "https://github.com/jenkinsci/extras-executable-war/pull/14 (Web Link)" [ 20204 ]
            Hide
            amit_magar Amit Magar added a comment -

            Hi Oleg,

            Thanks for your input. I made the requested changes.

            Amit

            Show
            amit_magar Amit Magar added a comment - Hi Oleg, Thanks for your input. I made the requested changes. Amit
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Amit Jagannath Magar
            Path:
            src/main/java/Main.java
            http://jenkins-ci.org/commit/extras-executable-war/9cf9059c509ce73112d40f50269cf39d626f70c6
            Log:
            JENKINS-49737 - Issue(Print error to Java Version 9) (#14)

            • Revert "[maven-release-plugin] prepare for next development iteration"

            This reverts commit 105703afd80d7e7e106e33372c3cbdca4ce34f2d.

            • Delete org.eclipse.jdt.core.prefs

            Deleting the eclipse files

            • Delete org.eclipse.m2e.core.prefs
            • Delete .classpath
            • Delete .project

            Deleting the Eclipse File

            • Update pom.xml

            Reverting to Orignal POM.xml from source repo

            • Making Requested Changes

            Changed comparison to exact java version and changed error message

            • Removed Comment

            Removed comment

            • Fix the code to finally merge it
            • Add space to expected Java version as @batmat suggested
            • Remove extra spaces to trigger CI
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Amit Jagannath Magar Path: src/main/java/Main.java http://jenkins-ci.org/commit/extras-executable-war/9cf9059c509ce73112d40f50269cf39d626f70c6 Log: JENKINS-49737 - Issue(Print error to Java Version 9) (#14) Solving JENKINS-49737 Issue(Print error to Java Version 9) Revert " [maven-release-plugin] prepare for next development iteration" This reverts commit 105703afd80d7e7e106e33372c3cbdca4ce34f2d. Delete org.eclipse.jdt.core.prefs Deleting the eclipse files Delete org.eclipse.m2e.core.prefs Delete .classpath Delete .project Deleting the Eclipse File Update pom.xml Reverting to Orignal POM.xml from source repo Making Requested Changes Changed comparison to exact java version and changed error message Removed Comment Removed comment Fix the code to finally merge it Add space to expected Java version as @batmat suggested Remove extra spaces to trigger CI
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            war/pom.xml
            http://jenkins-ci.org/commit/jenkins/fa54b49f3281d5e0a0bf2d7c64e417a3158bd6a8
            Log:
            JENKINS-49737 - Update Extras Executable WAR to 1.38 (#3336)

            • Use the released version of Extras Executable War 1.38
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: war/pom.xml http://jenkins-ci.org/commit/jenkins/fa54b49f3281d5e0a0bf2d7c64e417a3158bd6a8 Log: JENKINS-49737 - Update Extras Executable WAR to 1.38 (#3336) JENKINS-49737 - Update Extras Executable WAR to 1.38 Use the released version of Extras Executable War 1.38
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The patch has been integrated towards 2.111

            Show
            oleg_nenashev Oleg Nenashev added a comment - The patch has been integrated towards 2.111
            oleg_nenashev Oleg Nenashev made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            danielbeck Daniel Beck made changes -
            Labels newbie-friendly lts-candidate newbie-friendly
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            war/pom.xml
            http://jenkins-ci.org/commit/jenkins/f513419c76ab6d81f95ed66c0d90f98686783b52
            Log:
            JENKINS-49737 - Update Extras Executable WAR to 1.38 (#3336)

            • Use the released version of Extras Executable War 1.38

            (cherry picked from commit fa54b49f3281d5e0a0bf2d7c64e417a3158bd6a8)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: war/pom.xml http://jenkins-ci.org/commit/jenkins/f513419c76ab6d81f95ed66c0d90f98686783b52 Log: JENKINS-49737 - Update Extras Executable WAR to 1.38 (#3336) JENKINS-49737 - Update Extras Executable WAR to 1.38 Use the released version of Extras Executable War 1.38 (cherry picked from commit fa54b49f3281d5e0a0bf2d7c64e417a3158bd6a8)
            danielbeck Daniel Beck made changes -
            Labels lts-candidate newbie-friendly 2.107.2-fixed newbie-friendly
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue relates to JENKINS-51155 [ JENKINS-51155 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels 2.107.2-fixed newbie-friendly 2.107.2-fixed java11 newbie-friendly

              People

              • Assignee:
                amit_magar Amit Magar
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: