Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49945

PR matching regex can never match strategies

    Details

    • Similar Issues:

      Description

      https://github.com/jenkinsci/github-branch-source-plugin/blob/d60cc7617ee9ad56fd3ea3a3c3ad2569dc07c827/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L1163

      the regex "^PR-(
      d+)(.)?$"
      includes {} in the second matching group which means PR-11-HEAD will never match the strategy of HEAD as the second matching group includes the {}. Just need to do something like "^PR(
      d+)(:?-(.
      ))?$" (if I can remember my regex for non-matching groups correctly)

        Attachments

          Issue Links

            Activity

            stephenconnolly Stephen Connolly created issue -
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/8293288381f909034e1f754da69fe57afdb5cd94
            Log:
            Merge pull request #178 from stephenc/more-logging

            [FIXED JENKINS-49945] Fix regex and add some logging to help diagnose issues in resolve(thingName,listener)

            Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/d60cc7617ee9...8293288381f9

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/8293288381f909034e1f754da69fe57afdb5cd94 Log: Merge pull request #178 from stephenc/more-logging [FIXED JENKINS-49945] Fix regex and add some logging to help diagnose issues in resolve(thingName,listener) Compare: https://github.com/jenkinsci/github-branch-source-plugin/compare/d60cc7617ee9...8293288381f9
            scm_issue_link SCM/JIRA link daemon made changes -
            Field Original Value New Value
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "Page (Jenkins Wiki)" [ 20259 ]

              People

              • Assignee:
                rsandell rsandell
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: