Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49961

NPE from CpsFlowExecution.saveOwner

    Details

    • Similar Issues:

      Description

      Trunk build of Jenkins, latest plugins:

      java.lang.NullPointerException
      	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.saveOwner(CpsFlowExecution.java:1754)
      	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.setResumeBlocked(CpsFlowExecution.java:348)
      	at org.jenkinsci.plugins.workflow.job.WorkflowRun.onLoad(WorkflowRun.java:633)
      	at ...
      

      after restarting when there was a build of a project which I marked not for resumption.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            The code seems wrong. WorkflowRun.onLoad sets the owner after calling setResumeBlocked. So of course it will throw an exception.

            Show
            jglick Jesse Glick added a comment - The code seems wrong. WorkflowRun.onLoad sets the owner   after calling setResumeBlocked . So of course it will throw an exception.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/FlowDurabilityTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/0ebe94916353f873715c06b642fb744969f1db0c
            Log:
            Fix JENKINS-49961 by avoiding an unsafe save operation when toggling ResumeEnabled if the FlowExecutionOwner is not yet set

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java src/test/java/org/jenkinsci/plugins/workflow/cps/FlowDurabilityTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/0ebe94916353f873715c06b642fb744969f1db0c Log: Fix JENKINS-49961 by avoiding an unsafe save operation when toggling ResumeEnabled if the FlowExecutionOwner is not yet set
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/FlowDurabilityTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/a63e6848d642b65f21e32ea7d15a8a853de8761a
            Log:
            Merge pull request #210 from svanoort/fix-JENKINS-49961

            Fix JENKINS-49961 by avoiding an unsafe save operation when toggling ResumeEnabled if the FlowExecutionOwner is not yet set

            Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/78b137d8743e...a63e6848d642

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java src/test/java/org/jenkinsci/plugins/workflow/cps/FlowDurabilityTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/a63e6848d642b65f21e32ea7d15a8a853de8761a Log: Merge pull request #210 from svanoort/fix- JENKINS-49961 Fix JENKINS-49961 by avoiding an unsafe save operation when toggling ResumeEnabled if the FlowExecutionOwner is not yet set Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/78b137d8743e...a63e6848d642
            Hide
            abayer Andrew Bayer added a comment -

            Merged, will be in upcoming workflow-cps 2.46.

            Show
            abayer Andrew Bayer added a comment - Merged, will be in upcoming workflow-cps 2.46.

              People

              • Assignee:
                svanoort Sam Van Oort
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: