Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49977

Deserialization of hudson.model.ParametersDefinitionProperty$1

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Duplicate
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      (Triggered via JENKINS-49573 comment conversation)

      After upgrading to Jenkins 2.110 and actually presumably JENKINS-49795 I saw the following warning logs:

      2018-03-07 11:39:38 WARNING [jenkins.security.ClassFilterImpl lambda$isBlacklisted$1]   JENKINS-49573: attempt to (de-)serialize anonymous class hudson.model.ParametersDefinitionProperty$1 in file:/var/cache/jenkins/war/WEB-INF/lib/jenkins-core-2.110.jar
      

        Attachments

          Issue Links

            Activity

            reinholdfuereder Reinhold Füreder created issue -
            reinholdfuereder Reinhold Füreder made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-49573 [ JENKINS-49573 ]
            Hide
            reinholdfuereder Reinhold Füreder added a comment -

            (Updating cloned issue, maybe I should not have used cloning in the first place?)

            Show
            reinholdfuereder Reinhold Füreder added a comment - (Updating cloned issue, maybe I should not have used cloning in the first place?)
            reinholdfuereder Reinhold Füreder made changes -
            Summary CLONE - Bad serialization of hudson.model.ParametersDefinitionProperty Bad serialization of hudson.model.ParametersDefinitionProperty
            Description (Triggered via JENKINS-49573 comment conversation)

            After upgrading to Jenkins 2.110 and actually presumably JENKINS-49795 I saw the following warning logs:
            {noformat}
            2018-03-07 11:39:37 WARNING [jenkins.security.ClassFilterImpl lambda$isBlacklisted$1] JENKINS-49573: attempt to (de-)serialize anonymous class org.jenkinsci.plugins.pipeline.modeldefinition.ast.ModelASTValue$1 in file:/var/lib/jenkins/plugins/pipeline-model-api/WEB-INF/lib/pipeline-model-api.jar
            2018-03-07 11:39:37 WARNING [jenkins.security.ClassFilterImpl lambda$isBlacklisted$1] JENKINS-49573: attempt to (de-)serialize anonymous class org.jenkinsci.plugins.pipeline.modeldefinition.ast.ModelASTValue$2 in file:/var/lib/jenkins/plugins/pipeline-model-api/WEB-INF/lib/pipeline-model-api.jar
            {noformat}
            (Triggered via JENKINS-49573 comment conversation)

            After upgrading to Jenkins 2.110 and actually presumably JENKINS-49795 I saw the following warning logs:
            {noformat}
            2018-03-07 11:39:38 WARNING [jenkins.security.ClassFilterImpl lambda$isBlacklisted$1] JENKINS-49573: attempt to (de-)serialize anonymous class hudson.model.ParametersDefinitionProperty$1 in file:/var/cache/jenkins/war/WEB-INF/lib/jenkins-core-2.110.jar
            {noformat}
            abayer Andrew Bayer made changes -
            Component/s core [ 15593 ]
            Component/s pipeline-model-definition-plugin [ 21706 ]
            Assignee Andrew Bayer [ abayer ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue relates to JENKINS-49795 [ JENKINS-49795 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-49573 [ JENKINS-49573 ]
            Hide
            jglick Jesse Glick added a comment -

            Jenkins 2.110+ will no longer save this class name for new builds. Historical build records may continue to refer to it. I suppose ParametersAction.readResolve could replace the list with an ArrayList but this does not suffice to trigger a resave; Jenkins currently offers no API for an object’s readResolve to request a save of the top-level object being loaded from XmlFile.

            Just a warning; probably could be closed as Won’t Fix.

            Show
            jglick Jesse Glick added a comment - Jenkins 2.110+ will no longer save this class name for new builds. Historical build records may continue to refer to it. I suppose ParametersAction.readResolve could replace the list with an ArrayList but this does not suffice to trigger a resave; Jenkins currently offers no API for an object’s readResolve to request a save of the top-level object being loaded from XmlFile . Just a warning; probably could be closed as Won’t Fix.
            jglick Jesse Glick made changes -
            Priority Critical [ 2 ] Minor [ 4 ]
            jglick Jesse Glick made changes -
            Labels JEP-200
            Hide
            jglick Jesse Glick added a comment -

            And not a JEP-200 issue per se. JENKINS-49705 was a robustness improvement merely inspired by debugging a JEP-200 regression.

            Show
            jglick Jesse Glick added a comment - And not a JEP-200 issue per se. JENKINS-49705 was a robustness improvement merely inspired by debugging a JEP-200 regression.
            jglick Jesse Glick made changes -
            Summary Bad serialization of hudson.model.ParametersDefinitionProperty Deserialization of hudson.model.ParametersDefinitionProperty$1
            Hide
            reinholdfuereder Reinhold Füreder added a comment -

            Since I still get this warning:

            2018-04-04 12:26:59 WARNING [org.jenkinsci.remoting.util.AnonymousClassWarnings warn]   Attempt to (de-)serialize anonymous class hudson.model.ParametersDefinitionProperty$1 in file:/var/cache/jenkins/war/WEB-INF/lib/jenkins-core-2.114.jar; see: https://jenkins.io/redirect/serialization-of-anonymous-classes/
            

            Is that OK?
            Or when is it still expected to pop up (e.g. solely due to looking at pipeline job in classic UI via stage view for instance)?

            Show
            reinholdfuereder Reinhold Füreder added a comment - Since I still get this warning: 2018-04-04 12:26:59 WARNING [org.jenkinsci.remoting.util.AnonymousClassWarnings warn] Attempt to (de-)serialize anonymous class hudson.model.ParametersDefinitionProperty$1 in file:/var/cache/jenkins/war/WEB-INF/lib/jenkins-core-2.114.jar; see: https://jenkins.io/redirect/serialization-of-anonymous-classes/ Is that OK? Or when is it still expected to pop up (e.g. solely due to looking at pipeline job in classic UI via stage view for instance)?
            jsoref Josh Soref made changes -
            Link This issue duplicates JENKINS-50457 [ JENKINS-50457 ]
            jsoref Josh Soref made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Duplicate [ 3 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                reinholdfuereder Reinhold Füreder
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: