Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-49987

Cleanup anonymous class usages for Remoting in Jenkins Core, Remoting and Modules

    XMLWordPrintable

    Details

    • Epic Name:
      Cleanup anonymous class usages for Remoting in Jenkins Core, Remoting and Modules
    • Similar Issues:
    • Released As:
      Remoting 3.28

      Description

      After adding extra diagnostics for cases like JENKINS-49795, there will be warning reports about anonymous classes being serialized over Remoting. Somebody needs to cleanup these usages.

      Examples:

        Attachments

          Issue Links

            Activity

            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Link This issue relates to JENKINS-49795 [ JENKINS-49795 ]
            oleg_nenashev Oleg Nenashev made changes -
            Description After adding extra diagnostics for cases like JENKINS-49795, there will be warning reports about anonymous classes being serialized over Remoting. Somebody needs to cleanup these usages.

            Examples:

            * https://github.com/jenkinsci/jenkins/search?utf8=%E2%9C%93&q=%22new+MasterToSlaveCallable%22&type=
            * https://github.com/jenkinsci/remoting/blob/9b8fd56e780f0c042c8ac35333e87faba8c5f81f/src/main/java/hudson/remoting/forward/PortForwarder.java#L135
            * ...
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels diagnostics serialization
            jglick Jesse Glick made changes -
            Epic Child JENKINS-49994 [ 188991 ]
            jglick Jesse Glick made changes -
            Comment [ Note that currently the diagnostic lives in {{ClassFilterImpl}} in core, so it will apply to all XStream usages, but only to _inbound_ Remoting commands. Probably it should be moved to {{ClassFilter.STANDARD}} so that we would find instances of the much more common case of _outbound_ Remoting callables using anonymous inner classes. ]
            jthompson Jeff Thompson made changes -
            Assignee Jeff Thompson [ jthompson ]
            jthompson Jeff Thompson made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Released As Remoting 3.28

              People

              • Assignee:
                jthompson Jeff Thompson
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: