Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50211

Add an option to optionally reject connections from agents with unsupported Remoting versions

    Details

    • Similar Issues:

      Description

      It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

      Acceptance criteria:

      • There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
      • There is a checkbox in the configuration, which turns on rejection of unsupported versions
      • SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
      • Nice2have: Automatic test which confirms that the flag survives restarts
      • Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect. See examples in https://github.com/jenkinsci/jenkins/blob/master/test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java

        Attachments

          Issue Links

            Activity

            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Link This issue relates to JENKINS-48766 [ JENKINS-48766 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue relates to JENKINS-44100 [ JENKINS-44100 ]
            oleg_nenashev Oleg Nenashev made changes -
            Description It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

            Acceptance criteria:

            * There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
            * There is a checkbox in the configuration, which turns on rejection of unsupported versions
            * SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection

            It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

            Acceptance criteria:

            * There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
            * There is a checkbox in the configuration, which turns on rejection of unsupported versions
            * SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
            * Nice2have: Automatic test which confirms that the flag survives restarts
            * Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect

            oleg_nenashev Oleg Nenashev made changes -
            Issue Type Bug [ 1 ] New Feature [ 2 ]
            oleg_nenashev Oleg Nenashev made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            oleg_nenashev Oleg Nenashev made changes -
            Description It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

            Acceptance criteria:

            * There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
            * There is a checkbox in the configuration, which turns on rejection of unsupported versions
            * SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
            * Nice2have: Automatic test which confirms that the flag survives restarts
            * Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect

            It is a follow-up to JENKINS-48766. That story adds warnings for unsupported agent versions, but it actually does not reject them. It would be useful to have such feature in the core or in Version Column Plugin. Core is preferable though this feature may be detached to a plugin later as a part of JENKINS-44100.

            Acceptance criteria:

            * There is a Global Configuration entry for Remoting. An existing section for Remoting protocols may be used
            * There is a checkbox in the configuration, which turns on rejection of unsupported versions
            * SlaveComputer#setChannel() checks the option status. Depending on it, it may either accept or reject the connection
            * Nice2have: Automatic test which confirms that the flag survives restarts
            * Nice2have: Automatic test which picks unsupported version of Remoting and confirms that it cannot connect. See examples in https://github.com/jenkinsci/jenkins/blob/master/test/src/test/java/jenkins/slaves/OldRemotingAgentTest.java

            gautamabhishek46 Abhishek Gautam made changes -
            Assignee Abhishek Gautam [ gautamabhishek46 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels remoting newbie-friendly remoting
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            There is a stalled pull request from Abhishek Gautam: https://github.com/jenkinsci/jenkins/pull/3353 . It would be great to get it over the line 

            Show
            oleg_nenashev Oleg Nenashev added a comment - There is a stalled pull request from Abhishek Gautam : https://github.com/jenkinsci/jenkins/pull/3353  . It would be great to get it over the line 
            oleg_nenashev Oleg Nenashev made changes -
            Remote Link This issue links to "Stalled PR - 3353 (Web Link)" [ 22314 ]
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Abhishek Gautam [ gautamabhishek46 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels newbie-friendly remoting newbie-friendly remoting stalled-pr
            stellargo stellargo made changes -
            Assignee Sumit Sarin [ stellargo ]
            stellargo stellargo made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            stellargo stellargo made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]

              People

              • Assignee:
                stellargo stellargo
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: