Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50598

Add support of running JTH with custom WAR

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I am experimenting with running PCT with WARs generated by Custom WAR Packager. I would like to be able to run JTH and PCT tests against WARs instead of the dependency-based mechanism. It would allow to support things like auto-configuration of WARs which is offered by WAR packager.

        Attachments

          Issue Links

            Activity

            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Assignee Oliver Gondža [ olivergondza ] Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue relates to JENKINS-50540 [ JENKINS-50540 ]
            oleg_nenashev Oleg Nenashev made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            oleg_nenashev Oleg Nenashev made changes -
            Remote Link This issue links to "https://github.com/jenkinsci/jenkins-test-harness/pull/99 (Web Link)" [ 20379 ]
            Hide
            olivergondza Oliver Gondža added a comment -

            Will we ever benefit from the ability to test against wars except for Custom WAR Packager testing?

            Show
            olivergondza Oliver Gondža added a comment - Will we ever benefit from the ability to test against wars except for Custom WAR Packager testing?
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Oliver Gondža I am not sure I get your question.
            During JEP-200 testing in Dec/Jan I have applied many patches to Plugin Compat Tester (JENKINS-48734), and currently it works well for stock Jenkins WARs (released and unreleased ones)

            I also bumped your thread in https://groups.google.com/forum/#!searchin/jenkinsci-dev/plugin$20compat$20tester%7Csort:date/jenkinsci-dev/jPiDzfWmMyw/ZP0SBz1oCgAJ about PCT this winter

            Show
            oleg_nenashev Oleg Nenashev added a comment - Oliver Gondža I am not sure I get your question. During JEP-200 testing in Dec/Jan I have applied many patches to Plugin Compat Tester ( JENKINS-48734 ), and currently it works well for stock Jenkins WARs (released and unreleased ones) I also bumped your thread in https://groups.google.com/forum/#!searchin/jenkinsci-dev/plugin$20compat$20tester%7Csort:date/jenkinsci-dev/jPiDzfWmMyw/ZP0SBz1oCgAJ about PCT this winter
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            PCT documentation is also in place now: https://github.com/jenkinsci/plugin-compat-tester

            Show
            oleg_nenashev Oleg Nenashev added a comment - PCT documentation is also in place now: https://github.com/jenkinsci/plugin-compat-tester
            Hide
            olivergondza Oliver Gondža added a comment -

            What I meant is if the change proposed here is to support the experiment/adoption of the Custom WAR Packager or if there are any other benefits for traditional JTH against core / plugins that has some old problems originating from different dependency handling.

            Show
            olivergondza Oliver Gondža added a comment - What I meant is if the change proposed here is to support the experiment/adoption of the Custom WAR Packager or if there are any other benefits for traditional JTH against core / plugins that has some old problems originating from different dependency handling.
            oleg_nenashev Oleg Nenashev made changes -
            Epic Link JENKINS-50627 [ 189704 ]
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Oliver Gondža In the current state I doubt there will be benefit for traditional flows. "Custom WAR packager" enables JTH testing with Bundled plugins/groovy scripts and offers fixes for some issues there (e.g. resolves conflicts between bundled plugins and test dependencies).

            So far I do not see ho these patches could help classic flows which do not bundle plugins or scripts. The proposed patches could be applied to detached plugins, probably.

            Show
            oleg_nenashev Oleg Nenashev added a comment - Oliver Gondža In the current state I doubt there will be benefit for traditional flows. "Custom WAR packager" enables JTH testing with Bundled plugins/groovy scripts and offers fixes for some issues there (e.g. resolves conflicts between bundled plugins and test dependencies). So far I do not see ho these patches could help classic flows which do not bundle plugins or scripts. The proposed patches could be applied to detached plugins, probably.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jvnet/hudson/test/WarExploder.java
            http://jenkins-ci.org/commit/jenkins-test-harness/e158a39e21f6992617c061b9655c7212a5d7df80
            Log:
            JENKINS-50598 - Add support of passing custom WAR file in WAR exploder using system property

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/e158a39e21f6992617c061b9655c7212a5d7df80 Log: JENKINS-50598 - Add support of passing custom WAR file in WAR exploder using system property
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jvnet/hudson/test/WarExploder.java
            http://jenkins-ci.org/commit/jenkins-test-harness/0ab49c3a6b29268524f492c8faf3cdd20e53f91f
            Log:
            JENKINS-50598 - File type check causes issues in jenkins/pct Docker image when a WAR is passed from volume

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/0ab49c3a6b29268524f492c8faf3cdd20e53f91f Log: JENKINS-50598 - File type check causes issues in jenkins/pct Docker image when a WAR is passed from volume
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jvnet/hudson/test/WarExploder.java
            http://jenkins-ci.org/commit/jenkins-test-harness/282dbfe4031857db549092ba8346dc5c8ee6da3e
            Log:
            Revert "JENKINS-50598 - File type check causes issues in jenkins/pct Docker image when a WAR is passed from volume"

            This reverts commit 0ab49c3a6b29268524f492c8faf3cdd20e53f91f.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/282dbfe4031857db549092ba8346dc5c8ee6da3e Log: Revert " JENKINS-50598 - File type check causes issues in jenkins/pct Docker image when a WAR is passed from volume" This reverts commit 0ab49c3a6b29268524f492c8faf3cdd20e53f91f.
            jglick Jesse Glick made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jvnet/hudson/test/WarExploder.java
            http://jenkins-ci.org/commit/jenkins-test-harness/113e3994aee5c21b77e095dd413313e8ca3ef38c
            Log:
            JENKINS-50598 - Adjust the error message text as suggested by @jglick

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/113e3994aee5c21b77e095dd413313e8ca3ef38c Log: JENKINS-50598 - Adjust the error message text as suggested by @jglick
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jvnet/hudson/test/WarExploder.java
            http://jenkins-ci.org/commit/jenkins-test-harness/65d4d94d977d4dedf716a648dbdebf6d3b221b59
            Log:
            Merge pull request #100 from oleg-nenashev/JENKINS-50598-war-option

            JENKINS-50598 - Add support of passing custom WAR file in WAR exploder using system property

            Compare: https://github.com/jenkinsci/jenkins-test-harness/compare/23e497bfa9d7...65d4d94d977d

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/65d4d94d977d4dedf716a648dbdebf6d3b221b59 Log: Merge pull request #100 from oleg-nenashev/ JENKINS-50598 -war-option JENKINS-50598 - Add support of passing custom WAR file in WAR exploder using system property Compare: https://github.com/jenkinsci/jenkins-test-harness/compare/23e497bfa9d7...65d4d94d977d
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/plugin-pom/45c3ffaa5eceddc25ffdf0eab7850ac34c902701
            Log:
            [JENKINS-50598,JENKINS-50590] - Update JTH to 2.38

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/plugin-pom/45c3ffaa5eceddc25ffdf0eab7850ac34c902701 Log: [JENKINS-50598,JENKINS-50590] - Update JTH to 2.38
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/plugin-pom/539cbe295a6782f6cde65cdf7962e6dbb07defb1
            Log:
            Merge pull request #102 from oleg-nenashev/jth/2.38

            [JENKINS-50598,JENKINS-50590] - Update JTH to 2.38

            Compare: https://github.com/jenkinsci/plugin-pom/compare/624a61e2d84b...539cbe295a67

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/plugin-pom/539cbe295a6782f6cde65cdf7962e6dbb07defb1 Log: Merge pull request #102 from oleg-nenashev/jth/2.38 [JENKINS-50598,JENKINS-50590] - Update JTH to 2.38 Compare: https://github.com/jenkinsci/plugin-pom/compare/624a61e2d84b...539cbe295a67

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: