Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50682

Error when selecting when / changeRequest or tag in the Directive Generator

    Details

    • Similar Issues:

      Description

      No idea what's going on here :shrug:

        Attachments

          Issue Links

            Activity

            Hide
            abayer Andrew Bayer added a comment -

            tag barfs too, but you have to open the "Advanced" options to get it to do so.

            Show
            abayer Andrew Bayer added a comment - tag barfs too, but you have to open the "Advanced" options to get it to do so.
            Hide
            abayer Andrew Bayer added a comment -

            Got it - PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/261 fixing that and making a few other changes to when condition directive generation.

            Show
            abayer Andrew Bayer added a comment - Got it - PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/261 fixing that and making a few other changes to when condition directive generation.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/generator/WhenDirective.java
            pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/BuildingTagConditional.java
            pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/ChangeRequestConditional.java
            pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/TagConditional.java
            pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/generator/WhenDirective/config.jelly
            pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/ChangeRequestConditional/config.jelly
            http://jenkins-ci.org/commit/pipeline-model-definition-plugin/eac90be72124d7ef32d957af898a5eef913f478b
            Log:
            [FIXED JENKINS-50682] Actually pass descriptor to when condition forms

            Also add display name for a few when conditions, move all of
            ChangeRequestConditional's fields into advanced, since they're
            optional and all, and smack things around a bit internally to not
            display when directive parameters when they're not required and
            they've got an empty string value.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/generator/WhenDirective.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/BuildingTagConditional.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/ChangeRequestConditional.java pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/TagConditional.java pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/generator/WhenDirective/config.jelly pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/when/impl/ChangeRequestConditional/config.jelly http://jenkins-ci.org/commit/pipeline-model-definition-plugin/eac90be72124d7ef32d957af898a5eef913f478b Log: [FIXED JENKINS-50682] Actually pass descriptor to when condition forms Also add display name for a few when conditions, move all of ChangeRequestConditional's fields into advanced, since they're optional and all, and smack things around a bit internally to not display when directive parameters when they're not required and they've got an empty string value.
            Hide
            abayer Andrew Bayer added a comment -

            Merged, releasing today in Declarative 1.2.9.

            Show
            abayer Andrew Bayer added a comment - Merged, releasing today in Declarative 1.2.9.
            Hide
            bitwiseman Liam Newman added a comment -

            Bulk closing resolved issues.

            Show
            bitwiseman Liam Newman added a comment - Bulk closing resolved issues.

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                rtyler R. Tyler Croy
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: